Solved Command Bug Help

So I've been busy with this command. I've just testing and it almost worked. If you use /block it will convert 9 diamonds in 1 block. But the thing is, if I have for example 11 diamonds it will take them all away. And if I have 18, I only get one block. I have tried a couple of ways to fix this, but I couldn't figure it out.

Code:java

package nl.tovd1234.blocker;
 
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.Listener;
import org.bukkit.inventory.ItemStack;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin implements Listener {
 
    public void onEnable() {
        getServer().getPluginManager().registerEvents(this, this);
        getLogger().info("Blocker Plugin Enabled! - By tovd1234");
    }
 
    @Override
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
        Player player = (Player) sender;
        if (cmd.getName().equalsIgnoreCase("block")) {
            if (player.hasPermission("b.block"))
                if (player.getInventory().contains(Material.DIAMOND, 9)){
                    player.getInventory().remove(Material.DIAMOND);
                    player.getInventory().addItem(new ItemStack(Material.DIAMOND_BLOCK));
        player.sendMessage("§a§lYour items have been converted into blocks");}
 
                else {
                player.sendMessage("§a§lYou do not have enough items.");
                }
        }
        return false;
    }
}

Thanks, tovd1234

 

soo, first of all:
Player player = (Player) sender; <-- read my signature

secondly:
player.getInventory().remove(Material.DIAMOND); <-- this removes all diamonds from the inv instead you can:
player.getInventory().removeItem(new ItemStack(Material.DIAMOND, 9));

thirdly:
it wont give 2 diamond blocks since you do: player.getInventory().addItem(new temStack(Material.DIAMOND_BLOCK)); <-- this adds 1 diamond block.

to fix it all:
you have to use a loop.

Code:java

while(player.getInventory().contains(Material.DIAMOND, 9)){
//While players inventorry has 9 or more items, do the folowing:
player.getInventory().remove(new ItemStack(Material.DIAMOND,9));
//remove the 9 diamonds
player.getInventory().addItem(new ItemStack(Material.DIAMOND_BLOCK));
//add a diamond block
}
player.updateinventory();  //even tho its depricated, you still use it to update their inventorry after the while has finished.
 

sorry, the code is not written in a java editor so there might be errors.
Hope that helps

 

mine-care

It works fine now, but player.updateInventory(); looks like this: player.updateInventory();

I don't know what it means, but I think its an error.

And how do I code it so if I have diamonds for multiple blocks, that it uses as many diamonds as possible?

 

Okay first of all the player.updateInventory(); means that the updateinventory(); method is depricated then the code offered above should already create as many diamond blocks as it can ith player's diamonds in inventorry.
Does it or does it creater only 1 diamond block?

 

mine-care
If I execute the command with 64 diamonds in my inventory, it only makes 1 diamond block and removes 9 diamonds.

I also tried making this possiblke with gold and iron, I used || for it. But it gave me an Error.

Code:java

package nl.tovd1234.blocker;
 
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.Listener;
import org.bukkit.inventory.ItemStack;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin implements Listener {
 
public void onEnable() {
getServer().getPluginManager().registerEvents(this, this);
getLogger().info("Blocker Plugin Enabled! - By tovd1234");
}
 
@Override
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
Player player = (Player) sender;
if (cmd.getName().equalsIgnoreCase("block")) {
if (player.hasPermission("b.block"))
if (player.getInventory().contains(Material.DIAMOND, 9)){
player.getInventory().removeItem(new ItemStack(Material.DIAMOND, 9));
player.getInventory().addItem(new ItemStack(Material.DIAMOND_BLOCK));
player.updateInventory();
player.sendMessage("§a§lYour items have been converted into blocks");}
 
else {
player.sendMessage("§a§lYou do not have enough items.");
}
}
return false;
}
}

 

if(player.hasPermission("b.block")) <-- this needs { }
also you are not using the code i posted above replace all from line 23 up to line 31 with that i posted above

 

mine-care

I this right?

Code:java

package nl.tovd1234.blocker;
 
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.Listener;
import org.bukkit.inventory.ItemStack;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin implements Listener {
 
public void onEnable() {
getServer().getPluginManager().registerEvents(this, this);
getLogger().info("Blocker Plugin Enabled! - By tovd1234");
}
 
@Override
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
Player player = (Player) sender;
if (cmd.getName().equalsIgnoreCase("block")) {
if (player.hasPermission("b.block")){
while(player.getInventory().contains(Material.DIAMOND, 9)){
//While players inventory has 9 or more items, do the folowing:
player.getInventory().remove(new ItemStack(Material.DIAMOND,9));
//remove the 9 diamonds
player.getInventory().addItem(new ItemStack(Material.DIAMOND_BLOCK));}
//add a diamond block
}
player.updateInventory(); //even tho its depricated, you still use it to update their inventory after the while has finished.
player.sendMessage("§a§lYour items have been converted into blocks");}
 
else {
player.sendMessage("§a§lYou do not have enough items.");
}
return false;
}
}

I have a problem though. My server crashes when I use /block while I have more then 9 diamonds in my inventory, so it only works when I have 9 diamonds.
Or do I have to remove

Code:java

else {
player.sendMessage("§a§lYou do not have enough items.");

}

 

umm the error shown in console?

 

mine-care
No, the server just freezes. If I try to use /stop in the console it doesn't do anything as well.

 

tovd1234 what are the specs of the server? Because that means that it eather has hard time on the while but when it's done it will be back, or that our while is infinite and it causes mayhem. Ok just thought of something, move the player.updateInventory() in the while(){


}

 

mine-care
4485 MB Ram. Jre 8 64 Bit.

Now I have this:

Code:java

package nl.tovd1234.blocker;
 
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.Listener;
import org.bukkit.inventory.ItemStack;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin implements Listener {
 
public void onEnable() {
getServer().getPluginManager().registerEvents(this, this);
getLogger().info("Blocker Plugin Enabled! - By tovd1234");
}
public void onDisable() {
getServer().getPluginManager().registerEvents(this, this);
getLogger().info("Blocker Plugin Disabled! - By tovd1234");
}
 
@Override
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
Player player = (Player) sender;
if (cmd.getName().equalsIgnoreCase("block")) {
if (player.hasPermission("b.block")){
player.sendMessage("§a§lYour items have been converted into blocks");}
while(player.getInventory().contains(Material.DIAMOND, 9)){
//While players inventory has 9 or more items, do the following:
player.getInventory().remove(new ItemStack(Material.DIAMOND,9));
//remove the 9 diamonds
player.getInventory().addItem(new ItemStack(Material.DIAMOND_BLOCK));}
//add a diamond block
player.updateInventory();
}
 
else {
player.sendMessage("§a§lYou do not have enough items.");
}
return false;
}
}

I also think that it creates an infinitive loop is you execute the command, and thats probably why the server crashes. I don't know how, but I think I have to cancel the while at some time so it won't freeze.

There is also another problem; I think the while doesn't check if the player has the diamonds. Because I can just use /block and get a diamond block without having any diamonds.

 

Well the wile is self canceling when the condition given to it is false so in this case the condition is if player has 9 or more diamonds, and since we remove them when it runs player should end up with no or less than 9 diamonds in his inventorry.

Umm does it still do it after the player.updateinventorry?

 

mine-care

What does still do it?


And I know why while didn't work. I forgot to add {} after it!

But now I have another problem. I tried /block with a 64 diamonds in my hand, my whole inventory got filled with diamond blocks and the 64 diamonds were still in there. That also happened when I had 10 diamonds in my inventory. After that the server froze again.

 

I mean does the server still crash after we added the player.updateinventorry() in the while?

 

mine-care

Yes, its in there right now and it still crashes

Code:java

package nl.tovd1234.blocker;
 
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.Listener;
import org.bukkit.inventory.ItemStack;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin implements Listener {
 
public void onEnable() {
getServer().getPluginManager().registerEvents(this, this);
getLogger().info("Blocker Plugin Enabled! - By tovd1234");
}
public void onDisable() {
getServer().getPluginManager().registerEvents(this, this);
getLogger().info("Blocker Plugin Disabled! - By tovd1234");
}
 
@Override
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
Player player = (Player) sender;
if (cmd.getName().equalsIgnoreCase("block")) {
if (player.hasPermission("b.block")){
while(player.getInventory().contains(Material.DIAMOND, 9)){
//While players inventory has 9 or more items, do the following:
player.getInventory().remove(new ItemStack(Material.DIAMOND,9));
//remove the 9 diamonds
player.getInventory().addItem(new ItemStack(Material.DIAMOND_BLOCK));
//add a diamond block
player.updateInventory();}
}
else {
player.sendMessage("§a§lYou do not have enough items.");
}
}
return false;
}
}
 

If I have more then 9 diamonds my inventory get filled with stacks of diamond blocks. Idk how...

And the else does not work either. If I have less then 9 diamonds it won't say the message.

 

Ok, when I get on Mai pc I will check it too :3

 

mine-care
Ok
The Java Project: https://www.dropbox.com/sh/nlby6c6op9kpbrz/AACn7IeGDZ4L3LIEsPWWy5HDa?dl=0
(Click on the 3 dots on the right upper corner, then click download as .zip. Then extract it and place it in your eclipse workspace)

 

tovd1234 your infinite loop occurs because it never removes diamonds. remove(ItemStack) will look for the exact same stack, and I bet you don't have a slot with exactly 9 diamonds in your inventory. Use removeItem(ItemStack...items).

 

Thnx!! But do you know why the else is not working? Sorry I'm kinda new to this ^^

 

fireblast709
mine-care
I have uploaded my plugin to BukkitDev and it is working great! Thanks for the help guys!
(http://dev.bukkit.org/bukkit-plugins/prisonblocker/)