Combat plugin

@timtower Oh, i just thought you could give me the name for it(like what people call the method), anyway thanks.

 

@timtower I just tried looking up the method "System.currentTimeMillis()" but i can only find it used for getting the milliseconds between times and stuff like that. I don't understand how i should use it. :/ Any other methods or do you only recommend this one? If you recommend only this one then you think you can tell me where i can find more information for more uses for it?

 

@timtower Okay, thanks. I'll try including that and then looking it up again now. EDIT: I just looked it up(not finished tho) and i found out you can't tell the amount of time left, is that right? If you aren't able to get the amount of seconds left then is there another way to get that without it not being accurate when the server is lagging? Or is that impossible?

 

@timtower Okay, thanks for letting me know.
EDIT: Okay so i've tried but i just can't seem to find out what i need to do. :/
I haven't added anything new to my code but here it is:

Code:

public class OnDamageEvent implements Listener {
   
    public static HashMap<UUID, Integer> combat = new HashMap<UUID, Integer>();
   
    @SuppressWarnings("unused")
    private Main plugin;
   
    public OnDamageEvent(Main plugin) {
        this.plugin = plugin;
       
        Bukkit.getPluginManager().registerEvents(this, plugin);
    }
   
    @EventHandler
    public void onDamage(EntityDamageByEntityEvent e) {
        if (e.getDamager() instanceof Player && e.getEntity() instanceof Player) {
            Player victim = (Player) e.getEntity();
            Player attacker = (Player) e.getDamager();
            World victimWorld = victim.getWorld();
            World attackerWorld = attacker.getWorld();
           
            if (victimWorld.getName().equals("world1") && attackerWorld.getName().equals("world1")) {
                if (combat.containsKey(victim.getUniqueId())) {
                    combat.remove(victim.getUniqueId());
                    combat.put(victim.getUniqueId(), 20*10);
                } else {
                    combat.put(victim.getUniqueId(), 20*10);
                    victim.sendMessage(ChatColorUtil.chat("you have been attacked by " + attacker + ", don't log out!"));
                }
               
                if (combat.containsKey(attacker.getUniqueId())) {
                    combat.remove(attacker.getUniqueId());
                    combat.put(attacker.getUniqueId(), 20*10);
                } else {
                    combat.put(attacker.getUniqueId(), 20*10);
                    attacker.sendMessage(ChatColorUtil.chat("you have just attacked " + victim + ", don't log out!"));
                }
            } else if (victimWorld.getName().equals("world2") && attackerWorld.getName().equals("world2")) {
                if (combat.containsKey(victim.getUniqueId())) {
                    combat.remove(victim.getUniqueId());
                    combat.put(victim.getUniqueId(), 20*10);
                } else {
                    combat.put(victim.getUniqueId(), 20*10);
                    victim.sendMessage(ChatColorUtil.chat("you have been attacked by " + attacker + ", don't log out!"));
                }
               
                if (combat.containsKey(attacker.getUniqueId())) {
                    combat.remove(attacker.getUniqueId());
                    combat.put(attacker.getUniqueId(), 20*10);
                } else {
                    combat.put(attacker.getUniqueId(), 20*10);
                    attacker.sendMessage(ChatColorUtil.chat("you have just attacked " + victim + ", don't log out!"));
                }
            }
        }
    }

}

I don't quite understand what i should do. :/ Could you tell me some steps of what i should do (without code)? Also, this code is just me guessing that i could do it like that. I don't know(or think) that this would actually work but whatever, i'm just trying things out.

 

bump

 

bump, i deleted the whole project to start from scratch, i've come to this:
Class: EntityDamageByEntityEvent

Code:Java

 
public class EntityDamage implements Listener {
 
    private Main plugin;
 
    public EntityDamage(Main plugin) {
        this.plugin = plugin;
        Bukkit.getPluginManager().registerEvents(this, plugin);
    }
 
    @EventHandler
    public void onDamage(EntityDamageByEntityEvent e) {
        if (e.getEntity() instanceof Player && e.getDamager() instanceof Player) {
            if (e.getEntity() != e.getDamager()) {
                if (!e.isCancelled()) {
                    Player victim = (Player) e.getEntity();
                    Player attacker = (Player) e.getDamager();
                    UUID vid = victim.getUniqueId();
                    UUID aid = attacker.getUniqueId();
                    String vwn = victim.getWorld().getName();
                    Integer ct = plugin.getConfig().getInt("Combat-time");
                    for (String worlds : plugin.getConfig().getConfigurationSection("Worlds").getKeys(false)) {
                        if (worlds.contains(vwn)) {
                            if (Combat.log.containsKey(vid)) {
                                Combat.log.remove(vid);
                                Combat.log.put(vid, ct);
                            } else {
                                Combat.log.put(vid, ct);
                                victim.sendMessage("Someone attacked you!");
                            }
                            if (Combat.log.containsKey(aid)) {
                                Combat.log.remove(aid);
                                Combat.log.put(aid, ct);
                            } else {
                                Combat.log.put(aid, ct);
                                attacker.sendMessage("You attacked someone!");
                            }
                        }
                    }
                }
            }
        }
    }
}
 

The thing i am wondering about is how to start using System.currentTimeMillis(), it returns a long but my HashMap is <UUID, Integer> and not <UUID, Long>, should i change it to that or should i convert the long to an integer? If i should convert the long to an integer then how would i do that? Maybe i should do something like this?:

Code:Java

 
Integer time = (int) System.currentTimeMillis();
 

Or maybe not? Anyway, how would i get started with this?

 

@timtower Okay, thanks. Now what should i change this:

Code:Java

 
Integer ct = plugin.getConfig().getInt("Combat-time");
 

to? I want to have the "Combat-time" as an integer for seconds in the config. Maybe convert it from long to integer and integer to long again? :7

 

@timtower If you mean this:

Code:Java

 
Long ct = plugin.getConfig().getLong("Combat-time");
 

Then i know i can do that but would i be able to just use an int for that? Example:

Code:

Combat-time: 10

Or not? :7

 

@timtower Can't because i have an error when i attack someone. :7

Error (open) Error (close)

Code:

[22:17:22 ERROR]: Could not pass event EntityDamageByEntityEvent to CombatLog v0.1
org.bukkit.event.EventException
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:310) ~[spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
        at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:502) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:487) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
        at org.bukkit.craftbukkit.v1_8_R3.event.CraftEventFactory.callEvent(CraftEventFactory.java:87) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
        at org.bukkit.craftbukkit.v1_8_R3.event.CraftEventFactory.callEntityDamageEvent(CraftEventFactory.java:553) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
        at org.bukkit.craftbukkit.v1_8_R3.event.CraftEventFactory.handleEntityDamageEvent(CraftEventFactory.java:466) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
        at org.bukkit.craftbukkit.v1_8_R3.event.CraftEventFactory.handleLivingEntityDamageEvent(CraftEventFactory.java:585) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
        at net.minecraft.server.v1_8_R3.EntityLiving.d(EntityLiving.java:1102) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
        at net.minecraft.server.v1_8_R3.EntityHuman.d(EntityHuman.java:859) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
        at net.minecraft.server.v1_8_R3.EntityLiving.damageEntity(EntityLiving.java:743) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
        at net.minecraft.server.v1_8_R3.EntityHuman.damageEntity(EntityHuman.java:800) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
        at net.minecraft.server.v1_8_R3.EntityPlayer.damageEntity(EntityPlayer.java:496) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
        at net.minecraft.server.v1_8_R3.EntityHuman.attack(EntityHuman.java:1001) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
        at net.minecraft.server.v1_8_R3.EntityPlayer.attack(EntityPlayer.java:1063) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
        at net.minecraft.server.v1_8_R3.PlayerConnection.a(PlayerConnection.java:1355) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
        at net.minecraft.server.v1_8_R3.PacketPlayInUseEntity.a(SourceFile:52) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
        at net.minecraft.server.v1_8_R3.PacketPlayInUseEntity.a(SourceFile:11) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
        at net.minecraft.server.v1_8_R3.PlayerConnectionUtils$1.run(SourceFile:13) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
        at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) [?:1.8.0_161]
        at java.util.concurrent.FutureTask.run(Unknown Source) [?:1.8.0_161]
        at net.minecraft.server.v1_8_R3.SystemUtils.a(SourceFile:44) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
        at net.minecraft.server.v1_8_R3.MinecraftServer.B(MinecraftServer.java:715) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
        at net.minecraft.server.v1_8_R3.DedicatedServer.B(DedicatedServer.java:374) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
        at net.minecraft.server.v1_8_R3.MinecraftServer.A(MinecraftServer.java:654) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
        at net.minecraft.server.v1_8_R3.MinecraftServer.run(MinecraftServer.java:557) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
        at java.lang.Thread.run(Unknown Source) [?:1.8.0_161]
Caused by: java.lang.NullPointerException
        at me.karim.combatlog.listeners.EntityDamage.onDamage(EntityDamage.java:35) ~[?:?]
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_161]
        at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_161]
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_161]
        at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_161]
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:306) ~[spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
        ... 26 more

Do you know what is wrong? "NullPointerException", EntityDamage class line 35 is:

Code:Java

 
for (String worlds : plugin.getConfig().getConfigurationSection("Worlds").getKeys(false)) {
 

I guess that code is wrong. :7 This is the config that i'm trying to get at that part:

Code:

Worlds:
  - world

EDIT: Nvm fixed the error by changing it to this:

Code:Java

 
List<String> worlds = plugin.getConfig().getStringList("Worlds");
 

EDIT2: I tried this:

Code:Java

 
Player victim = (Player) e.getEntity();
Player attacker = (Player) e.getDamager();
UUID vid = victim.getUniqueId();
UUID aid = attacker.getUniqueId();
String vwn = victim.getWorld().getName();
Long ct = plugin.getConfig().getLong("Combat-time");
List<String> worlds = plugin.getConfig().getStringList("Worlds");
if (worlds.contains(vwn)) {
    if (Combat.log.containsKey(vid)) {
        Combat.log.remove(vid);
        Combat.log.put(vid, ct);
    } else {
        Combat.log.put(vid, ct);
        victim.sendMessage("Someone attacked you!");
    }
    if (Combat.log.containsKey(aid)) {
        Combat.log.remove(aid);
        Combat.log.put(aid, ct);
        attacker.sendMessage(Color.here("Combat-time: "+ct));
    } else {
        Combat.log.put(aid, ct);
        attacker.sendMessage("You attacked someone!");
    }
}
 

And the output is "Combat-time: 10" all the time. It should be that, right?

 

Bump, i've been trying to get this working and i currently have this:

Code:Java

public class EntityDamage implements Listener {
 
    private Main plugin;
 
    public EntityDamage(Main plugin) {
        this.plugin = plugin;
        Bukkit.getPluginManager().registerEvents(this, plugin);
    }
 
    Player attacker = null;
 
    @EventHandler
    public void onDamage(EntityDamageByEntityEvent e) {
        if (!e.isCancelled()) {
            if (e.getEntity() instanceof Player) {
                Player victim = (Player) e.getEntity();
                if (e.getDamager() instanceof Player) {
                    attacker = (Player) e.getDamager();
                } else if (e.getDamager() instanceof Projectile) {
                    Projectile entity = (Projectile) e.getDamager();
                    attacker = (Player) entity.getShooter();
                }
                if (attacker != null && victim != attacker) {
                    if (plugin.getConfig().getStringList("Worlds").contains(victim.getWorld().getName())) {
                        int time = plugin.getConfig().getInt("Combat-time");
                        if (!plugin.Combat().inCombat(victim)) {
                            plugin.Combat().setCombatTime(victim, time);
                            victim.sendMessage(plugin.Color(plugin.messages.getString("Combat.someone-attacked-you").replace("{attacker}", attacker.getName())));
                        } else {
                            plugin.Combat().removeFromCombat(victim);
                            plugin.Combat().setCombatTime(victim, time);
                        }
                        if (!plugin.Combat().inCombat(attacker)) {
                            plugin.Combat().setCombatTime(attacker, plugin.getConfig().getInt("Combat-time"));
                            attacker.sendMessage(plugin.Color(plugin.messages.getString("Combat.you-attacked-someone").replace("{victim}", victim.getName())));
                        } else {
                            plugin.Combat().removeFromCombat(attacker);
                            plugin.Combat().setCombatTime(attacker, time);
                        }
                        new BukkitRunnable() {
                            public void run() {
                                if (victim.isOnline()) {
                                    if (plugin.Combat().getCombatTime(victim) > 0) {
                                        plugin.Combat().setCombatTime(victim, plugin.Combat().getCombatTime(victim)-1);
                                    } else {
                                        cancel();
                                        plugin.Combat().removeFromCombat(victim);
                                        victim.sendMessage(plugin.Color(plugin.messages.getString("Combat.no-longer-combat")));
                                    }
                                } else {
                                    cancel();
                                }
                                if (attacker.isOnline()) {
                                    if (plugin.Combat().getCombatTime(attacker) > 0) {
                                        plugin.Combat().setCombatTime(attacker, plugin.Combat().getCombatTime(attacker)-1);
                                    } else {
                                        cancel();
                                        plugin.Combat().removeFromCombat(attacker);
                                        attacker.sendMessage(plugin.Color(plugin.messages.getString("Combat.no-longer-combat")));
                                    }
                                } else {
                                    cancel();
                                }
                            }
                        }.runTaskTimer(plugin, 20, 20);
                    }
                }
            }
        }
    }
}

But it seems to be acting weird when hitting/getting hit multiple times. (The time goes faster sometimes and not the same time for both players) Am i doing something wrong with the BukkitRunnable? I would like to get this fixed. Other than this i don't have any problems. (At least not yet)
Btw here is the combat class:

Code:Java

public class Combat {
 
    private HashMap<UUID, Integer> time = new HashMap<UUID, Integer>();
 
    public boolean inCombat(Player p) {
        return this.time.containsKey(p.getUniqueId());
    }
 
    public void setCombatTime(Player p, Integer integer) {
        this.time.put(p.getUniqueId(), integer);
    }
 
    public void removeFromCombat(Player p) {
        this.time.remove(p.getUniqueId());
    }
 
    public Integer getCombatTime(Player p) {
        return this.time.get(p.getUniqueId());
    }
}

The "plugin.Color("String")" just returns "ChatColor.translateAlternateColorCodes('&', string)".
EDIT: Here is the Main class:

Code:Java

public class Main extends JavaPlugin {
 
    public String Color(String s) {
        return ChatColor.translateAlternateColorCodes('&', s);
    }
 
    public File messagesFile = new File(getDataFolder()+"/messages.yml");
    public FileConfiguration messages = YamlConfiguration.loadConfiguration(messagesFile);
 
    private Combat combat;
 
    public Combat Combat() {
        return combat;
    }
 
    public void onEnable() {
        if (!getDataFolder().exists()) {
            getDataFolder().mkdirs();
        }
        if (!messagesFile.exists()) {
            saveResource("messages.yml", false);
        }
        saveDefaultConfig();
        this.combat = new Combat();
        new CommandCombatTime(this);
        new CommandPreprocess(this);
        new EntityDamage(this);
    }
}