Solved Clearing Inventory Leaves Ghost Items

I'm making a plugin so that when a player right clicks certain blocks in their inventory it executes code, specifically adding them to a team and moving them onto the next step, the next step requires their inventory to be cleared however when I clear it it leaves ghost items that don't go until interacted with.

Code:java

@EventHandler
public void PlayerInteract(PlayerInteractEvent event) {
Player player = event.getPlayer();
if(event.getAction().equals(Action.RIGHT_CLICK_AIR) || (event.getAction().equals(Action.RIGHT_CLICK_BLOCK))){
if(player.getItemInHand().getType().toString() == "DIAMOND_BLOCK"){
Team.addToTeam(TeamType.BLUE, player);
player.getInventory().clear();
} else if(player.getItemInHand().getType().toString() == "REDSTONE_BLOCK"){
Team.addToTeam(TeamType.RED, player);
player.getInventory().clear();
} else if(player.getItemInHand().getType().toString() == "EMERALD_BLOCK"){
Team.addToTeam(TeamType.GREEN, player);
player.getInventory().clear();
} else if(player.getItemInHand().getType().toString() == "GOLD_BLOCK"){
Team.addToTeam(TeamType.YELLOW, player);
player.getInventory().clear();
 
}
}

Any help/advice you can offer is greatly appreciated

 

Code:java

@EventHandler
public void PlayerInteract(PlayerInteractEvent event) {
Player player = event.getPlayer();
if(event.getAction().equals(Action.RIGHT_CLICK_AIR) || (event.getAction().equals(Action.RIGHT_CLICK_BLOCK))){
if(player.getItemInHand().getType().toString() == "DIAMOND_BLOCK"){
Team.addToTeam(TeamType.BLUE, player);
player.getInventory().clear();
}
if(player.getItemInHand().getType().toString() == "REDSTONE_BLOCK"){
Team.addToTeam(TeamType.RED, player);
player.getInventory().clear();
}
if(player.getItemInHand().getType().toString() == "EMERALD_BLOCK"){
Team.addToTeam(TeamType.GREEN, player);
player.getInventory().clear();
}
if(player.getItemInHand().getType().toString() == "GOLD_BLOCK"){
Team.addToTeam(TeamType.YELLOW, player);
player.getInventory().clear();
}
}

 

Didn't make any difference

 

You should use .getType().equals(Material.DIAMOND_BLOCK) etc.

 

Maybe you need to add a little

Code:java

 
        player.updateInventory();
 

 

Garris0n
The code still executed, this doesn't change it, is it better practice to use .equals()?

SenseTheGod
Thank you, this fixed it

 

Yes, it is better practice. Also, I'm surprised it worked at all seeing as you're comparing strings with ==.

 

Haha, Your the first person i ever helped! Your welcome man <3

 

Might be a necrobump/pointless information, but I think toString would return the same string object because of the string pool in the JVM.

 

Cirno toString() makes it return "GOLD_BLOCK" rather than "Material.GOLD_BLOCK", I use it for a different purpose later on, just keeping my code all the same

 

For future reference, using toString() on items doesn't always return their Material name. For instance, SHOVEL returns as SPADE.

 

But would valueOf("SPADE") and valueOf("SHOVEL") both return the correct thing?

 

unrealdesign Can't say for sure, as I've never tried it. I just used the strings for a custom enchantments plugin at one time.