Changing a String --> Player ?

Oke, sooo the AdminPanel plugin is getting a total rewrite and im going to put some nice thingies in.
Tough i cant get 1 thing fixed:

Banning, i think this method should work:

Code:

        if (thePlayer.isBanned()) {
            thePlayer.setBanned(false);
        }
        else {
            thePlayer.setBanned(true);
            thePlayer.kickPlayer("You got banned by: " + theSender.getName());
        }

At least, i dont see whats wrong with it... But it creates a nullpointer...
Thanks alot!

 

is thePlayer null?

 

Nope, Player thePlayer is the player i just got out of the text field.
Im sure that it is the isBanned() method, but i think im just using it wrong...
Same for isOnline() with me...

Can someone help me?

 

http://forums.bukkit.org/threads/re...ubleshoot-your-own-plugins-by-yourself.32457/
After reading that (if you then still can't figure it out), try posting a detailed error description that we can actually do something with (Hint: that is NOT like "meeh, throws NPE, why no work :/").

 

I dont wanna bich, but thats not what i did?
Anyway, i have read it all. Everything that was there, i knew allmost all already tough...
Still cant figure it out... The nullpointer is leading to line 114, which is that line i specified above:

Code:

if (thePlayer.isBanned()) {
    // do something
}

 

It means thePlayer is null, and whatever method you're using to grab thePlayer (which you should post here) isn't working properly.

 

Post the error you get. The entire error.

 

I was exaggerating to show what I meant. But all you posted was some code and "it creates a nullpointer".
Anyway, my post was focused on the word "detailed". Now you at least posted the line where it is thrown, but still no stack-trace. Even though it is now to 90% thePlayer that is null, it could still not be the top-most entry in your stacktrace and the NPE is caused inside of the method (as far as we know from your information).

When it is the top-most entry of the stack-trace, then you can be 100% sure that thePlayer is null, so then for us to help it is significant to see the declaration of thePlayer.

 

Try doing something like:
if (thePlayer.isBanned()) {
try{ thePlayer.setBanned(false);
}
catch(Exception ex) { logger.info(ex.toString()); } } else {
try{ thePlayer.setBanned(true); thePlayer.kickPlayer("You got banned by: " + theSender.getName());
}
catch(Exception ex) { logger.info(ex.toString()); } }

 

did you remember to convert the string it takes from a textbox into an actual player?

 

Ignore the post two posts above mine, please.
You do not need to try-catch-everything, because all Java exceptions are already shown in the console.

 

Maybe posting the entire class or atleast the entire section of code relating to this play starting from an if doesnt help much if we cant see where your getting player from.

 

I threw some debuggers in:
Can someone give me a method that changes a String into a player?
Thanks, because thats the problem.. My changing method doesnt work...

What i used:

Code:

Player thePlayer = plugin.getServer().getPlayer(thePlayerString);

plugin.getServer(); If you want to get the server

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Bukkit.gerServer() is better, but that method should work, you should just check whether the player is null afterwards (and that is the case when the player could not be found).

 

Can you add me on skype for a second? Because i just cant get it fixed...
@Pandemoneus

 

Not using Skype.

 

Code:

        Player thePlayer = plugin.getServer().getPlayer(thePlayerString);

        if (thePlayer.isOnline()) {

How do i do this?

Code:

isOnline()
isBanned()
isOP()

All gives a nullPointer for me, but im sure it is a player...

 

Code:java

Player thePlayer = plugin.getServer().getPlayer(thePlayerString);
 
if (thePlayer != null) {
    // do all your previous stuff
} else {
    //send an error message
}

 

the only reason why getPlayer would return null is if a player couldn't be found with that name on the server.

 

Code:Java

 
Player[] plist = plugin.getServer().getOnlinePlayers();
for (Player p:plist)
{
   if(p.getName().equalsIgnoreCase(nameofplayeryouwanttoban));
   {
        p.kickPlayer("The Ban Hammer has spoken!");
        p.setBanned(true);
        break;
    }
}
 

 

@Technius
You do lots of unneeded checks when you could get the player directly instead. Also, this won't work to unban players.

 

But it works for online players. And getPlayer may not work with offline players. Banned players are usually offline.

 

Well, i fixed it myself.. Thanks everyone!
And i think the method isOnline() is not working...

Wanna see the result: YouControl

 

Thank you very much you just sorted out one of my problems

 

I'd rather like to see the source, lol.

 

if its a command do
Player playa = getServer.getPlayer(args[0]);
if(playa !=null){
sender.sendMessage("Blah");
} else {
sender.sendMessage("Derp");
}
return true;
}
is that what you lookin for?

 

@emericask8ur Thats what i WAS looking for yes :3
Thanks!

 

And what's so different from mine earlier?