Better way to do this?

I'm making some commands, and it's annoying me having to do so many argument length checks.
My code basically looks like this:

Code:java

if (args.length >= 1) {
    if (args[0].equalsIgnoreCase("cool")) { 
        if (args.length >= 2) {
            if (args[1].equalsIgnoreCase("awesome")) { 
                //actual command code..
            } else if (args[1].equalsIgnoreCase("command")) { 
                if (args.length >= 4) {
                    if (args[2].equalsIgnoreCase("win")) {
                       //actual command code..
                    }
                }
            }
        }
    }
}

There's just a bunch of sterpid check everywhere. Is there a better way to make the code flow?

 

EDIT: you can snip out the command logic for each argument into it's own method in the same executor to clean it up slightly so your method is not very long

OR

You can use a whole series of CommandExecutors then use a map to determine which commandExecutor to delegate to. Constructing the original command map itself however is not the most pretty thing.

BUT

You will need to have some piece of code that determines what what the string is, be it if statements or some sort of switch statement, or leveraging a map and its get function.

 

lol maybe i'll just continue this way. it's not very pretty, but it works

 

I hear you, but I don't know that there is a more effective way to do it, other than optimizing the layout of conditionals to whatever method suits you.

One notable thing is that you could combine your arg length and arg equals checks, as long as the length check comes first.

Realistically args comparison in a command executor doesn't really matter for efficiency, so it's just about what looks nice and what's maintainable.

To be fair, normally there would be more involved, a whole slew of else's that handle the optional parameters.

 

I did something like this on my latest plugin. Kept things clean.

PHP:

if(args.length == 0)
{
     showhelp(p, 1);
     return true;
}
else
{
          String a0 = args[0].toString();
          int ipage = -1;
     
          try  
          {  
                if(args.length > 0)
                ipage = Integer.parseInt( a0 );  
          }  
          catch( Exception e) {}
         
          if(ipage != -1)
          {
                showhelp(p, ipage);
                return true;
          }else{
                if (a0.equalsIgnoreCase("claim")) { claim(p, args); return true;}
                if (a0.equalsIgnoreCase("auto")) { auto(p, args); return true; }
                if (a0.startsWith("home") || a0.startsWith("h")) { home(p, args); return true;}
                if (a0.equalsIgnoreCase("info") || a0.equalsIgnoreCase("i")) { info(p, args); return true;}
                if (a0.equalsIgnoreCase("comment")) { comment(p, args); return true;}
                if (a0.equalsIgnoreCase("comments") || a0.equalsIgnoreCase("c")) { comments(p, args); return true;}
                if (a0.equalsIgnoreCase("biome") || a0.equalsIgnoreCase("b")) { biome(p, args); return true;}
                if (a0.equalsIgnoreCase("biomelist")) { biomelist(p, args); return true;}
                if (a0.equalsIgnoreCase("id")) { id(p, args); return true;}
                if (a0.equalsIgnoreCase("tp")) { tp(p, args); return true;}
                if (a0.equalsIgnoreCase("clear")) { clear(p, args); return true;}
                if (a0.equalsIgnoreCase("reset")) { reset(p, args); return true;}
                if (a0.equalsIgnoreCase("add") || a0.equalsIgnoreCase("+")) { add(p, args); return true;}
                if (a0.equalsIgnoreCase("remove") || a0.equalsIgnoreCase("-")) { remove(p, args); return true;}
                if (a0.equalsIgnoreCase("setowner") || a0.equalsIgnoreCase("o")) { setowner(p, args); return true;}
                if (a0.equalsIgnoreCase("move") || a0.equalsIgnoreCase("m")) { move(p, args); return true;}
                if (a0.equalsIgnoreCase("reload")) { reload(s, args); return true;}
          }
}