Best way to save a bunch of staff

Well. I post this because i have a plugin that saves a bunch of values to a .yml.
The problem its that the server kick all the players while its saving the values and if i want to retrive the values of the .yml the server stops all the animations and stuff going.
If someone could say me a better way to save values.

 

What?..

If your server is freezing from saving and retrieving values from yaml, you're probably doing something wrong.

 

RealDope I want to save lots of strings to a file. I want to know the best way.

 

If you have massive amounts of data to save, a database is the way to go.

That said, I agree with RealDope. It would take a lot of data getting written to freeze the main thread long enough to kick everyone off. You are probably doing something ineffectively or in a very weird way.

 

LordManegane
We can't help you until you post your code and/or your .yml (preferably both to help us). If either is long, I recommend using pastebin.

 

RealDope the server freeze but before the action stop, it keeps going on normaly

 

LordManegane
Please post the code... What are you doing? We don't know.

 

LordManegane
Dang, you making a game inside of a game or what? It's likely that your code is inefficient.

 

The_Doctor_123 xTrollxDudex AoH_Ruthless FinalFred Thanks to everyone for quick the quick reply.

Saving:

Code:java

 
public static void save(Player player,Location l1, Location l2,String seleccion, String path){
 
for(int x = minX; x <= maxX; x++){
for(int y = minY; y <= maxY; y++){
for(int z = minZ; z <= maxZ; z++){
i++;
 
File pFile = new File(path);
FileConfiguration pConfig = YamlConfiguration.loadConfiguration(pFile);
Location l = new Location(Bukkit.getWorld(player.getWorld().getBlockAt(x,y,z).getWorld().getName()), x, y, z);
 
pConfig.set("y"+i, (y));
pConfig.set("z"+i, (z));
pConfig.set("world"+i, (player.getWorld().getName()));
pConfig.set("blocks", pConfig.getInt("blocks")+1);
pConfig.save(pFile);
}
}
}
}

Loading

Code:java

public static void load(String seleccion, final CommandSender sender, String path){
File pFile = new File(path);
final FileConfiguration pConfig = YamlConfiguration.loadConfiguration(pFile);
sender.sendMessage("Loading");
for(int i = 0; i <= pConfig.getInt("blocks");i++){
try{
 
double x = pConfig.getDouble("x"+i);
double y = pConfig.getDouble("y"+i);
double z = pConfig.getDouble("z"+i);
String world = pConfig.getString("world"+i);
Location l = new Location(Bukkit.getWorld(world),x, y, z);
l.getBlock().setTypeId(1);
 
 
}catch(Exception e){
i = 0;
 
}
}
}

Thats the code

 

x^3 time complexity on the for loops, and saving on every iteration of the z variable? For one, move variables used throughout the method outside of the loops, and clean up whatever that is with the loops.

 

Agreed with what 1Rogue said. What you're doing is parsing a file, changing a few values, and then saving a file... and you're doing that each time once for every block. That is extremely ineffecient. File operations (opening to read, opening to write, actually reading/writing) are somewhat slow. They're not actually all that slow (a few milliseconds), but when you're dealing with O(x^3) complexity, those few milliseconds can translate to a lot of time.

On top of that, there's a little bit of overhead using Block objects. This may or may not be a big deal depending on exactly what you have min/max X,Y,Z set to.

What you should do instead is keep a list of key/value pairs you plan on saving to the configuration file, but keep those in ram before you try writing them to disk. The easiest way to do so is just to follow 1Rogue's advice and move...

Code:

File pFile = new File(path);
FileConfiguration pConfig = YamlConfiguration.loadConfiguration(pFile);

... outside of the for loops, and move the save call to after the for loops have finished executing. You're able to do this since I believe FileConfiguration uses an in-memory map to store values until you actually tell it to save to file. If that's not the case, just make your own. Moving the other variables you're using from inside the loop to outside won't do much.

Also, you don't need to set the "blocks" config value every time either. Set it once at the end of the loop (using "i" to figure out how many blocks were saved). The same thing applies to world.

Also, I think you meant to save "x"+i as well. You're only saving y and z.

 

FinalFred Thanks!!! Now it works mutch better, its stays lagging the game but its a lot faster.
I really made a mistake because i put the pFile and pConfig at the for and i doesnt get that i do that.
Also thank to all the people that reply.

 

I would also check to make sure that file exists before you load it as a yaml configuration. Null checks are best checks