Add cooldown to sub kits?

Hello, I'm making a kit plugin. All I need to add now is the part I don't know how to add. I want my kit diamond to have 30 minutes cooldown on it. This is my code so far:

Code:java

package com.BeastCraft3.SoccerKitZ;
 
import java.util.HashSet;
import java.util.UUID;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.Sound;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.PlayerDeathEvent;
import org.bukkit.event.inventory.InventoryClickEvent;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.PlayerInventory;
import org.bukkit.inventory.meta.ItemMeta;
import org.bukkit.plugin.java.JavaPlugin;
 
public class KitZ extends JavaPlugin implements Listener{
 
    public HashSet<UUID> set = new HashSet<UUID>();
 
    public void onEnable() {
        getServer().getPluginManager().registerEvents(this, this);
    }
 
    public void onDisable() {
 
    }
 
    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String []args) {
        if (cmd.getName().equalsIgnoreCase("kit")) {
            Player p = (Player) sender;
            PlayerInventory pi = p.getInventory();
            if (args.length == 0) {
                openGUI(p);
                return true;
            }
            else if (args.length == 1) {
                if (args[0].equalsIgnoreCase("diamond")) {
                    if(set.contains(p.getUniqueId())) {
                        p.sendMessage("§cYou have already selected a kit!");
                    } else {
                        set.add(p.getUniqueId());
                        p.sendMessage(ChatColor.DARK_AQUA + "Kit recieved!");
                        p.getInventory().addItem(new ItemStack(Material.DIAMOND_SWORD, 1));
                        p.getInventory().addItem(new ItemStack(Material.DIAMOND_AXE, 1));
                        p.getInventory().addItem(new ItemStack(Material.DIAMOND_PICKAXE, 1));
                        p.getInventory().addItem(new ItemStack(Material.IRON_HOE, 1));
                        p.getInventory().addItem(new ItemStack(Material.COOKED_BEEF, 320));
                        p.getInventory().addItem(new ItemStack(Material.FLINT, 320));
                        p.getInventory().addItem(new ItemStack(Material.SEEDS, 128));
                        p.getInventory().addItem(new ItemStack(Material.CLAY_BALL, 128));
                        p.getInventory().setBoots(new ItemStack(Material.DIAMOND_BOOTS));
                        pi.setLeggings(new ItemStack(Material.DIAMOND_LEGGINGS));
                        pi.setChestplate(new ItemStack(Material.DIAMOND_CHESTPLATE));
                        pi.setHelmet(new ItemStack(Material.DIAMOND_HELMET));
                        return true;
                    }
                }
                if (args[0].equalsIgnoreCase("basic")) {
                    if(set.contains(p.getUniqueId())) {
                        p.sendMessage("§cYou have already selected a kit!");
                    } else {
                        p.sendMessage(ChatColor.DARK_AQUA + "Kit recieved!");
                        p.getInventory().addItem(new ItemStack(Material.IRON_SWORD, 1));
                        p.getInventory().addItem(new ItemStack(Material.STONE_HOE, 1));
                        p.getInventory().addItem(new ItemStack(Material.IRON_AXE, 1));
                        p.getInventory().addItem(new ItemStack(Material.IRON_PICKAXE, 1));
                        p.getInventory().addItem(new ItemStack(Material.COOKED_BEEF, 160));
                        p.getInventory().addItem(new ItemStack(Material.FLINT, 128));
                        p.getInventory().addItem(new ItemStack(Material.SEEDS, 96));
                        p.getInventory().addItem(new ItemStack(Material.CLAY_BALL, 96));
                        p.getInventory().setBoots(new ItemStack(Material.IRON_BOOTS));
                        pi.setLeggings(new ItemStack(Material.IRON_LEGGINGS));
                        pi.setChestplate(new ItemStack(Material.IRON_CHESTPLATE));
                        pi.setHelmet(new ItemStack(Material.IRON_HELMET));
                        return true;
                    }
                }
            }
        }
        return false;
    }
 
    @EventHandler
    public void onPlayerDeath(PlayerDeathEvent e) {
        Player pla = e.getEntity();
        if(set.contains(pla.getUniqueId())) {
            set.remove(pla.getUniqueId());
        }
    }
 
    private void openGUI(Player player) {
        Inventory inv = Bukkit.createInventory(null, 9, ChatColor.DARK_RED + "Kit Selector");
 
        ItemStack Kit_Diamond = new ItemStack (Material.DIAMOND_SWORD);
        ItemMeta Kit_DiamondMeta = Kit_Diamond.getItemMeta();
 
        ItemStack Kit_Basic = new ItemStack (Material.IRON_SWORD);
        ItemMeta Kit_BasicMeta = Kit_Basic.getItemMeta();
 
        Kit_DiamondMeta.setDisplayName(ChatColor.BLUE + "Kit Diamond");
        Kit_Diamond.setItemMeta(Kit_DiamondMeta);
 
        Kit_BasicMeta.setDisplayName(ChatColor.BLUE + "Kit Basic");
        Kit_Basic.setItemMeta(Kit_BasicMeta);
 
        inv.setItem(1, Kit_Basic);
        inv.setItem(2, Kit_Diamond);
 
        player.openInventory(inv);
    }
 
    @EventHandler
    public void onInventoryClick(InventoryClickEvent event) {
        if(!ChatColor.stripColor(event.getInventory().getName()).equalsIgnoreCase("Kit Selector"))
            return;
        Player player = (Player) event.getWhoClicked();
        event.setCancelled(true);
 
        if(event.getCurrentItem()==null || event.getCurrentItem().getType()==Material.AIR||!event.getCurrentItem().hasItemMeta()){
            player.closeInventory();
            return;
        }
 
        switch (event.getCurrentItem().getType()){
        case DIAMOND_SWORD:
            player.getWorld().playSound(player.getLocation(),
                    Sound.GHAST_FIREBALL, 3f, 3f);
            player.performCommand("kit diamond");
            player.closeInventory();
            player.sendMessage(String.format("%sEnjoy %sKit Diamond", ChatColor.RED, ChatColor.BLUE));
            break;
        case IRON_SWORD:
            player.getWorld().playSound(player.getLocation(),
                    Sound.GHAST_FIREBALL, 3f, 3f);
            player.performCommand("kit basic");
            player.closeInventory();
            player.sendMessage(String.format("%sEnjoy %sKit Basic", ChatColor.RED, ChatColor.BLUE));
            break;
            default:
                player.closeInventory();
                break;
        }
 
    }
 
}
 

 

Use a scheduler.

 

Darkpicasa
I already know that ;P

 

Then what are you asking?

 

How to use a runnable and make it with a cooldown on 30 minutes.
If I remember right after tutorials 1 seconds = 20 ticks.
so 1 minute should be: 1200 ticks
30 minutes = 36000 ticks

 

No. There is absolutely no reason to waste CPU cycles on this.

BeastCraft3

Attach metadata to the Player that contains the the last time they performed an action, then when they try to use it again, check the metadata to see if enough time has elapsed.

 

mythbusterma
Ive never done something like that ;P example code?

 

BeastCraft3

Code:java

Player player;
player.setMetadata("plugincooldown", new FixedMetadataValue(plugin, System.currentTimeMillis());
 
 
// later on:
 
if(System.currentTimeMillis - player.getMetadata("plugincooldown").get(0).asLong() > differenceInMillis) {
    // allowed
}
else {
    // disallowed
}
 

The String that you use to identify it should be a constant, along with differenceInMillis, but that's the general idea.

 

mythbusterma
honestly I didn't understand much of that ;3 Never worked with that system, any easier ways or more detailed code ?

 

BeastCraft3 More detailed code? He gave you all of the relevant code.

 

BeastCraft3

Basically you attach extra information to the Player, and the retrieve that information later on. That is the concept of Bukkit's metadata system.

You later retrieve the original time that the player executed the action, and compare it to the current time, that will give you the difference in times, using this you can find out if enough time has elapsed for them to perform the action again.

 

mythbusterma AdamQpzm
I'm just guessing after knowledge now. Something like this?

Code:java

Player player;
player.setMetadata("cooldown", new FixedMetadataValue(plugin, System.currentTimeMillis());
 
 
Don't understand what I should put here
 
if(System.currentTimeMillis -((long)player.getMetadata("plugincooldown")) > differenceInMillis) {
if(set.contains(p.getUniqueId())) {
                        p.sendMessage("§cYou have already selected a kit!");
                    } else {
                        set.add(p.getUniqueId());
                        p.sendMessage(ChatColor.DARK_AQUA + "Kit recieved!");
                        p.getInventory().addItem(new ItemStack(Material.DIAMOND_SWORD, 1));
                        p.getInventory().addItem(new ItemStack(Material.DIAMOND_AXE, 1));
                        p.getInventory().addItem(new ItemStack(Material.DIAMOND_PICKAXE, 1));
                        p.getInventory().addItem(new ItemStack(Material.IRON_HOE, 1));
                        p.getInventory().addItem(new ItemStack(Material.COOKED_BEEF, 320));
                        p.getInventory().addItem(new ItemStack(Material.FLINT, 320));
                        p.getInventory().addItem(new ItemStack(Material.SEEDS, 128));
                        p.getInventory().addItem(new ItemStack(Material.CLAY_BALL, 128));
                        p.getInventory().setBoots(new ItemStack(Material.DIAMOND_BOOTS));
                        pi.setLeggings(new ItemStack(Material.DIAMOND_LEGGINGS));
                        pi.setChestplate(new ItemStack(Material.DIAMOND_CHESTPLATE));
                        pi.setHelmet(new ItemStack(Material.DIAMOND_HELMET));
                        return true;
                    }
                }
else {
p.sendMessage("You cannot use this kit until " + cooldown);
}

 

BeastCraft3

That's fine, as long as you define cooldown to be some meaningful variable.

It's two different pieces of code, and they go in two separate places, one is placement, the other retrieval.

 

mythbusterma
ok, this is to hard for someone who has never tried it and isn't the best in english.
easier ways?

 

BeastCraft3

This isn't very difficult, even if you don't speak English very well.

 

mythbusterma
ok ;P I'll try to find some easy tutorials cause I dindn't understand the code you gave me, thanks anyway

 

AdamQpzm I think he was asking for explanations.

BeastCraft3 I'm kinda bored, so.... there we go. In the code mythbusterma posted :

Code:java

player.setMetadata("plugincooldown", new FixedMetadataValue(plugin, System.currentTimeMillis());

In this line, you set the player's metadata with Player#setMetadata(). The"FixedMetadataValue" thing is just a class used to wrap the value you are setting. The first argument of it's constructor takes the plugin, and the second is the value you are really setting. In this code, the current time in milliseconds is being set. In short: this is like noting down the last time where a player performed an action.

Code:java

if(System.currentTimeMillis -((long)player.getMetadata("plugincooldown")) > differenceInMillis) {
// allowed
} else {
// disallowed
}

Apart form the ClassCastException you'll get when trying to cast a FixedMetadataValue to a long, this if statement is supposed to check whether or not the player can execute again the action. The way it works is simple: it checks down the note indicating the last time a player performed the action. Then, it substract it from the current time :

Code:java

// **Invalid code, don't use it**
if (System.currentTimeMillis() - player.getMetadata([...]).get(0).value() > [...])

This returns the difference in milliseconds between the last time a player performed the action, and the current time. In other words, how long ago the player executed the action. This value is then compared to 'differenceInMillis':

Code:java

if ([...] > differenceInMillis)

If I understand right, here differenceInMillis is the time the player has to wait before performing the action again. If you want to impose a delay of 5 seconds, this would be 5000. Now if the last time the player executed the action is bigger than differenceInMillis, then logically, enough time has passed so that the player can perform the action again; that is why it says "allowed". In the other case, the player is still under cooldown; therefore he cannot perform the action again.

To conclude, I'd like to point out a few things to keep in mind:

• The player may not have the metadata indicating the last time he performed the action; this would mean he never performed it, and that it should be allowed.
• The label you use for getting/setting metadata must be the same. In the code you posted there is "cooldown" and "plugincooldown".
• Speaking of the label, I'd choose another one, that you know no one else would think of. "cooldown" is a very common label and other plugins might use it too. This can create big conflicts later.
• If the action is allowed you must put the player under cooldown by setting his metadata. You forgot to do that in the code you posted.

 

Totom3

Right, sorry. I meant:

Code:java

player.getMetadata().get(0).asLong()

My mistake.

 

BeastCraft3 Use a Arraylist and and a scheduler. Check if the player is in the scheduler if so deny them if not allow them. then add them to the list. then make a scheduler of 30min then after 30min remove them from the list

 

No, actually, don't do that.

http://colonelhedgehog.weebly.com/intermediate/intermediate-1-cooldowns-done-the-right-way

What he had was pretty much fine.

EDIT: Meaning the comparing of the times method.

 

ColonelHedgehog im still learning haha xd

 

BeastCraft3
This cooldown tutorial helped me. I use it all the time now.
https://forums.bukkit.org/threads/cooldown-manager.290459/

 

Hex_27
cool, could you give me one of your codes that use it so I have someone to work after? I've been learning java for a little while now, just starting learning the bukkit api properly.

 

BeastCraft3 Can't you write your own?

 

Hex_27

Hooray! Abusing static like there's no tomorrow!

 

mythbusterma
emmm....

 

BeastCraft3

?
Is this thread not solved? We've done what we can to help.

 

mythbusterma
not really done but i'll try to find it out my self(for better experience) using the info you guys told me. Bye!

 

Static has its uses, but only as a Utility function or for things that last for the entire runtime. i.e. Date.getTime(whatever); might be a valid use. Or:

Code:

private Main plugin;
public static Plugin getPlugin()
{
    return plugin;
}

People usually frown upon the use of the static modifier unless you're using it when it's necessary. It's a lot easier to use the static modifier, but like volatile, transient, and synchronous modifiers, most of the time it's best to tie things to the object.

 

ColonelHedgehog

I don't see what those modifiers have to do with this, unless you mean commonly abused modifiers, in which case, I agree.

And the example you gave is a valid example of a Singleton design pattern, which there is nothing wrong with. However, the other class that was referenced was not designed with a singleton sensibility about it, and was extremely flawed.