Solved PotionEffect on PlayerItemHeldEvent

Hey, I want to make it so that when a player has a certain item in-hand it gives them a potion effect for example Night Vision and when the player switches to another item the potion effect gets removed. How would I go about doing this? Making a repeating task when a player logs in doesn't seem right and would cause lag. Thanks

 

I don't think there's actually an event for a player changing the item in their hand... I really suggest a repeating task.

EDIT: PlayerItemHeldEvent

 

Marten Mooij PlayerItemHeldEvent Does exactly what you want

 

So here is my really simple code:

Code:java

 @EventHandler
public void onItemSwitch1(PlayerItemHeldEvent event){
Player player = event.getPlayer();
if(player.getItemInHand().hasItemMeta()){
if(player.getItemInHand().getItemMeta().getDisplayName().contains(ChatColor.WHITE + main.getConfig().getString("Cleaver-itemName"))){
player.sendMessage(ChatColor.GOLD + "Cleaver in-hand");
//Do Amazing Stuff Here
}
}
}
}

The problem is when I switch to the Cleaver the event doesn't get "triggered" but when I switch away from the Cleaver it does. Is there something I am missing or does this event need some extra "Special" code? Lemme tag you real quick: TheMcScavenger Chiller

 

Try event.getNewSlot() instead of player.getItemInHand()
http://jd.bukkit.org/rb/apidocs/org/bukkit/event/player/PlayerItemHeldEvent.html#getNewSlot()

Edit: Reason: Player.getItemInHand() is most likely the previous slot the item was in (meaning the event would be fired before the item switches?).

 

TheMcScavenger Thank you. I got it to work, I will keep this piece of code in mind for the future:

Code:java

ItemStack item = player.getInventory().getItem(event.getNewSlot());

If you were wondering how I did it here you go:

Code:java

    @EventHandler
    public void onItemSwitch1(PlayerItemHeldEvent event){
    Player player = event.getPlayer();
    ItemStack item = player.getInventory().getItem(event.getNewSlot());
 
    if(item != null && item.getTypeId() == 293){
    if(item.hasItemMeta()){
    if(item.getItemMeta().getDisplayName().contains(ChatColor.WHITE + main.getConfig().getString("Cleaver-itemName"))){
 
    player.addPotionEffect(new PotionEffect(PotionEffectType.SLOW_DIGGING, 10000, 4));
    Cleaver.add(player.getName());
    //Do awesome stuff out of this event.
    }
    }
    }
    }

Thank you for helping TheMcScavenger and Chiller it's not much but here you go:

 

Thank you so much! Idk you guys are reading this but I needed this so much!