Teleport each player from arraylist to a random location

For some reason my code teleports ALL players in the list to the same random location. What I want is each player to be teleported to a random location (Not the same location). Here's the code:

Code:java

public static void teleport() {
        World world = Bukkit.getServer().getWorld(Main.uhcConfig.getString("World"));
        Random generator = new Random();
        int rand_x = generator.nextInt(Main.uhcConfig.getInt("World Border Radius"));
        int rand_z = generator.nextInt(Main.uhcConfig.getInt("World Border Radius"));
        int y = world.getHighestBlockYAt(rand_x, rand_z) + 2;
        boolean safe = false;
        Location loc;
        while (!safe) {
            y++;
            loc = new Location(world, rand_x, y, rand_z);
            Block block = loc.getBlock();
            Material downType = block.getRelative(BlockFace.DOWN).getType();
            if (downType != Material.AIR && downType != Material.LAVA && downType != Material.WATER && downType != Material.STATIONARY_WATER) {
                if (block.getType() == Material.AIR && block.getRelative(BlockFace.UP).getType() == Material.AIR) {
                    safe = true;
                    for (String playerName : Game.getPlayers()) {
                        Player player = Bukkit.getServer().getPlayer(playerName);
                        if (player != null) {
                            rand_x = generator.nextInt(Main.uhcConfig.getInt("World Border Radius"));
                            rand_z = generator.nextInt(Main.uhcConfig.getInt("World Border Radius"));
 
                            Chunk c = world.getChunkAt(new Location(world, rand_x, y, rand_z));
                            world.loadChunk(c);
 
                            if (c.isLoaded()) {
                                player.teleport(loc);
                            }
 
                        }
                    }
                }
            } else if (y >= 254) {
                y = world.getHighestBlockYAt(rand_x, rand_z) + 2;
                rand_x = generator.nextInt(1000);
                rand_z = generator.nextInt(1000);
            }
        }
    }

 

Chrusty45 There are several things wrong with your logic, most importantly, it will only run once because the boolean 'safe' is only true once. Also, you seem to check if a location is "safe", but then you loop through every player, create a new random set of coordinates, load that chunk, and then teleport them to the original coordinates, completely disregarding the new random coordinates. Also, there is some odd manipulation of the y value that doesn't seem to make any sense but to teleport the play high above the ground.

 

masons123456 Ok, I've rewritten the code to this. It works fine, but sometimes it won't teleport at all and time out the server or it will teleport players into the ground (Sometimes). Most of the time it works just fine, I just cant have the time outs and suffocating in the ground. I can't seem to figure it out.

Code:java

public static void teleport() {
        Random random = new Random();
        for(String playerName : Game.getPlayers()) {
            Player player = Bukkit.getServer().getPlayer(playerName);
            World world = Bukkit.getServer().getWorld(Main.uhcConfig.getString("World"));
            int x = random.nextInt(Main.uhcConfig.getInt("World Border Radius"));
            int z = random.nextInt(Main.uhcConfig.getInt("World Border Radius"));
            int y = world.getHighestBlockYAt(x, z);
 
            boolean safe = false;
 
            Location loc = new Location(world, x, y, z);
 
            Block block = loc.getBlock();
            Material blockType = block.getRelative(BlockFace.DOWN).getType();
 
            while(!safe) {
                if(blockType.isSolid()) {
                    safe = true;
                    Chunk c = world.getChunkAt(loc);
                    world.loadChunk(c);
 
                    if(!c.isLoaded()) {
                        c.load();
                    } else {
                        player.teleport(loc);
                    }
 
                }
            }
        }
    }

 

Chrusty45 Well why would you want to teleport them into a solid block? IMHO, the whole 'while' loops isn't really necessary. Just add like 2 to the highest block at the location, load the chunk, and then teleport. Also, with the current setup, it only teleports them if the chunk is loaded. Replace:

Code:

if (!c.isLoaded()) {
    c.load();
} else {
    player.teleport(loc);
}

With:

Code:

if (!c.isLoaded()) {
    c.load();
}
player.teleport(loc);