Solved Making A Vote System - For Mini Games

Hello Guys,

I am trying to setup a custom coded mini games plugin for my server and I have just got to the part where I am making the voting part. I am getting the vote menu to pop up. However I am trying to make it so that when a user selects a vote icon from the inventory it is added to the hash map. After 30 seconds which ever hash map has the most amount of people voted for then gets played. How do I do that? Here is my code.

Code:java

package general;
 
import java.util.ArrayList;
import java.util.HashMap;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
 
 
public class voteSystem implements Listener {
 
    static HashMap<String, Integer> PrisonBreak = new HashMap<String, Integer>();
    static HashMap<String, Integer> TestPlugin = new HashMap<String, Integer>();
    @EventHandler
    public static void VoteItemInteract(PlayerInteractEvent event){
            Player ply = event.getPlayer();
 
            if(event.getAction() == Action.RIGHT_CLICK_AIR && event.getPlayer().getItemInHand().getType() == globalData.VoteIcon.getType() || event.getAction() == Action.RIGHT_CLICK_BLOCK && event.getPlayer().getItemInHand().getType() == globalData.VoteIcon.getType() ){
 
                Inventory inv = Bukkit.createInventory(ply, 27,ChatColor.GOLD+"["+ChatColor.GOLD+"Vote"+ChatColor.GOLD+"]"+ChatColor.DARK_GRAY+" Gamemode");
                inv.clear();
                //inv.addItem(globalData.VoteIcon);
                inv.addItem(globalData.PrisonBreakIcon);
 
                ply.openInventory(inv);
                event.setCancelled(true);
                ply.closeInventory();
            }
            if(event.getAction() == Action.RIGHT_CLICK_AIR && event.getPlayer().getItemInHand().getType() == globalData.PrisonBreakIcon.getType() || event.getAction() == Action.RIGHT_CLICK_BLOCK && event.getPlayer().getItemInHand().getType() == globalData.PrisonBreakIcon.getType() ){
                PrisonBreak.put(event.getPlayer().getName(), 1);
                event.getPlayer().sendMessage("You have voted for Prison Break :D");
            }
            if(event.getAction() == Action.RIGHT_CLICK_AIR && event.getPlayer().getItemInHand().getType() == globalData.testicon.getType() || event.getAction() == Action.RIGHT_CLICK_BLOCK && event.getPlayer().getItemInHand().getType() == globalData.testicon.getType() ){
                TestPlugin.put(event.getPlayer().getName(), 1);
                event.getPlayer().sendMessage("You have voted for some stupid test plugin :(");
            }
    }
    public static int PrisonBreakCounter(HashMap<String, ArrayList<Integer>> PrisonBreak){
        int PrisonBreakResults = 0;
        for(ArrayList<Integer> list: PrisonBreak.values()){
            PrisonBreakResults += list.size();
        }
        return PrisonBreakResults;
    }
    public static int TestPluginCounter(HashMap<String, ArrayList<Integer>> TestPlugin){
        int TestPluginResults = 0;
        for(ArrayList<Integer> list: TestPlugin.values()){
            TestPluginResults += list.size();
        }
        return TestPluginResults;
    }
 
    public class MapChosen{
        public String Results;{
            if(voteSystem.PrisonBreakCounter(null) <= voteSystem.TestPluginCounter(null)){
                String mapChosen = "'prisonbreak'";
            }
            else{
                String mapChosen = "'testplugin'";
            }
        }
 
    }
}

Thanks, Thomas

 

This is not how you help somebody, at all.

Learn to be constructive in your responses. Offering somebody a "wow you suck at coding here's a very general idea that would pull up things extremely advanced and probably off topic that show a general idea at what i'm talking about from a website not even related to what he's doing" won't help somebody that's new and struggling.

Yeesch.

 

He was implying for OP to learn java.

 

I get that feeling so much xD

 

The first issue I see here is that you're not showing us what some of these instances are of what I assume are supposed to be extended ItemStack objects. Honestly I think you should put your trust into using commands such as /vote as it creates far less issues and way easier to manage.

 

Try looking up some bukkit tutorial(s). I think you should learn basic java before you do something more complex like this

Plus I think if this is really one of your first plugins then I highly suggest a command based voter, or even a pre-made plugin.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

nate_alex

How would you make a command based voter?

 

thomasjcf21

I don't understand why you are storing the votes in a HashMap with the player name and an integer. You should be storing the name of what you are voting for and the number of votes. Then to get the highest votes you loop through the values and compare them. However before doing this you should probably learn some Java.

 

Ad237

Hi,

I am not that nooby at Java.

However please can you give an example?

Thanks, Thomas

 

thomasjcf21 I have already told you what you need to change. Also not to sound rude but you are "nooby at java".

 

Ad237

OK, I am kinda nooby but this isn't the first plugin I have coded. I was just looking for an example of how you would do it. I would like to expand my Java Knowledge.

Thanks, Thomas

 

thomasjcf21 I'm not writing the full code out but this is what I would do.

Code:

public HashMap<String, Integer> votes = new HashMap<String, Integer>();

Add the maps:

Code:

votes.put("Map1", 0);
votes.put("Map2", 0);

When a player votes:

Code:

String map = "Map1"; //The map they are voting for.
votes.put(map, votes.get(map) + 1);

 

Ad237

Thanks, So Much that was what i was asking for

Ad237

Sorry to have to bother you again,

Except when I do this, it always says 1. Even if two users select it. Why?

Code:java

if(event.getAction() == Action.RIGHT_CLICK_AIR && event.getPlayer().getItemInHand().getType() == globalData.VoteIcon.getType() || event.getAction() == Action.RIGHT_CLICK_BLOCK && event.getPlayer().getItemInHand().getType() == globalData.VoteIcon.getType() ){
                String map = "prisonbreak";
                votes.put(map, votes.get(map) + 1);
                event.getPlayer().sendMessage("You have voted for Prison Break :D");
                event.getPlayer().sendMessage(votes.get(map) + " have voted for this map!");
            }

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

thomasjcf21 Can I see the whole class please?

 

Ad237

Oh yhea sorry :/

Code:java

package general;
 
import java.util.ArrayList;
import java.util.HashMap;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.inventory.Inventory;
//import org.bukkit.inventory.ItemStack;
//import org.bukkit.inventory.meta.ItemMeta;
 
 
public class voteSystem implements Listener {
 
public static HashMap<String, Integer> votes = new HashMap<String, Integer>();
@EventHandler
public static void VoteItemInteract(PlayerInteractEvent event){
Player ply = event.getPlayer();
votes.put("prisonbreak", 0);
votes.put("testplugin", 0);
if(event.getAction() == Action.RIGHT_CLICK_AIR && event.getPlayer().getItemInHand().getType() == globalData.VoteIcon.getType() || event.getAction() == Action.RIGHT_CLICK_BLOCK && event.getPlayer().getItemInHand().getType() == globalData.VoteIcon.getType() ){
 
Inventory inv = Bukkit.createInventory(ply, 27,ChatColor.GOLD+"["+ChatColor.GOLD+"Vote"+ChatColor.GOLD+"]"+ChatColor.DARK_GRAY+" Gamemode");
inv.clear();
//inv.addItem(globalData.VoteIcon);
inv.addItem(globalData.PrisonBreakIcon);
inv.addItem(globalData.testicon);
 
ply.openInventory(inv);
event.setCancelled(true);
}
if(event.getAction() == Action.RIGHT_CLICK_AIR && event.getPlayer().getItemInHand().getType() == globalData.VoteIcon.getType() || event.getAction() == Action.RIGHT_CLICK_BLOCK && event.getPlayer().getItemInHand().getType() == globalData.VoteIcon.getType() ){
//String map = "prisonbreak";
votes.put("prisonbreak", votes.get("prisonbreak")+1);
event.getPlayer().sendMessage("You have voted for Prison Break :D");
event.getPlayer().sendMessage(votes.get("prisonbreak") + " have voted for this map!");
}
if(event.getAction() == Action.RIGHT_CLICK_AIR && event.getPlayer().getItemInHand().getType() == globalData.testicon.getType() || event.getAction() == Action.RIGHT_CLICK_BLOCK && event.getPlayer().getItemInHand().getType() == globalData.testicon.getType() ){
String map = "testplugin";
votes.put(map, votes.get(map) + 1);
event.getPlayer().sendMessage("You have voted for some stupid test plugin :(");
event.getPlayer().sendMessage(votes.get(map) + " have voted for this map!");
}
}
}

 

So you were asking about a command based one. What you could do is when the player executes /vote it shows them a list of the maps to vote for. Then it says a number next to the map so they would do /vote <number>. Im not exactly sure of how you would do this, but that is sorta the basics of this method

 

Ad237

Yhea I would like to make a GUI one first, Just checking to see if Ad237 has seen this?

Thanks Thomas

Nevermind I have fixed it , It was resetting every time it was reopened xD

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Hi, can you release this plugin? It sounds awesome!