Arraylist Teams - Friendly Fire

Hello,

The plugin I've been working on has one bug I can't seem to get around. I can't turn off friendly fire. Teammates can hit each other with any item. If anyone could help, that would be great.

Code:java

package me.DivinanceMC.BorderClans;
 
import java.util.ArrayList;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.Server;
import org.bukkit.configuration.file.FileConfiguration;
import org.bukkit.configuration.file.FileConfigurationOptions;
import org.bukkit.entity.Arrow;
import org.bukkit.entity.Entity;
import org.bukkit.entity.Player;
import org.bukkit.entity.Projectile;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.EntityDamageByEntityEvent;
import org.bukkit.event.inventory.InventoryClickEvent;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.PlayerInventory;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
 
public class BorderClans extends JavaPlugin
  implements Listener
{
  ArrayList<Player> red = new ArrayList(0);
  ArrayList<Player> blue = new ArrayList(0);
 
  public void onEnable()
  {
    getServer().getPluginManager().registerEvents(this, this);
    getConfig().options().copyDefaults(true);
  }
 
  @EventHandler
  public void onPlayerjoin(PlayerJoinEvent event)
  {
    Player player = event.getPlayer();
 
    if (player.hasPlayedBefore()) {
      String redteam = "red";
      String blueteam = "blue";
      String team = getConfig().getString(player.getName() + ".team");
 
      if (team == null) {
        if (this.red.size() == this.blue.size())
        {
          String redconfig = "red";
          getConfig().set(player.getName() + ".team", redconfig);
          saveConfig();
 
          this.red.add(player);
          player.sendMessage(ChatColor.GRAY + "You joined the " + ChatColor.DARK_RED + "Red Team");
          String redprefix = "§7[§4Red§7][§c-§7]§4 ";
          player.setDisplayName(redprefix + player.getName() + "§f");
          player.getInventory().setHelmet(new ItemStack(Material.WOOL, 1, (short)14));
        }
        else if (this.red.size() < this.blue.size()) {
          this.red.add(player);
          player.sendMessage(ChatColor.GRAY + (ChatColor.GRAY + "You joined the " + ChatColor.DARK_RED + "Red Team");
          String redprefix = "§7[§4Red§7][§c-§7]§4 ";
          player.setDisplayName(redprefix + player.getName() + "§f");
          player.getInventory().setHelmet(new ItemStack(Material.WOOL, 1, (short)14));
 
          String redconfig = "red";
          getConfig().set(player.getName() + ".team", redconfig);
          saveConfig();
        }
        else if (this.blue.size() < this.red.size()) {
          this.blue.add(player);
          player.sendMessage(ChatColor.GRAY + "You joined the " + ChatColor.BLUE + "Blue Team");
          String blueprefix = "§7[§9Blue§7][§a+§7]§9 ";
          player.setDisplayName(blueprefix + player.getName() + "§f");
          player.getInventory().setHelmet(new ItemStack(Material.WOOL, 1, (short)11));
 
          String blueconfig = "blue";
          getConfig().set(player.getName() + ".team", blueconfig);
          saveConfig();
        }
      }
      else if (team.equalsIgnoreCase(redteam))
      {
        this.red.add(player);
        player.sendMessage(ChatColor.GRAY + "You joined the " + ChatColor.DARK_RED + "Red Team");
        String redprefix = "§7[§4Red§7][§c-§7]§4 ";
        player.setDisplayName(redprefix + player.getName() + "§f");
        player.getInventory().setHelmet(new ItemStack(Material.WOOL, 1, (short)14));
      }
      else if (team.equals(blueteam))
      {
        this.blue.add(player);
        player.sendMessage(ChatColor.GRAY + "You joined the " + ChatColor.BLUE + "Blue Team");
        String blueprefix = "§7[§9Blue§7][§a+§7]§9 ";
        player.setDisplayName(blueprefix + player.getName() + "§f");
        player.getInventory().setHelmet(new ItemStack(Material.WOOL, 1, (short)11));
      }
      else if (team.equals(null)) {
        if (this.red.size() == this.blue.size())
        {
          String redconfig = "red";
          getConfig().set(player.getName() + ".team", redconfig);
          saveConfig();
 
          this.red.add(player);
          player.sendMessage(ChatColor.GRAY + "You joined the " + ChatColor.DARK_RED + "Red Team");
          String redprefix = "§7[§4Red§7][§c-§7]§4 ";
          player.setDisplayName(redprefix + player.getName() + "§f");
          player.getInventory().setHelmet(new ItemStack(Material.WOOL, 1, (short)14));
        }
        else if (this.red.size() < this.blue.size()) {
          this.red.add(player);
          player.sendMessage(ChatColor.GRAY + "You joined the " + ChatColor.DARK_RED + "Red Team");
          String redprefix = "§7[§4Red§7][§c-§7]§4 ";
          player.setDisplayName(redprefix + player.getName() + "§f");
          player.getInventory().setHelmet(new ItemStack(Material.WOOL, 1, (short)14));
 
          String redconfig = "red";
          getConfig().set(player.getName() + ".team", redconfig);
          saveConfig();
        }
        else if (this.blue.size() < this.red.size()) {
          this.blue.add(player);
          player.sendMessage(ChatColor.GRAY + "You joined the " + ChatColor.BLUE + "Blue Team");
          String blueprefix = "§7[§9Blue§7][§a+§7]§9 ";
          player.setDisplayName(blueprefix + player.getName() + "§f");
          player.getInventory().setHelmet(new ItemStack(Material.WOOL, 1, (short)11));
 
          String blueconfig = "blue";
          getConfig().set(player.getName() + ".team", blueconfig);
          saveConfig();
        }
      }
    }
    else if (!player.hasPlayedBefore()) {
      if (this.red.size() == this.blue.size())
      {
        String redconfig = "red";
        getConfig().set(player.getName() + ".team", redconfig);
        saveConfig();
 
        this.red.add(player);
        player.sendMessage(ChatColor.GRAY + "You joined the " + ChatColor.DARK_RED + "Red Team");
        String redprefix = "§7[§4Red§7][§c-§7]§4 ";
        player.setDisplayName(redprefix + player.getName() + "§f");
        player.getInventory().setHelmet(new ItemStack(Material.WOOL, 1, (short)14));
      }
      else if (this.red.size() < this.blue.size()) {
        this.red.add(player);
        player.sendMessage(ChatColor.GRAY + "You joined the " + ChatColor.DARK_RED + "Red Team");
        String redprefix = "§7[§4Red§7][§c-§7]§4 ";
        player.setDisplayName(redprefix + player.getName() + "§f");
        player.getInventory().setHelmet(new ItemStack(Material.WOOL, 1, (short)14));
 
        String redconfig = "red";
        getConfig().set(player.getName() + ".team", redconfig);
        saveConfig();
      }
      else if (this.blue.size() < this.red.size()) {
        this.blue.add(player);
        player.sendMessage(ChatColor.GRAY + "You joined the " + ChatColor.BLUE + "Blue Team");
        String blueprefix = "§7[§9Blue§7][§a+§7]§9 ";
        player.setDisplayName(blueprefix + player.getName() + "§f");
        player.getInventory().setHelmet(new ItemStack(Material.WOOL, 1, (short)11));
 
        String blueconfig = "blue";
        getConfig().set(player.getName() + ".team", blueconfig);
        saveConfig();
      }
    }
  }
 
  @EventHandler
  public void onHelmetTouch(InventoryClickEvent event)
  {
    if (event.getSlot() == 39)
      event.setCancelled(true);
  }
 
  @EventHandler
  public void onEntityDamageByEntity(EntityDamageByEntityEvent event)
  {
    if (((event.getEntity() instanceof Player)) && ((event.getDamager() instanceof Player))) {
      Player player = (Player)event.getEntity();
      Player damager = (Player)event.getDamager();
 
      if ((this.red.contains(player.getName())) && (this.red.contains(damager.getName())))
        event.setCancelled(true);
      else if ((this.blue.contains(player.getName())) && (this.blue.contains(damager.getName())))
        event.setCancelled(true);
    }
    else if (((event.getEntity() instanceof Arrow)) && ((event.getDamager() instanceof Player))) {
      Entity arrow = event.getEntity();
      if ((((Projectile)arrow).getShooter() instanceof Player)) {
        Player player = (Player)arrow;
        Player damager = (Player)event.getDamager();
        if ((this.red.contains(player.getName())) && (this.red.contains(damager.getName()))) {
          event.setCancelled(true);
        }
        else if ((this.blue.contains(player
          .getName())) && (this.blue.contains(damager.getName())))
          event.setCancelled(true);
      }
    }
  }
}

 

I've seen this before somewhere.

 

On damage, you are seeing if the player's name is in the array. Change this so from player.getName to player

 

console output?

 

You're adding the player entity to the ArrayList and then trying to see if the player's name is in the ArrayList in the EntityDamageByEntityEvent. Try adding the player to the ArrayList with red.add(player.getName());