Solved Shoot a fireball with a stick if inventory contains coal

Hello developers,
I'm quite new to developing in java and bukkit, but I've created some easy plugins before.

As my title says I want to shoot a fireball with a stick if my inventory contains coal. So I've written this code:

Code:java

 
    @SuppressWarnings("deprecation")
    @EventHandler
    public void onInteraction(PlayerInteractEvent event){
        ItemStack i = event.getItem();
        Player player = event.getPlayer();
        PlayerInventory inventory = player.getInventory();
        ItemStack coal = new ItemStack(Material.COAL, 1);
 
        if (event.getAction() == Action.RIGHT_CLICK_AIR){
            if (i.getType().equals(Material.STICK)){
                player.getLocation().getDirection().normalize().multiply(1);
                player.launchProjectile(SmallFireball.class);
                if (inventory.contains(coal)){
                    inventory.removeItem(coal);
                    player.updateInventory();
                }
            }
 

But this won't work. When A player right clicks with a stick in the air a fireball wil be launched, but nothing else.

Can somebody explain to me what I'm doing wrong?

 

Check for the coal before you launch the fireball so it launches only if they have coal (put the launching code inside the if(inventory.contains(coal))).

 

Can you please show me an example? Thx!

 

Code:java

if(i.getType().equals(Material.STICK)){
    if (inventory.contains(coal)){
        inventory.removeItem(coal);
        player.updateInventory();
        player.getLocation().getDirection().normalize().multiply(1);
        player.launchProjectile(SmallFireball.class);
    }
}

 

Thank you! This is exactly what I wanted.

But now I've found another bug in my code: If you have a stack of coal and you're trying to fire a fireball, you cant fire them. The only way to fire those fireballs is to separate one of the coal items.

Do you know the solution for this?

 

Can you do if(inventory.contains(Material.COAL))

 

tommycake50
This works, but if a player has Charcoal in his inventory he will be able to shoot unlimited..

 

Do if inventory.containsAtLeast(Material.COAL, 1) rather than using contains().

I would add a check to make sure it's not charcoal.

 

kennethbgoodin That worked! But I've done it with

Code:java

if (inventory.containsAtLeast(coal, 1)){
 

Because Material.Coal will display an underline.

Thank you in advance! This solved my problem!

After creating a custom crafting recipe and a custom item(with lore etc.) I can shoot the fireballs and it all worked fine. But when I click with a stick in the air my console gives me an error: Could not pass playerInteract event to ...

here is my src code:

Code:java

@SuppressWarnings("deprecation")
@EventHandler
public void onInteractionFlameThrower(PlayerInteractEvent event){
Player player = event.getPlayer();
PlayerInventory inventory = player.getInventory();
Location loc = player.getLocation();
ItemStack coal = new ItemStack(Material.COAL, 1);
 
if (event.getAction() == Action.RIGHT_CLICK_AIR){
boolean FlameThrower = player.getItemInHand().getItemMeta().getDisplayName().equals("FlameThrower");
if(FlameThrower){
if (inventory.containsAtLeast(coal, 1)){
inventory.removeItem(coal);
player.updateInventory();
player.getLocation().getDirection().normalize().multiply(1);
player.launchProjectile(SmallFireball.class);
player.launchProjectile(SmallFireball.class);
player.launchProjectile(SmallFireball.class);
player.launchProjectile(SmallFireball.class);
player.launchProjectile(SmallFireball.class);
player.playSound(loc, Sound.WITHER_SHOOT, 1, 1);
} else {
player.sendMessage(ChatColor.BLUE + "[Pluginname] " + ChatColor.WHITE + "Je hebt steenkool nodig om te kunnen schieten!");
}
}
}
}
@EventHandler(priority = EventPriority.HIGH)
public void onInteractionCompass(PlayerInteractEvent event){
ItemStack i = event.getItem();
Player player = event.getPlayer();
 
if(event.getAction() == Action.RIGHT_CLICK_AIR){
if (i.getType().equals(Material.COMPASS)){
player.sendMessage(ChatColor.BLUE + "[pluginName] " + ChatColor.WHITE + "Om de locatie van een speler te vinden gebruik: /search (spelernaam)");
}
}
}

Does somebody know how to fix this? My console is giving me errors and I don't know the solution.


I'm Dutch and because of that the .sendMessages are also written in Dutch


EDIT: Also if I'm Clicking with my compass the console is giving me the same error..

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

In your payer.getItenInHand() you need to make it so it's like, p.getItemInHand().equals(new ItemStack(Material.Stick, 1)

 

What do you mean? Do i have to put it after the boolean FlameThrower =...? If I do that, I think I don't need my custom item to throw those fireballs..? As I've said before, java isn't my best language. Sorry for that

 

Paste the full stacktrace. Just knowing that it can't pass the event doesn't help.

But it sounds like there's a null pointer, and you need to first make sure the item in the player's hand has a name, after checking if the action is RIGHT_CLICK_AIR; if you check the name before checking if it has a name or not, there's a likely chance it won't have a name, and then you'll get a null pointer exception.

Code:

if (event.getAction() == Action.RIGHT_CLICK_AIR){
     if (player.getItemInHand().getItemMeta().hasDisplayName() {
          //the rest of your code
     }
}

 

I've changed my code, now it checks if the item has a name before the other code is executed. But if I rename a stick, it will execute my code. Is there a way to do something like: player.getItemInhand().getItemMeta(//The item lore here?//).hasDisplayName()

If I can check for an item lore my problem is solved.

EDIT: Solved! If I check for a lore on the line under the if statement for display name using: .hasLore it'll work! Thx everyone!