Solved Spamming messages?

I get no errors, but I'm not sure if I should be putting doubles in a Random.

Because when I kill an entity it spams this:

0.1 Xp Recieved
0.2 Xp Recieved
0.5 Xp Recieved


It should be only playing 1 message..

Code:java

 @EventHandler
        public void onKill(EntityDeathEvent e){
            if(e.getEntity() instanceof Monster){
                    Monster m = (Monster) e.getEntity();
                    if(m.getKiller() instanceof Player){
 
                            Player p = m.getKiller();
                            Random random = new Random();
                            int randomNum = random.nextInt(100) + 1;
                            if (randomNum <= 30) {
                                giveXp(p, 0.1D);
                            }
                            if (randomNum <= 20) {
                                giveXp(p, 0.2D);
                            }
                  if (randomNum <= 90) {
                        giveXp(p, 0.5D);
                            }
                  if (randomNum <= 60) {
                        giveXp(p, 0.1D);
                  }
                  if (randomNum <= 10) {
                        giveXp(p, 0.6D);
                  }
 
                    }
            }
            }
 
    public void giveXp(Player p, double d){
        ExperienceManager expMan = new ExperienceManager(p);
        expMan.changeExp(0 + d);
            p.sendMessage("§3" + d + " Xp recieved!");
 
        }
}

 

shohouku Hypothetical situation:

"An entity died!"
"Was it a Monster?"
"Yes."
"Okay, was the killer a Player?"
"Yes."
"Okay, generate a random number between 1 and 100 inclusively."
"Done. Number is 1"
"Okay, is 1 less than or equal to 30?"
"Yes"
"Then give the player 0.1 exp. Is 1 less than or equal to 20?"
"Yes"
"Then give the player 0.2 exp. Is 1 less than or equal to 90?"
Okay, I hope you see the problem by now Solution: Stop checking as soon as you hit one of them

 

Okay fixed my solution, I added else statements to each of them and now it works

 

Return.
You just could do return true;

 

MordorKing78 In a void method? Let me know how that works out.

 

AdamQpzm You can return in a void method.. just not true I'm sure he understood what MordorKing78 meant.

 

DrEinsteinium I know you can, but the exact words were to use return true

And maybe he did, maybe he didn't. But in either case, he'd solved the issue before MordorKing78 posted

 

AdamQpzm DrEinsteinium Yes sorry just return; Me stupid :3