Remove 1 item on right click

Ok so I am trying to make my own Gun plugin for my server and and get snowballs to act like ammo. So when I right click with lets say Iron Horse Armor it will shoot the snowball but then it will remove all of the snowballs in my inventory, not just one. So when they right click if they use the iron horse armor ans have a snowball in their inventory it will shoot but after that i want it to remove just 1 snowball not all of them.

Here is my code (I am using GunsAPI btw. http://dev.bukkit.org/bukkit-plugins/gunsapi/)

Code:java

    @SuppressWarnings("deprecation")
    @EventHandler
    public void shoot(PlayerInteractEvent event){
        Player p = event.getPlayer();
        if(event.getAction().equals(Action.RIGHT_CLICK_AIR)){
            if(event.getPlayer().getItemInHand()!= null){
                if(event.getPlayer().getItemInHand().getType().equals(Material.IRON_BARDING)){
                    GunsAPI gun = (GunsAPI) Bukkit.getPluginManager().getPlugin("GunsAPI");
                    if(p.hasPermission("gun.use")){
                        if(p.getInventory().contains(Material.SNOW_BALL)){
                    gun.shootGun(2, event.getPlayer(), event.getPlayer().getLocation().getDirection().multiply(3), BulletType.SNOWBALL, false);
                    p.getWorld().playSound(p.getLocation(), Sound.ITEM_PICKUP,1, 0);
                    p.getInventory().remove(Material.SNOW_BALL);
                    p.getInventory().remove(1);
                    p.updateInventory();
                }
            }
        }       
    }
}
}

 

int x = snowball.getAmount
remove snowball
add a snowball itemstack with the amount x-1.

 

TehVoyager Ok so I have this now

Code:java

                    p.getWorld().playSound(p.getLocation(), Sound.ITEM_PICKUP,1, 0);
                    ItemStack snowball = new ItemStack(Material.SNOW_BALL,64);
                    int x = snowball.getAmount();
                    p.getInventory().remove(Material.SNOW_BALL);
                    p.getInventory().addItem(x-1);
                    p.updateInventory();

But I have an error on addItem. It says 'The method addItem(ItemStack...) in the type Inventory is not applicable for the arguments (int)'

 

TheAJ471
Do p.getInventory().addItem(new ItemStack(Material.SNOW_BALL), x-1)

And Also Don't define snowball as a stack of 64, Get The Amount of Snowballs in their inventory

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

TehVoyager So now i have this. But it doesnt seem to work.

Code:java

                    ItemStack snowball = new ItemStack(Material.SNOW_BALL);
                    int x = snowball.getAmount();
                    p.getInventory().remove(Material.SNOW_BALL);
                    ItemStack snowball2 = new ItemStack(Material.SNOW_BALL,x-1);
                    p.getInventory().addItem(snowball2);
                    p.updateInventory();

 

TheAJ471
The problem is you're getting the amount of a new snowball object that you created, Use a for loop to loop through every item in their nventory and if its a snowball make x the amount of snowballs and break the loop.

 

TehVoyager Could i have an example on how to do this? Or is there a page i could try to look at.

 

TheAJ471

Code:java

            int x = 0;
            for(ItemStack i : p.getInventory().getContents()){
                if(i.getType() == Material.SNOW_BALL){
                    x = i.getAmount();
                    break;
                }
            }

 

TehVoyager Would I use this to replace my code or would I add this in?

 

replace your first 2 lines shown with this, the ones defining x and snowball. TheAJ471

 

TehVoyager So now it looks like this. Nothing happens when i shoot. If i have for example 5 snowballs i stil have all 5 snowballs after shooting.

Code:java

                    int x = 0;
                    for(ItemStack i : p.getInventory().getContents()){
                        if(i.getType() == Material.SNOW_BALL){
                            x = i.getAmount();
                            break;
                        }
                    }
                    p.getInventory().remove(Material.SNOW_BALL);
                    ItemStack snowball2 = new ItemStack(Material.SNOW_BALL,x-1);
                    p.getInventory().addItem(snowball2);
                    p.updateInventory();

Also i get this error in my server log.

 

Is that all the code in your interact event?

 

TehVoyager This is now all of it in the event.

Code:java

    @SuppressWarnings("deprecation")
    @EventHandler
    public void shoot(PlayerInteractEvent event){
        Player p = event.getPlayer();
        if(event.getAction().equals(Action.RIGHT_CLICK_AIR)){
            if(event.getPlayer().getItemInHand()!= null){
                if(event.getPlayer().getItemInHand().getType().equals(Material.IRON_BARDING)){
                    GunsAPI gun = (GunsAPI) Bukkit.getPluginManager().getPlugin("GunsAPI");
                    if(p.hasPermission("gun.use")){
                        if(p.getInventory().contains(Material.SNOW_BALL)){
                    gun.shootGun(2, event.getPlayer(), event.getPlayer().getLocation().getDirection().multiply(3), BulletType.SNOWBALL, false);
                    p.getWorld().playSound(p.getLocation(), Sound.ITEM_PICKUP,1, 0);
                    int x = 0;
                    for(ItemStack i : p.getInventory().getContents()){
                        if(i.getType() == Material.SNOW_BALL){
                            x = i.getAmount();
                            break;
                        }
                    }
                    p.getInventory().remove(Material.SNOW_BALL);
                    ItemStack snowball2 = new ItemStack(Material.SNOW_BALL,x-1);
                    p.getInventory().addItem(snowball2);
                    p.updateInventory();
                }
            }
        }       
    }
        }
}

 

remove updateinventory

 

TehVoyager I get this error in the server log.

 

its at line 39 of your gunlistener class

 

TehVoyager this is line 39.

Code:java

if(i.getType() == Material.SNOW_BALL){

 

is getType() depricated? Add Supress Warnings

 

TehVoyager getType isnt depriciated.