PlayerInteractionEvent

Hello, I'm making a plugin which when the user right clicks a certain block something will happen. I used the following code but it did nothing. Yes, I did register the events and what not (All my other events work fine). :

Code:java

@EventHandler
public void onPlayerInteract(PlayerInteractEvent event) {
if(event.getAction() == Action.RIGHT_CLICK_BLOCK) {
if(event.getClickedBlock().getType() == Material.STONE) {
if(event.getPlayer().getItemInHand() == null) {
event.getPlayer().sendMessage("You right clicked stone!");
} else if(event.getMaterial() == Material.POTION && event.getPlayer().getItemInHand().getDurability() == 0) {
event.getPlayer().sendMessage("You right clicked stone with a glass bottle!");
}
}
}
}

 

I believe the getItemInHand would return ItemStack AIR
but you really need to debug your code before posting it here...

 

I would do:

Code:java

@EventHandler
public void onInteract (PlayerInteractEvent e) {
Player p = e.getPlayer();
if(e.getAction() == Action.RIGHT_CLICK_BLOCK) {
Block b = e.getClickedBlock().getType();
if(b == Material.STONE() {
if(p.getItemInHand() == null) {
p.sendMessage("You right clicked a stone block!");
}
else if(p.getItemInHand().getType() == Material.POTION && b == Material.STONE) {
p.sendMessage("You right clicked a stone block with a glass bottle!");
}
else if(!(p.getItemInHand().getType == Material.POTION)) {
p.sendMessage("Right clicked a stone block with " + p.getItemInHand().getType() + "!");
}
}

 

You don't get it.
You need to debug each line and check where it fails.
Also, those nested ifs are too restricted. Check them again

 

Vandrake
Why should he debug each line?!
This doesn't make sence!
Simply look in the console in which line the error is, get to the line, search the error, fix it, export, try again..!
It's better to make more 'ifs' because if it's not the cause only one thing in an 'if' isn't so (no && ..) you can do better 'else' ..!

 

What if there's no error?
What if there's just silence?
you do a command but nothing happens?No sound, no msg, nothing...
That's the point of debugging each line. I'm just trying to help, do whatever the hell you want. Listen to me or don't. None of my business

 

Everyone's got his method.. if you want tell us yours, okay.
If this method helps him, okay.
If not?
I would start a new projekt and do everything again.. check everything.. think if you made everything right - after each line.
If this doesn't work?
If nothing works?
Search help.
What is he doing here?
That.

 

Yes. Because thats easier than doing a System.out.println("1"); after each method... Jesus...

 

whut?

 

Do you know what Debug means?

 

A question,
1. Are you getting an error? if so on what error and on what line. If not then is the code just not working or is it doing something else?

 

Zero errors. I'm thinking Material.Stone is not the right 'getClickedBlock' type. Unsure.

I have debugged... null is meant to be air. So they can only right click with air.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Try this in your if statement

Code:java

event.getPlayer().getItemInHand() == null || event.getPlayer().getItemInHand() == Material.AIR

 

Doesn't work - getItemInHand() returns an ItemStack not Material.

 

Stackoverload
event.getPlayer().getItemInHand().getType() maybe?

Minesuchtiiii
Maybe it's not wise to bring up an old argument that has subsided, but I feel this should be addressed: Vandrake was just trying to help. It isn't fair to hammer on him that his idea of debugging is wrong just because you don't have a clue what he is talking about. Frankly, debugging is the logical decision that I would make: It's rather effortless in comparison to your approach, and doesn't obfuscate or break your code in any way.

 

How did I hammer him...

 

Minesuchtiiii Why should he create a whole new project over one bug?

 

Stackoverload Have you added debug to see if the event is even getting fired in the first place?

 

Stackoverload
Sorry. I was saying Minesuchtiiii was hammering Vandrake . You did nothing wrong in my opinion.

 

What's ur problem?
He should do whatever he wants..

 

No problem, I thought you were talking about him. Wasn't sure.

Yes, the problem is the specific block. Which in this case would be Material.STONE.

It seems that when I right click on a block with a Stone block in my hand it triggers.... I want it to detect when I right click with air (hand) and the block is stone... Odd.

You were somewhat right! Except you needed 'event.getPlayer().getItemInHand().getType() =='. Thanks for all the help guys it's greatly appreciated! Happy developing!

EDIT by Moderator: merged posts, please use the edit button instead of double posting.