Solved ItemStack not removing when amount is one?

Any ides/improvements for this, it works all they way down to 1 item in the stack:

Code:java

 
 
public boolean HasRequirements(Player playerToCheck)
    {
        int checksRequired = 0;
        Inventory playerInventory = playerToCheck.getInventory();
        List<ItemStack> requirements = GetAbilityRequirements();
 
        for (int i = 0; i < requirements.size(); i++)
        {
            if (playerInventory.containsAtLeast(requirements.get(i), 1))
            {
                checksRequired++;
            }
        }
 
        if (checksRequired == requirements.size())
        {
            ItemStack tempStack;
            int positionID;
            for (int i = 0; i < requirements.size(); i++)
            {
                positionID = playerInventory.first(requirements.get(i)
                        .getType());
                tempStack = playerInventory.getItem(positionID);
                tempStack.setAmount(tempStack.getAmount() - 1);
                currentClass.classOwner().updateInventory();
            }
            return true;
        }
        else
            return false;
    }
 
    @Override
    public List<ItemStack> GetAbilityRequirements()
    {
        List<ItemStack> tempRequirements = new ArrayList<ItemStack>();
        tempRequirements.add(new ItemStack(Material.WOOL));
        return tempRequirements;
    }

I also understand that updateInventory() is old, how should I replace this?

 

belven000 I don't think there is an alternative to updateInventory()
Try checking if the stack size is 1 then just set to air, or remove the item.

 

lol, it's so obvious now

Can't see a .remove, so would I set the type to MATERIAL.AIR?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Yeah just try that...

 

@ItsLeandro
This doesn't work?

Code:java

 if (tempStack.getAmount() != 1)
{
tempStack.setAmount(tempStack.getAmount() - amountToTake);
}
else
{
tempStack.setType(Material.AIR);
}

Bump, really need to fix this, players can cast all the abilities from my mod infinitely!!!

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

lets assume itemStack is a variable of an ItemStack that we want to remove an ammount stored in ammountToTake.

Code:

if(itemStack.getAmmount() > ammountToTake) {
itemStack.setAmmount(itemStack.getAmmount() - ammountToTake);
} else {
itemStack.setType(Material.AIR);
}

Works for me like a charm

 

I'll have another go but as far as I can see that's all I'm doing as well.

Sorry but still no luck, here is what I'm doing:

Code:java

 @SuppressWarnings("deprecation")
public boolean HasRequirements(Player playerToCheck, int amountToTake)
{
int checksRequired = 0;
Inventory playerInventory = playerToCheck.getInventory();
 
for (int i = 0; i < requirements.size(); i++)
{
if (playerInventory.containsAtLeast(requirements.get(i), 1))
{
checksRequired++;
}
}
 
if (checksRequired == requirements.size())
{
ItemStack tempStack;
int positionID;
for (int i = 0; i < requirements.size(); i++)
{
positionID = playerInventory.first(requirements.get(i)
.getType());
tempStack = playerInventory.getItem(positionID);
 
if (tempStack.getAmount() != 1)
{
tempStack.setAmount(tempStack.getAmount() - amountToTake);
}
else
{
tempStack.setType(Material.AIR);
}
 
currentClass.classOwner().updateInventory();
}
return true;
}
else
return false;
}

This is taken from here if you need to look at the whole class:
https://github.com/belven/Classes/blob/master/src/belven/classes/Abilities/Ability.java
From line 28.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.