Solved 20% more damage on hit.

Hello all java programmers!

I need some help to get started with this project. The plugin is about, if you had been given a permission, you are able to get 20% more damage in a hit (it could be with a sword, hand, axe, etc.)
I no how to do the permission part but i need help with finding the right eventhandlers.

Hope that someone can help

 

Asgernohns I would do something like this:

Code:

@EventHandler
public onEntityDamageByEntity(EntityDamageByEntityEvent e){
if(e.getDamager() instanceof Player){
e.setDamage(e.getDamage() + e.getDamage()/5);
}
}

 

I will try it out

I don't now why this isn't working.. the permission looks like it doesn't have any effect on the damage

Here is the code:

Code:java

import java.util.logging.Logger;
 
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.entity.EntityDamageByEntityEvent;
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.java.JavaPlugin;
 
public class CD extends JavaPlugin {
 
    public final Logger logger = Logger.getLogger("Minecraft");
    public static CD plugin;
 
    public void onEnable(){
        PluginDescriptionFile pdfFile = this.getDescription();
        this.logger.info(pdfFile.getName()+" v"+pdfFile.getVersion()+" Has been enabled!");
    }
 
    @EventHandler
    public void onEntityDamageByEntity(EntityDamageByEntityEvent e){
        if(e.getDamager() instanceof Player){
            Player p = (Player) e.getDamager();
            if(p.hasPermission("20on.on")){
                e.setDamage(e.getDamage() + e.getDamage()/5);
            }
        }
    }
    public boolean onCommand(CommandSender sender, Command cmd, String[] args){
        Player p = (Player) sender;
        if(cmd.getName().equalsIgnoreCase("20on")){
            p.sendMessage(ChatColor.AQUA+"20on v1.0");
        }
 
        return false;
    }
}
 

here is the plugin.yml:

PHP:

name: 20on
main: me.AsgerNohns.ConfigDamge.CD
description: A plugin that allows you to hit a bit harder
version: 1.0
author: AsgerNohns
commands:
  20on:
    description: Tells you the version of the plugin
permissions:
  20on.on:
    description: Allows you to hit a bit harder

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Your class must implement org.bukkit.event.Listener, and in your onEnable, you need to register it as an EventListener.

Code:java

 
getServer().getPluginManager().registerEvents(this, this);
 

 

Asgernohns You need to register your events.
onEnable:

Code:java

Bukkit.getPluginManager().registerEvents(this, this);

Edit: Ninja'd

 

aarrhhh..... YES! i forgot that thing xD thanks metalhedd and sgavster

But the permission still dont work if i add the permission or delete the permission nothing happens with the damage
can someone help

here is the code:

Code:java

import java.util.logging.Logger;
 
 
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.EntityDamageByEntityEvent;
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.java.JavaPlugin;
 
public class CD extends JavaPlugin implements Listener {
 
    public final Logger logger = Logger.getLogger("Minecraft");
    public static CD plugin;
 
    public void onEnable(){
        PluginDescriptionFile pdfFile = this.getDescription();
        this.logger.info(pdfFile.getName()+" v"+pdfFile.getVersion()+" Has been enabled!");
        getServer().getPluginManager().registerEvents(this, this);
    }
 
    @EventHandler
    public void onEntityDamageByEntity(EntityDamageByEntityEvent e){
        if(e.getDamager() instanceof Player){
            Player p = (Player) e.getDamager();
            if(p.hasPermission("20on.on")){
                e.setDamage(e.getDamage() + e.getDamage()/5);
            }else{
                e.setDamage(e.getDamage());
            }
        }
    }
 
}

And here is the plugin.yml:

PHP:

name: 20on
main: me.AsgerNohns.ConfigDamge.CD
description: A plugin that allows you to hit a bit harder
version: 1.0
author: AsgerNohns
commands:
  20on:
    description: Tells you the version of the plugin
permissions:
  20on.on:
    description: Allows you to hit a bit harder

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

You do use a permission plugin to actually add the permissions to a player ingame? :3

 

Just because there is no difference in the damage values doesn't mean the permission isn't working. it could be a problem with integer division as well (ie. getDamage()/5 rounds to 0) You should add some debug logging to veryify,.