What Am I doing wrong?

I'm trying to make a "/money send" command, but it is not working! D:
What am I doing wrong?

Code:java

 if(cmd.getName().equalsIgnoreCase("money") || cmd.getName().equalsIgnoreCase("balance")){
 
 
 
if (args.length >= 1) {
 
if (args[0] == "send"){
 
if (args[1] == ""){
 
player.sendMessage(ChatColor.RED + "Correct usage: " + ChatColor.WHITE + "/money send <player> <value>");
player.sendMessage(ChatColor.GRAY + "Please, put the name of the player and a value.");
 
} else {
Player target = Bukkit.getServer().getPlayer(args[1]);
if (args[2] == "" || args[2] == "0"){
 
player.sendMessage(ChatColor.RED + "Correct usage: " + ChatColor.WHITE + "/money send <player> <value>");
player.sendMessage(ChatColor.GRAY + "Put a value to send money to the player " + ChatColor.ITALIC + target.getName());
 
} else {
 
int emeralds_value = Integer.parseInt(args[2]);
 
if (getConfig().contains(target.getName())){
if (getConfig().getInt(player.getName()+".balance") >= emeralds_value){
 
//sender
plugin.getConfig().set(player.getName()+".balance", plugin.getConfig().getInt(player.getName()+".balance") - emeralds_value);
plugin.saveConfig();
 
//receiver
plugin.getConfig().set(target.getName()+".balance", plugin.getConfig().getInt(target.getName()+".balance") + emeralds_value);
plugin.saveConfig();
 
player.sendMessage(ChatColor.GREEN + "You sent " + ChatColor.BLUE + "" + ChatColor.ITALIC + emeralds_value + ChatColor.GREEN + "emerald to " + ChatColor.BLUE + target.getName());
player.playSound(player.getLocation(), Sound.ORB_PICKUP, 20.0F, 5.0F);
 
 
} else {
 
//balance -
player.sendMessage(ChatColor.RED + "Error: " + ChatColor.GRAY + "you don't have all these emeralds to send!");
 
}
 
}else{
//player does not exist
player.sendMessage(ChatColor.RED + "Error: " + ChatColor.GRAY + "player doesn't exist!");
 
}
 
}
 
}
 
} else {
 
//no know command, so, it shows the player's balance:
player.playEffect(player.getLocation(), Effect.CLICK2, 3);
player.playSound(player.getLocation(), Sound.ORB_PICKUP, 20.0F, 5.0F);
 
player.sendMessage(ChatColor.GREEN + "[Balance]: " + ChatColor.GRAY + "" + ChatColor.ITALIC + "" + getConfig().getInt(player.getName()+".balance") + " emeralds.");
 
 
}
 
}else{
 
//args 0 // show only money
player.playEffect(player.getLocation(), Effect.CLICK2, 3);
player.playSound(player.getLocation(), Sound.ORB_PICKUP, 20.0F, 5.0F);
 
player.sendMessage(ChatColor.GREEN + "[Balance]: " + ChatColor.GRAY + "" + ChatColor.ITALIC + "" + getConfig().getInt(player.getName()+".balance") + " emeralds.");
 
}
 
 
}

Please, help! D:

 

Are you getting any errors, what isn't working?

 

ArthurMaker
To make a money plugin command you should try using vault!!!

 

Compare strings using .equals() or .equalsIgnoreCase().

 

1Rogue

I'm not getting errors, I'm getting only the "[Balance]: x emeralds." message :/

thatdubstepgamer

I'm not going to use Vault, because it is not necessary to do this...

chasechocolate

I'm already doing this :/

 

ArthurMaker how come you use == in the code you had? Anyways, your code will be run if args.length is 0. It's all logical, I recommend reviewing your code.

 

No, you aren't.

Code:

args[0] == "send"

The '==' compares if two instances of an object are the same, or if two raw types have the equal value. Since a String is an object, comparing two different String instances will '==' will never return true since they are different instances. You have to use

Code:

args[0].equals("send")

instead, since the String's equals method compares the contents of the String.

 

thatdubstepgamer Vaut is for hooking into plugins, not making your own.

You can't make a money pugin "with vault"

 

Perhaps try this? I was looking into your code, tried to recode it myself to see where the error was. But I agree with Technius about the args portion.

Code:

Code:java

        if (cmd.getName().equalsIgnoreCase("money")) {
            if (args.length == 0) {
                p.playEffect(p.getLocation(), Effect.CLICK1, Type.SOUND);
                p.playSound(p.getLocation(), Sound.ORB_PICKUP, 20.0F, 5.0F);
                p.sendMessage(ChatColor.GREEN +"[Balance]: " + ChatColor.BLUE + "" + ChatColor.ITALIC + "" + this.getConfig().getInt(p.getName() + ".balance"));
                return true;
            }
            if (args.length == 1) {
                if (args[0].equalsIgnoreCase("send")) {
                    p.sendMessage(ChatColor.RED + "Error: " + ChatColor.GRAY + "Please Specify a Player.");
                    return true;
                }
                else {
                    p.sendMessage(ChatColor.RED + "Correct usage: " + ChatColor.WHITE + "/money send <player> <value>");
                    return true;
                }
            }
            if (args.length == 2) {
                Player target = Bukkit.getServer().getPlayer(args[1]);
                if (target == null) {
                    p.sendMessage(ChatColor.RED + "Error: " + ChatColor.GRAY + "Invalid player.");
                }
            }
            if (args.length == 3) {
                Player target = Bukkit.getServer().getPlayer(args[1]);
                int money = Integer.parseInt(args[2]);
                if (getConfig().getInt(p.getName() + ".balance") < money) {
                    p.sendMessage(ChatColor.RED + "You do not have enough emeralds to send!");
                    return true;
                }
                //Sender
                this.getConfig().set(p.getName() + ".balance", this.getConfig().getInt(p.getName() + ".balance") - money);
                this.saveConfig();
 
                //Receiver
                this.getConfig().set(target.getName() + ".balance", this.getConfig().getInt(target.getName() + ".balance") + money);
                this.saveConfig();
 
                p.sendMessage(ChatColor.GREEN + "You sent " + ChatColor.BLUE + "" + ChatColor.ITALIC + money + ChatColor.GREEN + "emerald(s) to " + ChatColor.BLUE + target.getName());
                p.playSound(p.getLocation(), Sound.ORB_PICKUP, 20.0F, 5.0F);
                return true;
            }
        }