Solved The stupidest bukkit question ever.

So how would I define a Player to p in this event handler?

Code:java

 
            @EventHandler
            public void onEntityDamage(EntityDamageByEntityEvent e) {
                if (e.getDamager() instanceof Fireball) {
                Fireball f = (Fireball) e.getDamager();
                        if (Shooter.contains(Bukkit.getName()));
                            if (f.getShooter() instanceof Player) {
                                    Player shooter = (Player) f.getShooter();
                                    if (shooter.getItemInHand().getType() == Material.IRON_SPADE) {
                                            e.setDamage(10.0);
                                            Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(this, new Runnable() {
                                            public void run() {
                                                Cooldown.remove(p);
                                            }
                                            }, 100);

 

like, you want the shooter to be P?

if that's the case, just do as below. dunno tho, i'm kinda new in this thing.
Player p = (Player) f.getShooter();

 

Yes I do want the shooter to be p.

That doesn't work though.

thanks for trying.

 

Joager
The shooter is allready the exact same thing.

 

DrTURTLE2
You have a semicolon after the if statement

 

Okay, did that. xTrollxDudex

 

DrTURTLE2

 

Okay, bit off topic. How would I make it have like a cooldown of 10 seconds before the player can shoot again? xTrollxDudex

 

DrTURTLE2
I this like a fireball shooting thing? Because when the fireball is fired, add the player to the list and start a scheduler to remove them after time.

 

Im not asking you too feed me code, but could you walk me through this? xTrollxDudex

 

DrTURTLE2
How is the fireball being shot? What are you doing so that the fire ball hits a player?

 

Code:java

 @EventHandler
public void onPlayerInteract(PlayerInteractEvent e) {
if (!(e.getAction() == Action.RIGHT_CLICK_AIR)) return;
 
if (!(e.getItem().getType() == Material.IRON_SPADE)) return;
 
Fireball f = e.getPlayer().launchProjectile(Fireball.class);
f.setIsIncendiary(false);
f.setYield(0);
}

xTrollxDudex

 

DrTURTLE2
Create an ArrayList, lets call it players. It will contain String. Then in the event, you would add the player name to the list. Copy paste 11-15 in the OP after that, replace "Cooldown" with "players" since the ArrayList name is players. This assumes that you have this in the main class

 

Are you trying to add the cool-down after the fireball hits a target or right after the player shoots it? In either scenario you would put their name and the time when they can shoot the fireball again in a HashMap and every time they try to shoot check if they are allowed to by doing this:

Code:java

public HashMap<String, Long> cooldown = new HashMap<String, Long>();

This next code is inserted into the part where you have the player shoot the fireball:

Code:java

//When the player tries to shoot a fireball
if (cooldown.containsKey(player.getName())) {
    long removeCooldown = cooldown.get(player.getName());
    if (removeCooldown >= System.currentTimeMillis()) {
        //Don't shoot fireball
        player.sendMessage("You have to wait a little to use this feature again!");
    } else {
        //Shoot the fireball
        cooldown.put(player.getName(), (System.currentTimeMillis() + (1000 * 10)));
    }
} else {
    //Shoot the fireball
    cooldown.put(player.getName(), (System.currentTimeMillis() + (1000 * 10)));
}

 

Okay how would I add the player name to the list when they launch the fireball?

Code:java

 @EventHandler
public void onEntityDamage(EntityDamageByEntityEvent e) {
if (e.getDamager() instanceof Fireball) {
Fireball f = (Fireball) e.getDamager();
if (Shooter.contains(Bukkit.getName())) {
if (f.getShooter() instanceof Player) {
Player shooter = (Player) f.getShooter();
Player player = (Player) player.getPlayer();
if (cooldown.containsKey(player.getName())) {
long removeCooldown = cooldown.get(player.getName());
if (removeCooldown >= System.currentTimeMillis()) {
player.sendMessage(ChatColor.RED + "You have to wait to do this again");
}
}else{
 
if (shooter.getItemInHand().getType() == Material.IRON_SPADE) {
e.setDamage(10.0);
cooldown.put(player.getName(), (System.currentTimeMillis() + (1000 * 10)));
 
}else{
if (shooter.getItemInHand().getType() == Material.IRON_SPADE) {
e.setDamage(10.0);
cooldown.put(player.getName(), (System.currentTimeMillis() + (1000 * 10)));
}
 

This is code, doesn't work
Quantix

Bump

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Make a BukkitRunnable or a scheduler. When the player shoots the fireball, add it to the List/Map/Whatever.
Kinda like this:

Code:java

 
//when the player shoots a fireball do this:
players.add(player.getName);
new BukkitRunnable(){
public void run(){
players.remove(player.getName);
}
}.runTaskLater(this, 200); //this, assuming your class extends JavaPlugin. 200 is 20x[seconds you want]. 200 ticks is 10 seconds.
 
//each time he fires, check if players.contains(player.getName);

I recommend you use a HashSet. When making it, simply do this:

Code:java

HashSet<String> players = new HashSet<String>();

It should work fine now.

 

Door Knob

Okay to get this to work I have to define the player, which still isn't working.

 

What do you mean?

Player player = (Player)e.getDamager();

 

This is far far away not even close to the most stupid question on the bukkit forums.

 

I fixed it, but how would I send the player a message if he tries to right click again while hes on cooldown saying "You cannot do this again?"

It bounced off. lol

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

When checking if player is in the players HashSet do this:

Code:java

if players.contains(player){
player.sendMessage("You have to wait 10 seconds!");
} else {
//shooting stuff 
}
 

 

Door Knob

Code:java

  @EventHandler
            public void onEntityDamage(EntityDamageByEntityEvent e) {
                if (e.getDamager() instanceof Fireball) {
                Fireball f = (Fireball) e.getDamager();
                        if (Shooter.contains(Bukkit.getName())) {
                            if (f.getShooter() instanceof Player) {
                                final Player player = (Player)e.getDamager();
                                    Player shooter = (Player) f.getShooter();
                                    if (shooter.getItemInHand().getType() == Material.IRON_SPADE) {
                                        e.setDamage(10.0);
 
                                        players.add(player.getName());
                                        new BukkitRunnable(){
                                        public void run(){
                                        players.remove(player.getName());
                                        }
                                        }.runTaskLater(this, 200);
                                    } else {
                                        if players.contains(player){
                                            player.sendMessage("You have to wait 10 seconds!");
 

This is my code, doesn't work.

Thanks for your continuous help.

 

Is that all of the code? Because it's missing lots of things. What's Shooter? Why do you use Bukkit.getName()? Also, the shooting code should be when the HashSet does NOT contain player.getName();. Also, what's not working? Can you please elaborate?

 

This is the shooting part.

Code:java

 @EventHandler
public void onPlayerInteract(PlayerInteractEvent e) {
if (!(e.getAction() == Action.RIGHT_CLICK_AIR)) return;
 
if (!(e.getItem().getType() == Material.IRON_SPADE)) return;
 
Fireball f = e.getPlayer().launchProjectile(Fireball.class);
f.setIsIncendiary(false);
f.setYield(0);
 
 
 
 

I used bukkit.getName because I couldn't figure out how to define the player at the start.
Edit: I changed to player.getName, thanks

 

Shouldn't the BukkitRunnable/putting the player in the HashSet be done in onPlayerInteract? Because right now all it does is doesn't let you use it for 10 seconds ONLY if you hit a player. You can shoot indefinelty in the air...

 

yes, thats what I want to fix, so you can only shoot every 10 seconds.

Im getting so many errors that I don't know how to fix.

 

Shouldn't be that hard. Just move the check that if he's in the HashSet to onPlayerInteract. and also add() the player there, and also put the bukkitrunnable there.

 

Solved over pm, thanks to Door Knob