Solved ArrayList not storing data

so part of my plugin includes a halt feature, type /halt <player> and it freezes the player in place, /haltlist shows frozen players and /unhalt to let them move again. I store the players names in an arraylist and when a player moves their name is checked against this list to see if they are halted. It was all working until I decided to clean up the code and make new classes, move pieces of code around the place etc, now the name dosent seem to be storing in the array correctly.

code (open) code (close)

Code:java

    private ArrayList<String> halted = new ArrayList<String>();
 
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
 
//On use of the /HaltList
        if(cmd.getName().equalsIgnoreCase("Haltlist")) {
            if(sender.hasPermission("ftbhelper.halt.list")){
                sender.sendMessage(ChatColor.BLUE+"-------------------------------------------------");
                sender.sendMessage(ChatColor.BLUE+"-----------"+ChatColor.AQUA+ "FTBHelper V" + plugin.getConfig().getString("version")+ " - By mike546378"+ChatColor.BLUE+"-----------");
                sender.sendMessage(ChatColor.BLUE+"-------------------------------------------------");
                sender.sendMessage(ChatColor.DARK_GREEN+"Halted Players:");
                //For Debugging
                if(halted.isEmpty()){
                    sender.sendMessage("Array is Empty...");
                }
 
                if(!halted.isEmpty()){
                    for(int x = 0; x <= halted.size() && x >= 0; x++){
                        sender.sendMessage(ChatColor.RED+halted.get(x));
                    }
                }
            }else{
                sender.sendMessage(ChatColor.DARK_RED+"You do not have sufficent permissions to perform this action.");
            }
            return true;
        }
//On use of the /halt <player>
        if(cmd.getName().equalsIgnoreCase("Halt")){
            if(sender.hasPermission("ftbhelper.halt.halt")){
                if(args.length == 1){
                    sender.sendMessage(ChatColor.RED + "Size: " + halted.size());
                    halted.add("CraftPlayer{name="+args[0]+"}");
                    sender.sendMessage(ChatColor.GREEN+args[0]+" has now been halted.");
                    sender.sendMessage(ChatColor.RED + "Size: " + halted.size());
                    sender.sendMessage(halted.get(halted.size() - 1));
                }else{
                    sender.sendMessage(ChatColor.BLUE+"-------------------------------------------------");
                    sender.sendMessage(ChatColor.BLUE+"-----------"+ChatColor.AQUA+ "FTBHelper "+plugin.getConfig().getString("version") + " - By mike546378"+ChatColor.BLUE+"-----------");
                    sender.sendMessage(ChatColor.BLUE+"-------------------------------------------------");
                    sender.sendMessage(ChatColor.GOLD+"Usage:"+ChatColor.WHITE+" /Halt <player>");
                }
            }else{
                sender.sendMessage(ChatColor.DARK_RED+"You do not have sufficent permissions to perform this action.");
            }
            return true;
        }

When you type /halt <playername> it says the current size of the array, says player has been halted then says the old size + 1 then the name you just entered implying that the array is storing data however when you type /haltlist it says Array is empty implying that no data was stored and no names come up.. any help is appreciated

 

mike546378

I just reproduced your code, and I'm willing to bet it has something to do with your CommandExecutor implementation (I'm assuming you used a CommandExecutor). The problem is, when you getCommand().setExecutor(new Executor()), you are creating new instances of the CommandExecutor. Because you have different commands, you need to change a few things to enable communication between different commands:

You need to make the ArrayList<String> a public static object, because it belongs to the class, not an instance. By making the list static, you guarantee that only one instance of the player list is generated.

EDIT: I just tested my suggested change, and it works now.

 

collielimabean Thanks, working now. Getting some errors w/ my Listeners but I'll try sorting them out on my own