Hashmap Problems, Keep getting nulls[Economy-like Plugin]

Trying to make an economy-like plugin. Basically whenever a new player logs into the server, they are start out with $100, but for some reason when I do /balance, I am getting a null?
Pay special close attention to onPlayerJoin?
This is mainly for practice and I'm not using to make an actually useful plugin, just practice

Code:

package me.shinobuattack.mobmoney;
 
import java.util.HashMap;
import java.util.logging.Logger;
 
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.plugin.java.JavaPlugin;
 
public class MobMoney extends JavaPlugin{
private static final Logger log = Logger.getLogger("Minecraft");
public final HashMap<String, Integer> playerMoney = new HashMap<String, Integer>();
 
@Override
public void onDisable(){
log.info("[MobMoney] has been disabled.");
}
 
@Override
public void onEnable(){
log.info("[MobMoney] has been enabled.");
}
 
public boolean onCommand(CommandSender sender, Command cmd, String commandLbl, String[] arg){
Player player = (Player)sender;
if(commandLbl.equalsIgnoreCase("balance")){
if(arg.length == 0){
player.sendMessage("Balance: \n$" + playerMoney.get(player.getName()));
}else if(arg.length == 1){
Player targetPlayer = player.getServer().getPlayer(arg[0]);
player.sendMessage("Balance of " + ChatColor.GREEN + targetPlayer.getName() + ChatColor.YELLOW + ": $" + playerMoney.get(targetPlayer.getName()));
}
}
return false;
}
@EventHandler
public void onPlayerJoin(PlayerJoinEvent event)
{
if(!event.getPlayer().hasPlayedBefore()){
event.getPlayer().sendMessage(ChatColor.DARK_BLUE + "Welcome, " + ChatColor.AQUA + "First timer, " + ChatColor.GREEN + event.getPlayer().getDisplayName());
playerMoney.put(event.getPlayer().getName(), 100);
}else{
event.getPlayer().sendMessage(ChatColor.DARK_BLUE + "Welcome, " + event.getPlayer().getDisplayName() + ChatColor.DARK_AQUA + "to the Server!");
}
}
}

 

Register the events and implement listener

 

Lolmewn thank you
Hmm.. not sure if I did it right. Registering events is something that is always done in the onEnable, right? Also, is this an effective way of starting first time players out with money in an economy server? Not perfect, just if it gets the job done?

Code:

public class MobMoney extends JavaPlugin implements Listener{
    private static final Logger log = Logger.getLogger("Minecraft");
    public final HashMap<String, Integer> playerMoney = new HashMap<String, Integer>();
 
    @Override
    public void onDisable(){
        log.info("[MobMoney] has been disabled.");
    }
 
    @Override
    public void onEnable(){
        log.info("[MobMoney] has been enabled.");
        PluginManager pm = getServer().getPluginManager();
        pm.registerEvents((Listener)this, this);
    }

Oh, I think that it is a problem of saving the data in the hashmap, I'll do some research

 

shinobuattack yep, on enable. Also, instead of using hasPlayedBefore I suggest you use your config to see if he already has a balance. If not, set it to default.

 

Would MySQL DataBase be better? Which would be easiest, or better yet, which is more efficient MySQL DataBase or using the config. Also for some reason when I try to put information on my config nothing happens, it just remains a blank yml

Lolmewn
EDIT: I don't think I am ready for MySQL so could you explain to me how to store the player balance to config.yml?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

shinobuattack check out the wiki, there's a great article on how to use the config.

 

Lolmewn First, I'd like to thank you for taking the time to answer my problems, and second
I am aware of that wiki. It has useful information but for some reason I can't set any values in it but I am able to check my config.yml but... I am able to use,for example:

Code:java

if(this.getConfig().contains(player.getName())){
bal += 100.0;
playerMoney.put(player.getName(), bal);

That works fine. but when I try to set a String, it can't access it or something. Not sure what is wrong. Ex:

Code:java

@Override
public void onDisable(){
log.info("[Economy] has been disabled.");
this.getConfig().set("message", "some string");
}

I've tried doing this in many points of my code but it just doesn't write anything in the config :/

Here's the full code:

Code:java

package me.shinobuattack.econ;
 
import java.util.HashMap;
import java.util.logging.Logger;
 
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Economy extends JavaPlugin implements Listener{
Double bal = 1000.0;
private static final Logger log = Logger.getLogger("Minecraft");
public final HashMap<String, Double> playerMoney = new HashMap<String, Double>();
 
@Override
public void onDisable(){
log.info("[Economy] has been disabled.");
this.getConfig().set("message", "some string");
}
 
@Override
public void onEnable(){
this.reloadConfig();
log.info("[Economy] has been enabled.");
PluginManager pm = getServer().getPluginManager();
pm.registerEvents(this, this);
}
 
//public boolean
 
public boolean onCommand(CommandSender sender, Command cmd, String commandLbl, String[] arg){
Player player = (Player)sender;
if(commandLbl.equalsIgnoreCase("balance")){
if(arg.length == 0){
player.sendMessage("Balance:\n $ " + getPlayerBal(player.getName()));
}else if(arg.length == 1){
Player targetPlayer = player.getServer().getPlayer(arg[0]);
player.sendMessage(ChatColor.GOLD + "Balance of " + ChatColor.GREEN + targetPlayer.getName() + ChatColor.WHITE + ": $ " + getPlayerBal((targetPlayer.getName())));
}
}else if(commandLbl.equalsIgnoreCase("add")){
if(this.getConfig().contains(player.getName())){
bal += 100.0;
playerMoney.put(player.getName(), bal);
}else
player.sendMessage(ChatColor.RED + "You must be registered on this server to add to your balance!");
}
return false;
}
@EventHandler
public void onPlayerJoin(PlayerJoinEvent event)
{
if(this.getConfig().contains(event.getPlayer().getName())){
event.getPlayer().sendMessage(ChatColor.DARK_BLUE + "Welcome, " + ChatColor.WHITE + event.getPlayer().getDisplayName() + ChatColor.DARK_GREEN + " to the Server!");
}else{
playerMoney.put(event.getPlayer().getName(), bal);
event.getPlayer().sendMessage(ChatColor.DARK_BLUE + "Welcome, " + ChatColor.AQUA + "First timer, " + ChatColor.GREEN + event.getPlayer().getDisplayName());
this.getConfig().set("playerMoney", playerMoney); // <--- Is this the right way of storing a HashMap??
}
}
 
public Double getPlayerBal(String playerName){
if(playerMoney.containsKey(playerName)){
return playerMoney.get(playerName);
}
return 0D;
}
 
 
}
 

 

You may also want to take a look at serialization, which stores a native Java object into a .ser file. You can use that to store your HashMap.

http://www.vogella.com/articles/JavaSerialization/article.html

 

shinobuattack Try using saveDefaultConfig(), this saves the config.yml which is in the root directory of your jar.
Also, don't forget to saveConfig() after modifying it.

 

I get the weird feeling that this is about to work

Lolmewn
Yep, it writes in the config now

Now it seems that I am unable to check if a player name is in the config (which it now is) and everytime I log into my localserver, it says that I am a new player (I obviously am not)
Here's the code:

Code:java

@EventHandler
public void onPlayerJoin(PlayerJoinEvent event)
{
if(getConfig().contains(event.getPlayer().getName())){ // This line
event.getPlayer().sendMessage(ChatColor.DARK_BLUE + "Welcome, " + ChatColor.WHITE + event.getPlayer().getDisplayName() + ChatColor.DARK_GREEN + " to the Server!");
}else{
playerMoney.put(event.getPlayer().getName(), bal);
event.getPlayer().sendMessage(ChatColor.DARK_BLUE + "Welcome, " + ChatColor.AQUA + "First timer, " + ChatColor.GREEN + event.getPlayer().getDisplayName());
getConfig().set("playerMoney", playerMoney);
}
}

Also:

Code:java

else if(commandLbl.equalsIgnoreCase("add")){
if(getConfig().contains(player.getName())){ // This line too
bal += 100.0;
playerMoney.put(player.getName(), bal);
}else
player.sendMessage(ChatColor.RED + "You must be registered on this server to add to your balance!");
}

Is that the correct way of checking a config for a String?

Okay for the /add command that I made, in that if statement, instead of

Code:java

player.sendMessage(ChatColor.RED + "You must be registered on this server to add to your balance!");

I put:

Code:java

player.sendMessage(ChatColor.RED + getConfig().getString(player.getName()));

and I got back a null for what should have been a String so does that mean that the String is there ( I know it is ) and I am accessing config incorrectly?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

shinobuattack What does your config look like?

 

Lolmewn
The only thing I put in my config was the HashMap:

playerMoney: Jaycalli50: 1000.0

 

shinobuattack Then you should use 'playerMoney.Jaycalli50' for the path instead of only your name.

 

Lolmewn Thank you! It worked

Lolmewn
I'm really sorry, I have to ask another question... No rush, whenever you feel like it just because I keep pestering you, really sorry. How do I retrieve the balance from the config if it is a potentially changeable value? I've been trying to rap my head around this for the past hour and a half to no avail

This is what I have so far (and btw, it returns null again >.<)

Code:java

public Double getPlayerBal(String player){
playerMoney.put(getConfig().getString("playerMoney." + player), getConfig().getDouble("playerMoney." + player + "." + bal));
return playerMoney.get(player);
}
}
 

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

shinobuattack I'd simply either load the configuration on start and save the data every... Say 10 minutes, or only use the configuration and no sets or maps

 

Lolmewn I'm not sure if that is my problem.. I can't access the balance because it is a changeable double so I was thinking about looping the HashMap with the config so it would be like this: (HashMap --> config <--> HashMap) so it would start out as playerMoney (the hashmap) then transfer to config then I'd have to access config again in order to get the balance because there is no other way to get the balance after the player logs off the server than the config, right?

 

shinobuattack unless you keep them in your hashmap, yes. I suggest you try and take a look at how simply economy plugins do this, actually. Try looking one up on dbo, and look for its source.

 

Yeah, I thought it was weird that my head was spinning round n round from just trying to get access a value I already had.. Idk what is wrong with me but I'll give what you said a try, thanks for the suggestion.