Solved Problems with Traps

I'm adding in a feature to my plugin so when you place a stone pressure plate on top of gravel, it will create a trap so when someone walks on it it will explode. I have created a custom class to do this:

Code:java

public class DemomanTrap {
    private Location loc;
 
    public DemomanTrap(Location loc){
        this.loc = loc;
    }
 
    public Location getLocation(){
        return this.loc;
    }
 
    public void explode(){
        TNTPrimed tnt = (TNTPrimed) loc.getWorld().spawnEntity(loc, EntityType.PRIMED_TNT);
        tnt.setFuseTicks(0);
    }
}

And on my BlockPlaceEvent, I add a new DemomanTrap to a List<DemomanTrap>. However, on my PlayerMoveEvent, it will not explode. This is what I have:

Code:java

for(DemomanTrap trap : demomanTraps){
  if(trap.getLocation() == player.getLocation()){
    trap.explode();
  }
}

But this doesn't work. I have registered my events, added @EventHandler, and even am doing another thing in my PlayerMoveEvent method that works. Can anyone explain what's going wrong and how I can fix it? Thanks!

 

first of all, you cant compare 2 locations by doing trap.getLocation() == player.getLocation(). The proper way to do this is to do trap.getLocation().equals(player.getLocation())

Second of all, the x,y,and z components of locations are stored as doubles. if the player is even a hair off of the location of the trap, they wont be equal and will therefore not go off. Try instead doing

Code:

if (trap.getLocation().distance(player.getLocation()) <= 1) {
    trap.explode()
}

Third, make sure you are registering the events and adding EventHandlers, if you arent already

 

Correct. xWatermelon do something like this:

Code:java

Location loc = new Location(player.getWorld(), player.getLocation().getBlockX(), player.getLocation().getBlockY(), player.getLocation().getBlockZ());
 
if(trap.getLocation().equals(loc)){
  trap.explode();
}

Not always, if you save a block's location, it will be stored as world, int, int int. An easy fix would be to use the code I gave above.