running out of memory using ArrayLists (HELP!)

This is where teaching yourself java instead of taking a class on it will bite you in the butt. after about 10 or 20 seconds, my server crashes due to no memory being left. im running code similar to this, but i dont know why its taking so much memory? its got something to do with the arraylist. does anyone know whats up?

Code:Java

ArrayList<Location> blocks = new ArrayList<Location>();//defined globally
 
public ArrayList<Location> cube (Location l1, Location l2){
blocks.clear();//this should take care of the memory problem, but it doesnt!
//change l1's location by one block with for loops, eventually covering every block between l1 and l2.
blocks.add(l1.clone());
return blocks;
 
}
 
public void mainMethod(){//runs every 20 ticks
//'one' and 'two' are corners of a small square (3x3)
Location one = null, two = null;//ignore these being null
for (Location l : cube(one,two)) {
l.getBlock().setType(Material.GLASS);
}
}

 

How many blocks are you changing? Also, how much ram are you starting your server with?

 

chasechocolate

1gig of ram, and im changing 9 blocks each time the mothod is called. its a 3x3 2D cube under an entity.

1gig of ram should be plenty, im just obviously not clearing something after every use, and im not sure what it is...

 

l1.clone() probably this

 

Shevchik
it still happens with this code:

Code:java

Location temp = new Location(l1.getWorld(), l1.getX(), l1.getY(), l1.getZ());
blocks.add(temp);
temp = null;

 

Code:

blocks.add(temp.getBlock());

That work maybe?

 

XDemonic25

if 'blocks' was a Block array it would work, but its a Location array.. 2 different classes

 

my bad, didnt see that.. i saw "blocks.add" and auto-matically assumed it was a block xD

 

XDemonic25

its all good lol. im 100% sure its a memory problem with an ArrayList, but i just cant figure out whats going on, because i clear it after every use.

going to try and make the method that returns the arraylist static... that should help right?

edit: didnt do anything

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

When posting a code snippet illustrating your problem, you should try to include just exactly the amount of code needed in order to reproduce it - too much, and the bug is drowned in all the irrelevant noise around it; too little, and you risk losing all the necessary context or even the bug itself. In other words, SSCCE!

You've definitely taken too much out in this case - the snippet you've posted will neither compile nor cause the problem you've described. It's pseudo code, and only shows how you think the program ought to work, not how it is actually put together.

The problem might not be with the array list itself - perhaps you're creating too many block instances?