New Crafting Recipe

Why isn't this working? It's in my onEnable():

Code:

final ShapedRecipe mossycobble = new ShapedRecipe(new ItemStack(Material.MOSSY_COBBLESTONE, 1));
        mossycobble.shape("AXX", "BXX", "XXX");
        mossycobble.setIngredient('A', Material.VINE);
        mossycobble.setIngredient('B', Material.DIRT);
        mossycobble.setIngredient('X', Material.AIR);
        getServer().addRecipe(recipe);

 

getServer().addRecipe(recipe);

should be

getServer().addRecipe(mossycobble);

 

still doesnt work

 

Why are you using a shaped recipe.. just use shapeless for something like that.

 

How do I make a shapeless recipe? I thought that made it shapeless...

 

ShapelessRecipe recipe = new ShapelessRecipe(new ItemStack(Material.<output material>, <int>));
recipe.addIngredient(Material.<input material>);
getServer().addRecipe(recipe);

 

It still doesn't add any recipe.

 

The only thing I can think is that you need to do this.getServer but that doesnt' make any sense..

 

Yeah I tried and it still didn't add it.

 

Add a delay? Have you tried making the mossy cobble in game or are you going off of the 195 recipies loaded thing?

 

I've gone off the 195 recipes thing and I've tried making it. Also, what do you mean by a delay?

I just tried a debug message in the recipe, and it printed, no idea what's wrong...
By the way, my code is now this:

Code:

public void MossyCobble() {
        ShapelessRecipe recipe = new ShapelessRecipe(new ItemStack(Material.MOSSY_COBBLESTONE, 1));
        recipe.addIngredient(Material.VINE);
        recipe.addIngredient(Material.DIRT);
        getServer().addRecipe(recipe);
        this.getServer();
    }

And yes, I have MossyCobble(); in my onEnable()

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

K.... KeybordPiano459 I myself haven't tried adding recipes, however, I might be able to mess around with it a bit tomorrow if you want...

 

Please do, I really want to know =/

 

You don't need to make it as a method. Have you tried simply putting the code in the onEnable()?

 

Code:java

package me.Travja.MossyCobble;
 
import java.util.logging.Logger;
 
import org.bukkit.Material;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.ShapedRecipe;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin{
    Logger log;
    public void onEnable(){
        log = this.getLogger();
        this.MossyCobble();
        log.info("MossyCobble Loaded and Added recipe!");
    }
    public void onDisable(){
        log.info("MossyCobble Disabled!");
    }
    public void MossyCobble() {
        ShapedRecipe recipe = new ShapedRecipe(new ItemStack(Material.MOSSY_COBBLESTONE, 1));
        recipe.shape("AAA", "ABA", "AAA");
        recipe.setIngredient('A', Material.VINE);
        recipe.setIngredient('B', Material.COBBLESTONE);
        this.getServer().addRecipe(recipe);
    }
}

That is my whole plugin right there, I loaded it up on an R2 server(don't know if that makes a difference) put a cobble in the middle and vines all around it and out came mossy cobble..... So I changed the recipe a little but it worked. It's basically the same as yours...

 

Wait it worked...

 

Cool! Well happy coding!!

 

What if instead of setting the empty slots to air, you set them to null?

 

Should work the same but it might be erroring because it isn't air....

 

I just thought that maybe it was air that was causing the problem, if you were to return an empty block in a players inventory wouldnt it return null rather than air?

 

When I said wait it worked... I meant it as a surprise. That exact code doesn't work for me.

 

Bump

 

I think Digi Knows alot of this
he can prob ''enlight'' you with his knowledge ^^

 

Yes the problem was the air, since unexistent items in the crafting grid are identified as null, the recipe was actually waiting for you to give it the item "air", which you just can't.

The last code provided should work just fine... it's the only way and you're most likely doing something wrong.

Also, you don't *have* to fill all the shapes, it can have 1 to 3 characters and you don't have to fill all 3 rows.
If you want to specify air, just leave a space.
Here's an example with your original shape:

Code:

ShapedRecipe recipe = new ShapedRecipe(new ItemStack(Material.MOSSY_COBBLESTONE, 1));
recipe.shape("A", "B");
recipe.setIngredient('A', Material.VINE);
recipe.setIngredient('B', Material.COBBLESTONE);
getServer().addRecipe(recipe);

Vine on top of cobblestone makes mossy cobblestone.
If you want it to not have a shape, just use ShapelessRecipe class instead.

If it still "doesn't work", post your entire test plugin, preferably the jar :}