Flying code?

I formatted this code in class today, I'm wondering if it would actually work, or would it give me a ton of errors as soon as I drop it into a plugin.

PHP:

public boolean onCommand(CommandSender sender, Command cmd, String CommandLabel, String[] args){
    if (cmd.getName().equalsIgnoreCase("fly"){
        if(!(sender isntanceOf Player)){
            sender.sendMessage("Only players may use this command!")}
        return false;
        else if (sender instanceOf Player){
            Player sender = sender.getName();
            sender.getAllowFlight(){
                if getAllowFlight.equals(false){
                    setAllowFlight.(True)}
                return true;
                if getAllowFlight.equals(true){
                    setAllowFlight(false)}
                return true;
                } 
            return true;
        else return false;
}}


Being on my phone, this may have a few cap mistakes or spacing mistakes. Other than that, will appreciate any help or critism that you may have. Thank you for your time.

 

i don't know much about java but i think you should make from this:
if getAllowFlight(false){
if getAllowFlight(true){
to this:
if (getAllowFlight.equals(true)){
if (getAllowFlight.equals(true)){

and you placed your return wrong

i a'm not sure so correct me if i'm wrong!

 

Equals true is probably correct, and the returns I can fix when I get home. Anything else you see wrong?

 

Player sender = sender.getName();

Should be:

Player player = (Player) sender;

as you've already got a variable called sender and you're declaring it as Player but setting it as String.

Also, this would be easier:

player.setAllowFlight(!player.getAllowFlight());

You've also misplaced a lot if brackets {} and it's unnecessary to check if the sender instanceof Player twice.

So, this is our result:

Code:

public boolean onCommand(CommandSender sender, Command cmd, String CommandLabel, String[] args){
    if(cmd.getName().equalsIgnoreCase("fly"){
        Player player;
 
        if(!(sender instanceof Player)){
            sender.sendMessage("Only players may use this command!")
            return false;
        }
        player = (Player) sender;
        player.setAllowFlight(!player.getAllowFLight());
        return true;
    }
}

Edit: And of cource, you have to return something even if the command isn't "fly".

 

Else return false; should e in there. Thank you very much

 

Code:java

 
public boolean onCommand(CommandSender sender, Command cmd, String CommandLabel, String[] args){
    if (cmd.getName().equalsIgnoreCase("fly"){
        if(!(sender isntanceOf Player)){
         /* ^^ unknown keyword: isntanceOf */
            sender.sendMessage("Only players may use this command!")}
              /* ^^ Missing ";" */
        return false;
         /* ^^ Code stops here, at this false, thats causing an
              unreachable statement at the line below */
        else if (sender instanceOf Player){
             /* ^^Unknown keyword: "instanceOf" */
             /* ^^ unknown "else", you need to place it direct after an "if" statement */
            Player sender = sender.getName();
             /* ^^ String cant be cast to an player */
             /* ^^ You already defined "sender" */
            sender.getAllowFlight(){
                /* ^^ Missing if statement or missing ;*/
                if getAllowFlight.equals(false){
                      /* ^^ Never defined  "getAllowFlight" */
                      /* ^^ missing () at the if statement */
                    setAllowFlight.(True)}
                 /* ^^ You never defined variable " setAllowFlight" */
                 /* ^^ You forgot the methode name after " setAllowFlight .(True)" */
                 /* ^^ There is no class named "True" */
                return true;
                /* ^^ code stops here, and causing unreachable stament errors on lines after */
                if getAllowFlight.equals(true){
                     /* ^^ missing () at if statement */
                     /* ^^ never defined " getAllowFlight " */
                    setAllowFlight(false)}
                     /* ^^ Unknown methode:  setAllowFlight(boolean) */
                     /* ^^ missing ';' */
                return true;
                } 
            return true;
        else return false;
}}
/* ^^ Missing return statement */
 

 

Thank you ferrybig , vilda was able to simplify shorten and correct most of it,

PHP:

public boolean onCommand(CommandSender sender, Command cmd, String CommandLabel, String[] args){
    if(cmd.getName().equalsIgnoreCase("fly"){
        Player player;
 
        if(!(sender instanceof Player)){
            sender.sendMessage("Only players may use this command!")
            return false;
        }
        player = (Player) sender;
        player.setAllowFlight(!player.getAllowFLight());
        return true;
    }
} 


 

So, I have finally been able to get to a computer with eclipse. I plugged the code. I corrected a few bracket errors, and tested it. But nothing is working. here is what I have so far;

Code:java

import java.util.logging.Logger;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin{
 
Logger log;
public void onEnable(){
log = this.getLogger();
log.info("Plugin has been enabled.");
}
public void onDisable(){
log.info("Plugin has been disabled.");
}
public boolean onCommand(CommandSender sender, Command cmd, String CommandLabel, String[] args){
if(cmd.getName().equalsIgnoreCase("fly")){
Player player;
 
if(!(sender instanceof Player)){
sender.sendMessage("Only players may use this command!");
return false;
}
else {
player = (Player) sender;
player.setAllowFlight(!player.getAllowFlight());
return true;
}
}
return true;
}
}
 

Any suggestions?
EDIT: And by "Nothing is working" I mean when I type in the code, I get nothing. No errors, no altered mechanics. Doesn't make me "fly" Like I had hoped.

 

If you are expecting it will make you fly, I don't think this will. I believe this just gives you the ability to fly. Try double jumping and see if you can fly.

 

Well, when I type in the command, it says "Unkown command" there's no errors in console, and from I understand it /should/ work.

 

Check your plugin.yml and make sure the command is set up properly and that you follow the format. Also make sure you are registering the command onEnable().

 

That could be it. I don't have it set it onEnable(). Time to go and look back in wiki.bukkit plugintut. I'll repaste when I get it right. Thanks for your help

 

Your welcome By the way the problem is the fact that your not registering anything for onEnable(). onEnable() is pretty essential to a plugin (my opinon). Then within that add the register code that should be on the wiki or just look at someones code about simple commands through youtube videos or github links off that.
Hope it works!
(By the way I think this only lets you have thw ability to fly through mods/Clients. I recommend checking out a youtube video that shows you how to make a fly command.)

 

Well I think I found the problem. I got it to work and display the message "Only users are able to use this command!" to the console. but as a player it sais I do not5 have permission to use it. I looked back into the jd.bukkit and found that there are two getAllowFlight and setAllowFlight methods. One for letting people in the server fly(Like in creative) and one in org.bukkit.plugin.messaging.TestPlayer node where It sais "Ability to set if a player is able to fly using double space". Is there anyway to distinguish in the code which should be used?

 

no you werent oped when you tried it. op yourself.

give the command a permission and use permissionsex

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Had already been done. I'm going to keep fiddling

No more permission problem, but I think my problem now is it's not saving the players ability to fly. I've also added a player.sendMessage to say that they can fly. it displays that but When I try to doubletap fly it doesn't let me. which brought me to the conclusion of it's not saving the fly variable anywhere. here's the oncommand method.

Code:java

public boolean onCommand(CommandSender sender, Command cmd, String CommandLabel, String[] args){
   if(cmd.getName().equalsIgnoreCase("fly")){
   Player player;
 
   if (!(sender instanceof Player)){
       sender.sendMessage("Only players may use this command!");
       return false;
       }
   player = (Player) sender;
       player.setAllowFlight(!(player.getAllowFlight()));
       sender.sendMessage("You can now fly!");
       return true;
       }return true;
}
}
 
EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Code:

                if ((commandlabel.equalsIgnoreCase("fly")))
                  if(args.length == 0){
                      if (player.getAllowFlight() == (true)){
                          player.setAllowFlight(false);
                          player.sendMessage(" Flying Disabled");
                      } else {
                            player.setAllowFlight(true);
                            player.sendMessage(" Flying Enabled");

This always works.