Solved YAML Issue, just can't figure out what's wrong myself..

So I've gone around in my code the past two days debugging my code to figure out what's wrong with my code, but I just can't figure it out.

I'm trying to make multi-world YAML config handling. It works creating the world folders and creating the file inside those folders, it also works saving the files.

However, when I'm trying to write into the files, it won't work at all, nothing is being written, neither with file.addDefault() and file.set().

Here's my class:

Code:java

 
 
package com.mrmag518.iSafe.Files;
 
import com.mrmag518.iSafe.Util.Log;
 
import java.io.File;
import java.io.IOException;
import java.util.logging.Level;
import java.util.logging.Logger;
 
import org.bukkit.Bukkit;
import org.bukkit.World;
import org.bukkit.configuration.file.FileConfiguration;
import org.bukkit.configuration.file.YamlConfiguration;
 
public class Blacklist {
    public static void manageBlacklistDir() {
        for(World world : Bukkit.getWorlds()) {
            String worldname = world.getName();
 
            if(worldname == null) {
                Log.debug("Could not load worldname: " + worldname + ", because it is null.");
                return;
            }
 
            File blacklistDir = new File("plugins/iSafe/Blacklists");
            File worldDir = new File(blacklistDir + "/" + worldname);
            File blacklistFile = new File(worldDir + "/blacklist.yml");
 
            if(!blacklistDir.exists()) {
                blacklistDir.mkdir();
            }
 
            if(!worldDir.exists()) {
                worldDir.mkdir();
            }
 
            if(!blacklistFile.exists()) {
                try {
                    blacklistFile.createNewFile();
                } catch (IOException ex) {
                    Logger.getLogger(Blacklist.class.getName()).log(Level.SEVERE, "Error creating " + blacklistFile + " :(", ex);
                }
            }
        }
    }
 
    public static void loadBlacklists() {
        for(World world : Bukkit.getWorlds()) {
            String worldname = world.getName();
 
            getBlacklist(worldname).options().header("test"); // Wont' write
 
            getBlacklist(worldname).addDefault("test", true); // Wont' write
            getBlacklist(worldname).set("set-test", false); // Wont' write
 
            getBlacklist(worldname).options().copyDefaults(true);
            saveBlacklist(worldname);
        }
        //saveBlacklists();
    }
 
    public static FileConfiguration getBlacklist(String worldname) {
        File blacklistFile = new File("plugins/iSafe/Blacklists/" + worldname + "/blacklist.yml");
        FileConfiguration blacklist = null;
 
        if(blacklistFile.exists() || blacklistFile != null) {
            blacklist = YamlConfiguration.loadConfiguration(blacklistFile);
        }
 
        if(blacklist == null) {
            return null;
        }
 
        return blacklist;
    }
 
    public static void saveBlacklist(String worldname) {
        File blacklistFile = new File("plugins/iSafe/Blacklists/" + worldname + "/blacklist.yml");
 
        if(!blacklistFile.exists() || blacklistFile == null) {
            return;
        }
 
        try {
            getBlacklist(worldname).save(blacklistFile);
        } catch (IOException ex) {
            Logger.getLogger(Blacklist.class.getName()).log(Level.SEVERE, "Error saving blacklist file " + blacklistFile, ex);
        }
    }
 
    public static void saveBlacklists() {
        for(World world : Bukkit.getWorlds()) {
            File blacklistFile = new File("plugins/iSafe/Blacklists/" + world.getName() + "/blacklist.yml");
 
            if(!blacklistFile.exists() || blacklistFile == null) {
                return;
            }
 
            try {
                getBlacklist(world.getName()).save(blacklistFile);
            } catch (IOException ex) {
                Logger.getLogger(Blacklist.class.getName()).log(Level.SEVERE, "Error saving blacklist file " + blacklistFile, ex);
            }
        }
    }
}
 
 

 

MrMag518 Your check to see if the world name is null would throw a NPE if the World was actually null, you should probably change that.

As for why your BlackList isn't saving, it's actually rather simple. Every time you call getBlackList(String) you're reloading the FileConfiguration object. You need to keep a reference to the FileConfiguration and use the same object, rather than creating a new one every time you change it.

Basically:

Code:

// Rather than
getBlackList(world).set("stuff", null);
// Do something like
FileConfiguration blackList = getBlackList(world);
// Do some stuff with it.
blackList.set("stuff", null);
// Then save it, making sure to use the same object(this means you need to change your saveBlackList(String) method as well.
blackList.save(blackListFile);

 

Omg thank you so much, I can't belive it was that simple!

/solved