Writing to new line in txt file

Okay i have created a referral plugin and i make it save who you refered and who issued the command and it saves it fine on the first line but if you do the command again it just replaces it

 

It should work if u type this inside the string, for example: "I m boss \n And i love my self"

 

Forgive the messy code but here it is i know there is some other stuff to be fixed but im just intrested in this problem right now

Code:java

package Main;
 
 
 
import java.io.BufferedWriter;
import java.io.File;
import java.io.FileWriter;
import java.io.IOException;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Color;
import org.bukkit.GameMode;
import org.bukkit.Server;
import org.bukkit.World;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
@SuppressWarnings("unused")
public class refer extends JavaPlugin{
 
public void onEnable(){
File refer = new File(getDataFolder() + File.separator + "Refer");
File usernames = new File(getDataFolder() + File.separator + "Refer" + "Usernames.txt");
if (!refer.exists()) {
if (refer.mkdir()) {
System.out.println("Directory is created!");
try {
refer.createNewFile();
} catch (IOException e) {
System.out.println("Failed to create directory!2");
e.printStackTrace();
}
} else {
System.out.println("Failed to create directory!");
}
}
getLogger().info("Enabled!");
}
 
public void onDisable(){
getLogger().info("Disabled");
}
 
@SuppressWarnings("deprecation")
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
File usernames = new File(getDataFolder() + File.separator + "Refer" + File.separator + "Usernames.txt");
Player player = (Player) sender;
Server server = player.getServer();
Player target1 = Bukkit.getServer().getPlayer(args[0]);
if(cmd.getName().equalsIgnoreCase("refer")){
if (args.length == 1) {
 
if (player.getServer().getPlayer(args[0]) != null) {
Player target = player.getServer().getPlayer(args[0]);
 
sender.sendMessage(ChatColor.GREEN+ "[Referal] "+ ChatColor.GOLD +" : "+ ChatColor.AQUA +"You just refered " + target.getDisplayName());
target.sendMessage(ChatColor.GREEN+ "[Referal] "+ ChatColor.GOLD +" : "+ ChatColor.AQUA +"You have just been refered by " + player.getDisplayName());
 
try{
 
 
 
FileWriter fw = new FileWriter(usernames.getAbsoluteFile());
BufferedWriter bw = new BufferedWriter(fw);
bw.write("Refered " + args[0] + " : " + "Command sent by " + sender.getName());
bw.newLine();
bw.flush();
bw.close();
}catch(IOException e){
 
}
}else{
sender.sendMessage(ChatColor.RED+ "[Error] "+ ChatColor.GOLD +" : "+ChatColor.AQUA +"The member you tried to refer is not online");
}
 
}
}
 
 
 
return false;
}
}

Bump*

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

have you tried what i told ya?

 

I tried that before and it didn't work

So i dont know what to try now :L

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

ChromeHD__
Instead of using a buffered writer, try something like this:

Code:java

try {
    PrintWriter out = new PrintWriter(new BufferedWriter(new FileWriter(usernames)));
    out.println("the text"); // this will output the text on a new line, just like System.out.println()
    out.close();
} catch (IOException e) {
    //catch
}

 

It looks like you're just overwriting the same file each time? You probably want to append to it, which looks like this:

Code:java

PrintWriter pw = new PrintWriter(new FileWriter(usernames, true));

See: http://docs.oracle.com/javase/6/doc...er.html#FileWriter(java.lang.String, boolean)

The BufferedWriter may or may not really be necessesary for the small amount of text it looks like you're writing at a time.

Hope that helps!

 

BufferedWriters or any sort of filewriters have an option to either append, or overwrite the file, for a bufferedwriter, it'd look something like this.

Code:

BufferedWriter writer = new BufferedWriter(new FileWriter(usernames, true));

 

Holy bumparoo.....
1. You need more patience.
2. It is against the rules to bump before 24 hours before your last post.

As for your issue, show us your new code.

EDIT: Did you call flush() after writing to the PrintWriter?

 

Yeah sorry I did call flush() but now nothing is getting sent to the txt file

 

ChromeHD__ as The_Doctor_123 said please paste your new coding. And The_Doctor_123 always will be a big fan of doctor who (off topic but still)

 

The code is the same as the one I posted before because none of the above suggestions worked

 

ChromeHD__
Okay.. here's what you're going to need to do. Define these at the top of your class:

Code:java

File usernames = new File(getDataFolder() + File.separator + "Refer" + File.separator + "Usernames.txt");
PrintWriter pw = new PrintWriter(new BufferedWriter(new FileWriter(usernames, true)));

Then to write a line to the file, just use:

Code:

pw.println(/*Whatever you want to print to file*/);
pw.flush();

Probably should close the PrintWriter too in the onDisable() method.

Code:

pw.close();

 

That problem is fixed now thanks but there is one more little problem I need help with it writes to the txt file now how do I make it check if the user has already referred someone

 

You will need to read the file before appending to it if you want to check for duplicates before adding.

Look at BufferedReader.readLine:

http://docs.oracle.com/javase/7/docs/api/java/io/BufferedReader.html#readLine()

Just follow the same basic pattern with Readers as you did with Writers to open the file. Then, call readLine() until you get null, adding each String you get back to a Set<String>.

You can use .contains() to check that set to see if the new username is already there - if it is, do nothing. If it is not, add it to the set.

At that point, you can either just invoke your current code and append to the file, or write the contents of the Set out to a file (which makes the issues with appending irrelevant, though it sounds like you've got that worked out).

Also, just a general pointer- Google and Stack Overflow are great resources for general (non-Bukkit-specific) Java questions, too- a lot of the simpler stuff has usually been asked and answered already somewhere, so you don't have to wait for a response. It can be tricky to know what to search for in the first place, though.

 

Thanks man I got it to work a while ago but for some reason it wouldn't let me use else after

i tried using that but it wouldnt let me use a else statement

Code:java

 BufferedReader br = null;
 
            try {
 
                String sCurrentLine;
 
                br = new BufferedReader(new FileReader(usernames.getAbsolutePath()));
 
                while ((sCurrentLine = br.readLine()) != null) {
                    if(sCurrentLine.contains("Command sent by " + sender));
                    sender.sendMessage(ChatColor.RED+ "[Error] "+ ChatColor.GOLD +" : "+ChatColor.AQUA +"You have already refered someone");
                }
 
            } catch (IOException e) {
            } finally {
                try {
                    if (br != null)br.close();
                } catch (IOException ex) {
                }
            }

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Looks like a stray semicolon on line 10 - I think you want something like

Code:java

            BufferedReader br = null;
            boolean isDuplicate = false;
            try {
 
                String sCurrentLine;
 
                br = new BufferedReader(new FileReader(usernames.getAbsolutePath()));
 
                while ((sCurrentLine = br.readLine()) != null) {
                    if(sCurrentLine.contains("Command sent by " + sender)) {
                        sender.sendMessage(ChatColor.RED+ "[Error] "+ ChatColor.GOLD +" : "+ChatColor.AQUA +"You have already refered someone");
                        isDuplicate = true;
                    }
                }
 
            } catch (IOException e) {
            } finally {
                try {
                    if (br != null)br.close();
                } catch (IOException ex) {
                }
            }
 
            if (!isDuplicate) {
              // ... call code here to append to file
            }

Note you probably don't want to try to write to the file while you have it open for reading, though I guess I don't know what the locking situation is so it might work.

 

NathanWolf now it wont write anything D:

 

The code you're using to write out the file hasn't changed, though? Can you re-test just that part in isolation?

 

nothing changed and now it wont say anything ingame

 

Do you want to post your new code?

 

Code:java

package Main;
 
 
 
import java.io.BufferedReader;
import java.io.BufferedWriter;
import java.io.File;
import java.io.FileReader;
import java.io.FileWriter;
import java.io.IOException;
 
 
import java.io.LineNumberReader;
import java.io.PrintWriter;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Color;
import org.bukkit.GameMode;
import org.bukkit.Server;
import org.bukkit.World;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
@SuppressWarnings("unused")
public class refer extends JavaPlugin{
public static int currentLine = 0;
public void onEnable(){
File refer = new File(getDataFolder() + "");
File usernames = new File(getDataFolder() + File.separator + "" + File.separator + "Usernames.txt");
 
if(!refer.exists()){
refer.mkdir();
 
System.out.println("[Refer] Folder has been made");
}else{
System.out.println("[Refer] Loaded Usernames.txt");
}
if (!usernames.exists()) {
try {
usernames.createNewFile();
} catch (IOException e) {
e.printStackTrace();
}
}
 
getLogger().info("Enabled!");
}
 
 
public void onDisable(){
getLogger().info("Disabled");
}
 
@SuppressWarnings("null")
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
File usernames = new File(getDataFolder() + File.separator + "" + File.separator + "Usernames.txt");
try {
@SuppressWarnings("resource")
PrintWriter pw = new PrintWriter(new BufferedWriter(new FileWriter(usernames, true)));
} catch (IOException e1) {
e1.printStackTrace();
}
Player player = (Player) sender;
Server server = player.getServer();
Player target1 = Bukkit.getServer().getPlayer(args[0]);
if(cmd.getName().equalsIgnoreCase("refer")){
if(args.length == 0){
sender.sendMessage(ChatColor.RED+ "[Usuage] "+ ChatColor.GOLD +" : "+ChatColor.GREEN +"/refer <Username>");
}else if (args.length == 1) {
if (!(player.getServer().getPlayer(args[0]) != null)) {
sender.sendMessage(ChatColor.RED+ "[Error] "+ ChatColor.GOLD +" : "+ChatColor.AQUA +"The member you tried to refer is not online");
}else{
Player target = player.getServer().getPlayer(args[0]);
 
BufferedReader br = null;
boolean isDuplicate = false;
try {
 
String sCurrentLine;
 
br = new BufferedReader(new FileReader(usernames.getAbsolutePath()));
 
while ((sCurrentLine = br.readLine()) != null) {
isDuplicate = false;
if(isDuplicate = false){
try{
 
PrintWriter out = new PrintWriter(new BufferedWriter(new FileWriter(usernames,true)));
out.println("Refered " + target.getDisplayName() + " : " + "Command sent by " + sender.getName());
out.close();
}catch(IOException e){
 
}
sender.sendMessage(ChatColor.GREEN+ "[Referal] "+ ChatColor.GOLD +" : "+ ChatColor.AQUA +"You just refered " + target.getDisplayName());
target.sendMessage(ChatColor.GREEN+ "[Referal] "+ ChatColor.GOLD +" : "+ ChatColor.AQUA +"You have just been refered by " + player.getDisplayName());
 
 
}
}
if(sCurrentLine.contains("Command sent by " + sender)) {
sender.sendMessage(ChatColor.RED+ "[Error] "+ ChatColor.GOLD +" : "+ChatColor.AQUA +"You have already refered someone");
}
 
 
}catch (IOException e) {
} finally {
try {
if (br != null)br.close();
} catch (IOException ex) {
}
 
}
return false;
}
}
}
return false;
}
}

 

Make sure not to do that

You need to first create the FileReader, read in the file, and decide whether you need to add it. Then close that reader before going on to the FileWriter. Just like the pseudocode I wrote.

I'm not certain this is the problem, but I can imagine what you're doing up there is going to have issues.

It might help to separate out some of this code into functions at this point to keep it organized - e.g. "void addToFile(String username)" and "boolean fileContains(String username)".

Good luck!