Solved Why does this timer doesn't work

Code:

@EventHandler
    public void onInteract(PlayerInteractEvent e) {
        Player p = e.getPlayer();
        Action a = e.getAction();
        if(a.equals(Action.RIGHT_CLICK_AIR)) {
            if(p.getItemInHand() != null) {
                ItemStack item = p.getItemInHand();
                Timer t = new Timer();
                TimerTask test = new TimerTask() {

                        @Override
                        public void run() {
                            // TODO Auto-generated method stub
                            Bukkit.broadcastMessage("0");
                        }
                       
                      };
                if(item.getType().equals(Material.DIAMOND)) {
                    t.schedule(test, 0, 1000);
                } else if(item.getType().equals(Material.EMERALD)) {
                    test.cancel();
                    t.cancel();
                    t.purge();
                }
            }
        }
    }

When I right click the diamond, it starts the timertask, but when I click the emerald, the task doesn't stop. Can anyone tell me why this happens..?

 

@timtower but does bukkitrunnable work like timer?

 

@timtower

Code:

if(a.equals(Action.RIGHT_CLICK_AIR)) {
            if(p.getItemInHand() != null) {
                ItemStack item = p.getItemInHand();
                BukkitRunnable runnable = new BukkitRunnable() {

                    @Override
                    public void run() {
                        // TODO Auto-generated method stub
                        Bukkit.broadcastMessage("0");
                    }
                   
                };
                int i = 0;
                if(item.getType().equals(Material.DIAMOND)) {
                    i = getServer().getScheduler().scheduleSyncRepeatingTask(this, runnable, 0, 20);
                } else if(item.getType().equals(Material.EMERALD)) {
                    getServer().getScheduler().cancelTask(i);;
                   
                }
            }
        }

i did it but its the same.

 

@timtower the diamond worked but the emerald doesn't stop the runnable

 

then what can i do to stop the runnable?

 

@timtower

Code:

Map<UUID, BukkitTask> map;
   
    @EventHandler
    public void onInteract(PlayerInteractEvent e) {
        Player p = e.getPlayer();
        Action a = e.getAction();
        if(a.equals(Action.RIGHT_CLICK_AIR)) {
            if(p.getItemInHand() != null) {
                ItemStack item = p.getItemInHand();
                BukkitRunnable runnable = new BukkitRunnable() {

                    @Override
                    public void run() {
                        // TODO Auto-generated method stub
                        Bukkit.broadcastMessage("0");
                    }
                   
                };
                if(item.getType().equals(Material.DIAMOND)) {
                    BukkitTask task = getServer().getScheduler().runTaskTimer(this, runnable, 0, 20);
                    map.put(p.getUniqueId(), task);
                } else if(item.getType().equals(Material.EMERALD)) {
                    getServer().getScheduler().cancelTask(map.get(p.getUniqueId()).getTaskId());
                   
                }
            }
        }

still doesn't work

 

@timtower

Code:

HashMap<UUID, BukkitTask> map = new HashMap<UUID, BukkitTask>();
   
    @EventHandler
    public void onInteract(PlayerInteractEvent e) {
        Player p = e.getPlayer();
        Action a = e.getAction();
        if(a.equals(Action.RIGHT_CLICK_AIR)) {
            if(p.getItemInHand() != null) {
                ItemStack item = p.getItemInHand();
                BukkitRunnable runnable = new BukkitRunnable() {

                    @Override
                    public void run() {
                        // TODO Auto-generated method stub
                        Bukkit.broadcastMessage("0");
                    }
                   
                };
                if(item.getType().equals(Material.DIAMOND)) {
                    if(map.containsKey(p.getUniqueId())) {
                        p.sendMessage("You have already started the timer!");
                        return;
                    }
                    BukkitTask task = getServer().getScheduler().runTaskTimer(this, runnable, 0, 20);
                    map.put(p.getUniqueId(), task);
                } else if(item.getType().equals(Material.EMERALD)) {
                    map.get(p.getUniqueId()).cancel();
                    map.remove(p.getUniqueId());
                }
            }
        }
    }

Thank you timtower! This finally works!

@timtower
can i ask something more?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

does the runnable works with ticks?
if so what can i do to run a task every 1 millisecond?

 

@timtower ok thanks!