What have I done wrong? VotifierListener

Commands run as they should... Only problem is if someone votes it will say that players name and its like its stuck in a loop every other person who votes it will say the first person voted below i have attached the code... It will give the person the proper reward but it will also give the same reward to the first person who voted

Code:java

import java.io.File;
import java.io.FileReader;
import java.io.FileWriter;
import java.util.Properties;
import java.util.logging.Level;
import java.util.logging.Logger;
 
import org.bukkit.Bukkit;
import org.bukkit.entity.Player;
 
import com.vexsoftware.votifier.Votifier;
import com.vexsoftware.votifier.model.Vote;
import com.vexsoftware.votifier.model.VoteListener;
 
public class ThetaListener
implements VoteListener
{
private static Logger logger = Logger.getLogger("ThetaListener");
private String command_1 = "";
private String command_2 = "";
private String command_3 = "";
private String command_4 = "";
private String command_5 = "";
private String playermessage = "";
private String broadcastmessage = "";
 
public ThetaListener()
{
Properties props = new Properties();
try
{
File configFile = new File("./plugins/Votifier/commands.ini");
if (!configFile.exists())
{
configFile.createNewFile();
 
 
props.load(new FileReader(configFile));
 
 
props.setProperty("Command_1", this.command_1);
props.setProperty("Command_2", this.command_2);
props.setProperty("Command_3", this.command_3);
props.setProperty("Command_4", this.command_4);
props.setProperty("Command_5", this.command_5);
props.setProperty("Player_Message", this.playermessage);
props.setProperty("Broadcast_Message", this.broadcastmessage);
props.store(new FileWriter(configFile), "ThetaListener Configuration | {user} = Player who voted | {site} = Site voted on | & for colors |");
}
else
{
props.load(new FileReader(configFile));
}
this.command_1 = props.getProperty("Command_1", this.command_1);
this.command_2 = props.getProperty("Command_2", this.command_2);
this.command_3 = props.getProperty("Command_3", this.command_3);
this.command_4 = props.getProperty("Command_4", this.command_4);
this.command_5 = props.getProperty("Command_5", this.command_5);
this.playermessage = props.getProperty("Player_Message", this.playermessage);
this.broadcastmessage = props.getProperty("Broadcast_Message", this.broadcastmessage);
}
catch (Exception ex)
{
logger.log(Level.WARNING, "Unable to load commands.ini");
}
}
 
public void voteMade(Vote vote)
{
String username = vote.getUsername();
{
try
{
this.broadcastmessage = this.broadcastmessage.replace('&', '§').replace("§§", "&").replace("{user}", username).replace("{site}", vote.getServiceName());
Votifier.getInstance().getServer().broadcastMessage(this.broadcastmessage);
}
catch (Exception ex)
{
System.out.println("[Votifier] ThetaListener error: " + vote);
}
Player player = Bukkit.getServer().getPlayer(username);
if (player != null)
if (this.command_1 != "") {
this.command_1 = this.command_1.replace('&', '§').replace("§§", "&").replace("{user}", username).replace("{site}", vote.getServiceName());
Bukkit.getServer().dispatchCommand(Bukkit.getServer().getConsoleSender(), this.command_1);
}
if (this.command_2 != "") {
this.command_2 = this.command_2.replace('&', '§').replace("§§", "&").replace("{user}", username).replace("{site}", vote.getServiceName());
Bukkit.getServer().dispatchCommand(Bukkit.getServer().getConsoleSender(), this.command_2);
}
if (this.command_3 != "") {
this.command_3 = this.command_3.replace('&', '§').replace("§§", "&").replace("{user}", username).replace("{site}", vote.getServiceName());
Bukkit.getServer().dispatchCommand(Bukkit.getServer().getConsoleSender(), this.command_3);
}
if (this.command_4 != "") {
this.command_4 = this.command_4.replace('&', '§').replace("§§", "&").replace("{user}", username).replace("{site}", vote.getServiceName());
Bukkit.getServer().dispatchCommand(Bukkit.getServer().getConsoleSender(), this.command_4);
}
if (this.command_5 != "") {
this.command_5 = this.command_5.replace('&', '§').replace("§§", "&").replace("{user}", username).replace("{site}", vote.getServiceName());
Bukkit.getServer().dispatchCommand(Bukkit.getServer().getConsoleSender(), this.command_5);
}
if (this.playermessage != "") {
this.playermessage = this.playermessage.replace('&', '§').replace("§§", "&").replace("{user}", username).replace("{site}", vote.getServiceName());
player.sendMessage(this.playermessage);
}
}}}
 
 
 

 

TheFluffyWalrus

Just as a note you shouldn't compare strings with != you should do .equals()

 

Watto
changing that now I am still very new at this...

 

dont use

1. private static Logger logger = Logger.getLogger("ThetaListener");

 

TheFluffyWalrus

Also your problem i believe is at line 74.
Since you're replacing the {user} and {site} on the first player, so those variables no longer exist in the string.
To fix that just set it as a new String rather than broadcastMessage.

 

Set a new string in what way?

 

TheFluffyWalrus I'll try to demonstrate the point Watto made

Okay, so you have your broadcastMessage as just "{user}". Then later on, once someone votes, you go to replace {user} with the name of whoever voted. Doing so creates a new String, as Strings are immutable. This would be fine, except you then change broadcastMessage to point to that new message. For example, if I'd voted, the message would now be "AdamQpzm" not "{user}". When another person goes to vote, it can't replace {user}, since it's no longer {user}, it's AdamQpzm...

The solution? Don't do the this.broadcastMessage = ... bit

 

soo...

Code:java

try
{
this.broadcastmessage.replace('&', '§').replace("§§", "&").replace("{user}", username).replace("{site}", vote.getServiceName());
Votifier.getInstance().getServer().broadcastMessage(this.broadcastmessage);
}
catch (Exception ex)

 

TheFluffyWalrus Not quite. You should assign the replace stuff to a local variable, and then broadcast the local variable.

 

I guess I am still lost lol are we talking more like this

Code:java

private String format(String broadcastmessage, String playermessage, String command_1, String command_2, String command_3, String command_4, String command_5)
 

or am i far off again lol

or

Code:java

private String format.replace('&', '§').replace("§§", "&").replace("{player}", player).replace("{site}", site.getServiceName());
 

 

TheFluffyWalrus

Rather than set this.broadcastmessage to itself, Create a local String variable in the method, assign this.broadcast message to that String and send the player that String.

This is really basic, perhaps we just aren't great at explaining

Code:java

String newString = oldString;
 
newString = newString+" Hey";
 
player.sendMessage(newString);

This adds "Hey" to the end of newString but not to the end of oldString. Hopefully that makes it easier to understand.

 

ok so let me try this one more time

Code:java

String bm1 = broadcastmessage;
bm1 = bm1.replace('&', '§').replace("§§", "&").replace("{user}", username).replace("{site}", vote.getServiceName());;
Votifier.getInstance().getServer().broadcastMessage(bm1);

 

TheFluffyWalrus

That will work, you can skip most of those steps and just do

String bm1 = broadcastmessage.replace and etc.

 

-This isn't python, we don't use underscores.
-Please, learn how to use loops.
-Use ChatColor#translateAlternateColorCodes(char, String).
-Use JavaPlugin#getLogger().
-Don't compare objects with ==. Strings are objects.
-Just use .isEmpty() on the Strings.

 

Watto, AdamQpzm, I appreciate your help it works perfectly now thank you for all your help! Garris0n BUT underscores are sexy! xD Also thank you for all the great info!