Solved Vault Permissions?

I can't seem to make my command work. On typing it, with or without the correct syntax, it does nothing, not even say that the command does not exist.
I have an oncommand method something like:

Code:java

    public void command(CommandSender sender, Command command, String label, String[] args) {
            if(label.equalsequalsIgnoreCase("knowsskill")){
                                  if (args.length >= 3) {
                                  //do something
                                  }else{
                                  System.out.println("Not enough arguments");
              }
 
            }
 

in my plugin.yml I have something like:

Code:

##required plugin stuff up here
commands:
    knowsskill:

I'm not sure what else I'm supposed to do! I saw new Command() in the API, but I haven't seen anyone else using that.

 

Look at line 2 in the snippet. Find the corresponding line in your code. Does your IDE show errors on that line? Because "equalsequalsIgnoreCase" is not a method in the String class. Did you mean "equalsIgnoreCase"? Do not bother trying to run code with errors. It is bound to fail.

 

#Pseudocode
No errors, anywhere. This isn't the real code.

Fine. The real code is here

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Is the method called "command" like in the snippet above? What about showing the whole code and plugin.yml?

 

Yes, it is. I don't want to show the whole code for now if it can be avoided.

better formatting of the real method:

Code:java

    public void command(CommandSender sender, Command command, String label, String[] args) {
        if (label.equalsIgnoreCase("knowsskill")) {
            boolean hasProperPerms = false;
            if (!(sender instanceof Player)) {
                //yes, the console has proper perms.
                hasProperPerms = true;
            } else if (sender.hasPermission("ReignRpg.givePermissions")) {
                hasProperPerms = true;
            } else {
                sender.sendMessage("You don't have proper permissions.");
            }
            if (hasProperPerms) {
                if (args.length >= 3) {
                    if (Bukkit.getPlayer(args[0]) != null) {
 
                        boolean trueOrFalse;
                        if (args[2].equalsIgnoreCase("true") || args[2].equalsIgnoreCase("on") || args[2].equalsIgnoreCase("yes")) {
                            trueOrFalse = true;
                        } else if (args[2].equalsIgnoreCase("false") || args[2].equalsIgnoreCase("off") || args[2].equalsIgnoreCase("no")) {
                            trueOrFalse = true;
                        } else {
                            sender.sendMessage("A boolean value wasn't found after " + args[1]);
                            return;
                        }
 
                        PermissionAttachment permissionAttachment = Bukkit.getPlayer(args[0]).addAttachment(main, 1);
                        //does the skills.___ permission exist?
                        if (args[1].equalsIgnoreCase("teleswitch")
                                || args[1].equalsIgnoreCase("mindbomb")
                                || args[1].equalsIgnoreCase("blaze")
                                || args[1].equalsIgnoreCase("fireball")
                                || args[1].equalsIgnoreCase("vortex")
                                || args[1].equalsIgnoreCase("fantheflames")
                                || args[1].equalsIgnoreCase("vampirism")
                                || args[1].equalsIgnoreCase("eruption")) {
                            permissionAttachment.setPermission("ReignRpg." + args[1], trueOrFalse);
                        }
                    } else {
                        sender.sendMessage("Player not found.");
                    }
                } else {
                    sender.sendMessage("Not enough parameters.");
                }
            }
        }
    }

The command is /knowsskill [player] [skill] [boolean].
It gives or takes away that player's permission to use that skill.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Call the method "onCommand" (use @Override to be notified when trying to override a non-existent method)
If this is not in the main class, make sure to set the executor of the command to the class in question. (The class has to implement CommandExecutor if it is not the main class)

 

It's in the main class.
It has an @EventHandler above it, ofc
I've done an event called "interaction" before, and it worked onInteraction.
What are you trying to say about overrides?

 

Bobit Commands aren't events.

 

Bobit A command is not an event, no need to use @EventHandler or register events. The method must be called "onCommand" as it is inherited from JavaPlugin and can be overridden (giving a new implementation). Calling the method "command" won't get you far.

 

Alright, found it on the API.
I guess the method should return false if the command doesn't exist?

 

Bobit Yes. It should also return false if the command did not execute properly.

 

Alright, I'm lost while trying to use vault permissions.
1) Can you do perms.playerAdd(player, "ReignRpg." + args[1]) , assuming args[1] is a valid permission extension?
2) do you need to declare them in your plugin.yml?
3) player.hasPermission(string) is still used with vault permissions, right?

 

It's not working. I'm getting a null error here:

Code:java

if (perms.playerHas(player, "ReignRpg.fireball")) {
                    Skillz.fireball(this, player);
                } else {
                    System.out.println("You don't have permission.");
                }

Apparently perms is null. I followed this guide, but it's still not working.

The current code:

Code:java

public final class ReignRpg extends JavaPlugin implements Listener {
 
    /* this class is to contain:
    * 1) All of the listeners
    * 2) Methods so generic that it is very likely they will be used in multiple (game) classes.
    */
    public final Plugin main = this;
    public static Random rand = new Random();
    public static Permission perms = null;
    Skills Skillz = new Skills(); /*Skillz is an instance of the Skills class.
    * Skills is really just a library of skills, but it is made into an object because
    * it's always best to keep it there just in case. Cooldowns and methods
    * using cooldowns could easily be made static, but why bother?
    * That only messes with multi-server operations.
    */
 
 
    @Override
    public void onEnable() {
        System.out.println("Plugin [ReignRpg] has been enabled!");
        getServer().getPluginManager().registerEvents(this, this);
        this.saveDefaultConfig();
        assert !setupPermissions() : "[ERROR] permissions weren't set up!";
    }
 
    @Override
    public void onDisable() {
    }
 
    private boolean setupPermissions() {
        RegisteredServiceProvider<Permission> rsp = getServer().getServicesManager().getRegistration(Permission.class);
        perms = rsp.getProvider();
        return perms != null;
    }
 
    @EventHandler
    public void interaction(PlayerInteractEvent event) {
        //whenever the player right-clicks, this code is done. It should lead to all other "on-right-click" spells, with their conditions inside them.
        Player player = event.getPlayer();
        /*it's as simple as:
        * Skillz.{skillname}(this, [player]);
        * for almost every single skill you want to maybe activate on right-click.
        */
        //to make a new skill: insert listener here. Insert name into long or statement in oncommand. create code. declare permission in plugin.yml. declare config in config.yml.
        if (event.getAction() == Action.RIGHT_CLICK_AIR || event.getAction() == Action.RIGHT_CLICK_BLOCK) {
            if ((player.getItemInHand().getType()) == Material.FLINT) {
                System.out.println("Attempting to cast fireball");
                if (perms.playerHas(player, "ReignRpg.fireball")) {
                    Skillz.fireball(this, player);
                } else {
                    System.out.println("You don't have permission.");
                }
            } else if ((player.getItemInHand().getType()) == Material.GHAST_TEAR) {
                if (player.hasPermission("ReignRpg.mindBomb")) {
                    Skillz.mindBomb(this, player);
                }
            } else if ((player.getItemInHand().getType()) == Material.BLAZE_ROD) {
                if (player.hasPermission("ReignRpg.eruption")) {
                    Skillz.eruption(this, player);
                }
            } else if ((player.getItemInHand().getType()) == Material.BLAZE_POWDER) {
                if (player.hasPermission("ReignRpg.blaze")) {
                    Skillz.blaze(this, player);
                }
            }
 
            MaterialData itemData = player.getItemInHand().getData();
            //Check if it's a type of dye
            if (itemData instanceof Dye) {
                //Get the dye
                Dye dye = (Dye) itemData;
                if (dye.getColor().equals(DyeColor.WHITE)) {
                    if (player.hasPermission("ReignRpg.fanTheFlames")) {
                        Skillz.fanTheFlames(this, player);
                    }
                } else if (dye.getColor().equals(DyeColor.BLUE)) {
                    if (player.hasPermission("ReignRpg.vortex")) {
                        Skillz.vortex(this, player);
                    }
                }
            }
        }
    }
 
    @EventHandler
    public void sneakToggle(PlayerToggleSneakEvent event) {
        Player player = event.getPlayer();
        //if they're holding string
        if (((player.getItemInHand().getType()) == Material.STRING) && (!player.isSneaking())) {
            if (player.hasPermission("ReignRpg.teleswitch")) {
                Skillz.teleswitch(this, player);
            }
        }
    }
 
    @Override
    public boolean onCommand(CommandSender sender, Command command, String label, String[] args) {
        //the main purpose of commands for now is to give the admins the power to instantly change other's permissions. This is especially needed for skills that share the same cast-item.
        //knowsskill goobt teleswitch true
 
        if (label.equalsIgnoreCase("knowsskill")) {
            if (sender instanceof Player && !(sender.hasPermission("ReignRpg.givePermissions"))) {
                sender.sendMessage("You don't have proper permissions.");
                return false;
            }
            if (args.length >= 3) {
                if (Bukkit.getPlayer(args[0]) != null) {
 
                    boolean trueOrFalse;
                    if (args[2].equalsIgnoreCase("true") || args[2].equalsIgnoreCase("on") || args[2].equalsIgnoreCase("yes")) {
                        trueOrFalse = true;
                    } else if (args[2].equalsIgnoreCase("false") || args[2].equalsIgnoreCase("off") || args[2].equalsIgnoreCase("no")) {
                        trueOrFalse = false;
                    } else {
                        sender.sendMessage("A boolean value wasn't found after " + args[1]);
                        return false;
                    }
 
                    //does the skills.___ permission exist?
                    if (args[1].equalsIgnoreCase("teleswitch")
                            || args[1].equalsIgnoreCase("mindbomb")
                            || args[1].equalsIgnoreCase("blaze")
                            || args[1].equalsIgnoreCase("fireball")
                            || args[1].equalsIgnoreCase("vortex")
                            || args[1].equalsIgnoreCase("fantheflames")
                            || args[1].equalsIgnoreCase("vampirism")
                            || args[1].equalsIgnoreCase("eruption")) {
                        if (trueOrFalse) {
                            perms.playerAdd((Player) Bukkit.getPlayer(args[0]), "ReignRpg." + args[1]);
                            sender.sendMessage("Gave " + args[0] + " ReignRpg." + args[1]);
                            Bukkit.getPlayer(args[0]).sendMessage("You were given the permission ReignRpg." + args[1]);
                        } else {
                            perms.playerRemove((Player) Bukkit.getPlayer(args[0]), "ReignRpg." + args[1]);
                            sender.sendMessage("Took " + "ReignRpg." + args[1] + " from " + args[0]);
                            Bukkit.getPlayer(args[0]).sendMessage("Your permission ReignRpg." + args[1] + " was removed.");
                        }
                        return true;
                    } else {
                        sender.sendMessage("That skill doesn't exist.");
                        return false;
                    }
 
                } else {
                    sender.sendMessage("Player not found.");
                    return false;
                }
            } else {
                sender.sendMessage("Not enough parameters.");
                return false;
            }
        } else {
            return false;
        }
    }
 

Now it's saying I don't have permissions again, but there's not a null error!

Edit: Do I need to put something in my server's permission.yml for it to run?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Bobit Well you'll need the permission if that's what you mean?

 

AdamQpzm
Shouldn't the code I have automatically put it in the permissions.yml??

 

Bobit From a cursory glance, it doesn't look like you've created a plugin that ever assigns a permission, simply checks whether they have it (which, by the way, is a bad idea if that's what you're doing. You shouldn't use vault to check for a permission as bukkit can do that)

 

I'm using vault so that it can potentially be hooked into permissions plugins. I mean, I'm going to have to do that sooner or later, right?

The permission is assigned on line 129:

Code:java

perms.playerAdd((Player) Bukkit.getPlayer(args[0]), "ReignRpg."+args[1]);

 

Bobit Oh, I didn't see that bit. Are you sure that line is executed and runs successfully? Also, you should still use player.hasPermission("") instead, as it works independent of vault & permission plugins.

 

Yes, I'm sure it runs successfully. If you notice line 130, it has a System.out.println(), which outputs variables that make sense.
2 Questions:

1) You say "it works independent of vault & permission plugins". Do you need to somehow implement a permissions plugin for basic permissions setting like this to work?

2) How do you do it without vault? Don't you have to make a temporary permission attachment, and save the permissions to a config file?

 

Bobit 1) It depends what you mean. Vault provides the ability to hook into permissions plugins (as well as other thing) but it's not a permissions plugin itself, nor does it provide you with an interface for making one. In that regard, the server you are testing this on needs a permissions plugin, but it does not matter which one (as long as Vault supports it), and you do not need to adjust your own code to match whichever plugin you're using.

2) Without vault, I just meant checking for permissions. Think of these 3 similar but different things you can do with permissions:

- You can check if a player has a permission. This is something which any old plugin is likely to do, and is generally done without vault (e.g. by using something like event.getPlayer().hasPermission("item.use"))
- Give players a permission. This isn't as common as the above, and would be better done with vault. Generally the best use for this sort of situation is when they want to give a certain permission once something is done, rather than by default. For example, you might want to give players the "item.dropdouble" permission once they complete a certain task. You can do this without vault but each permissions plugin has its own way of giving players permissions. That's what vault does - you tell vault that you want this player to have that permission, and vault will work out what permissions plugin the user is using, and use the correct method for giving the player the permission according to whatever plugin they're using.
- Fully managing permissions. This is what we call a permissions plugin (like PEX, GroupManager, whatever...) and I believe this is what you're referring to in question 2. If you make a permissions plugin, it would effectively be your responsibility to answer questions like "does this player have this permission?" and to keep track of the permissions. Then you don't need vault at all, although you'd be much better off if you and vault supported each other (all big permissions plugins support vault, as that's what it's made for, and it makes it much easier for the server owners and plugin developers).

Well that message was a lot longer than I originally intended, how did that happen? Oh well, I hope it's of some use to you and doesn't confuse you further. I guess my question for your problem right now though is: do you have a permissions plugin installed? Or are you trying to make your own permissions plugin included in this?

 

I don't have a permissions plugin installed.

I want a method that gives/takes away a player's permission.
I want this to be a method I can call, I don't care whether it's in my plugin or the big permissions plugins.

The reason I want this is that, eventually, I want to make a skill tree, and when you give a player a skill point, they can spend it on unlocking new skills. I don't really want it to be that you're either in the group that has such-and-such skills, or you're in the other group that has different skills.

 

Bobit Then yes, it sounds like you're doing the thing I mentioned - giving a player a permission as a reward for completing a task (in this case, buying a skill). In that case you'll need to go with this sort of set-up:

On your test server: Make sure you have a permissions plugin (it doesn't matter what one, as long as it's one vault is compatible with) and vault

In your plugin: Hook into vault and assign the permission with playerAdd as you already are.

See if that works once you've installed the permissions plugin

 

Okay. Before I do that, will I have to tell vault which permissions plugin I want it to use?

 

Bobit Nope, it'll do that for you

 

Alright, I installed permissionsEX (would've installed bpermissions if it was updated, it looks easier)
The permissions.yml looks perfect:

Code:

groups:
  default:
    default: true
    permissions:
    - modifyworld.*
users:
  6443e36d-4675-47ae-ae41-90d03c849520:
    worlds:
      world:
        permissions:
        - ReignRpg.fireball

The code's running without any errors, too!
BUT
I still don't have permission

(I typed /knowsskill goobt fireball true, and then right-clicked flint to activate fireball, but it says I don't have permission!)

But WAIT!
When I restarted the server, it worked!
Now I'm searching for a method in vault/PEX that automatically reloads permissions. I'll set this to [SOLVED] if I find it.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Bobit I didn't think that would be necessary. However, if you do for some reason need to do that, I don't think there's a method for it in Vault.

However, what you could do is use the RegisteredServiceProvider, get the Plugin, and then just disable then enable it. That should work for any of the permissions plugins, but probably isn't the best way to go about things.

 

I googled it quickly, and the solution is:

Code:java

                            getServer().dispatchCommand(getServer().getConsoleSender(), "pex reload");

That's a PEX command, so it must be the best way.

And it works! [SOLVED]

(Although, the server did encounter a client-side "unexpected" error that disconnected me. But that's probably ok.)

 

Bobit Alright, but be warned that your plugin will no longer support other permissions systems by doing that, only pex

 

Probably less laggy though, so I'll stick with it for now. Later I could make a decision tree to see what is the least laggy known option for each plugin, but for now it'll just work with PEX.

Edit: after looking at the source code for /pex reload, yeah, this'll lag waaay less.