[Util] FireworkEffectPlayer v1.0

Rprrr

How did you loop through them? I tried to do it but it doesn't work, I had to change all sorts of stuff and... Just put it this way: I'm a noob when it comes to Lists and stuff xD
Would you (Or anyone else) care to tell me how to loop through the locations in the list and then spawn fireworks at the locations?
Thank you for your help and time.

 

What's the current compatible version?

 

Catchet

Code:

    List<Location> locationList = ...;
    new BukkitRunnable() {
        int count = 0;
       
        @Override
        public void run() {
            if (count < locationList.size()) {
                Location location = locationList.get(count);
                count++;
               
                //TODO: Play fireworks at Location 'location'.
            }
            else {
                cancel();
            }   
        }
    }.runTaskTimer(plugin, 0L, 1L);

 

So this would be correct ?

Code:java

public FireworkEffectPlayer fep = new FireworkEffectPlayer();
 
public boolean onCommand(CommandSender sender, Command cmd, String label, String args[]) {
 
final Player player = (Player) sender;
if(player instanceof Player) {
 
if(cmd.getName().equalsIgnoreCase("fireworker")) {
 
final List<Location> locationList = circle(player.getLocation(), 10, 1, true, false, 10);
 
new BukkitRunnable() {
int count = 0;
 
@Override
public void run() {
if (count < locationList.size()) {
Location location = locationList.get(count);
count++;
 
try {
fep.playFirework(player.getWorld(), location, player);
} catch (Exception e) {
e.printStackTrace();
}
}
else {
cancel();
}
}
}.runTaskTimer(this, 0L, 1L);
}
}
return false;
}
 
public List<Location> circle (Location loc, Integer r, Integer h, Boolean hollow, Boolean sphere, int plus_y) {
List<Location> circleblocks = new ArrayList<Location>();
 
int cx = loc.getBlockX();
int cy = loc.getBlockY();
int cz = loc.getBlockZ();
for (int x = cx - r; x <= cx +r; x++) {
for (int z = cz - r; z <= cz +r; z++) {
for (int y = (sphere ? cy - r : cy); y < (sphere ? cy + r : cy + h); y++) {
double dist = (cx - x) * (cx - x) + (cz - z) * (cz - z) + (sphere ? (cy - y) * (cy - y) : 0);
if (dist < r*r && !(hollow && dist < (r-1)*(r-1))) {
Location l = new Location(loc.getWorld(), x, y + plus_y, z);
circleblocks.add(l);
}
}
}
}
 
return circleblocks;
}

 

Yo guys I have a problem. using the exact code from the OP, I get a rocket that flies into the air for about a second before exploding, and I just want the explodey effect. I don't even want to see the rocket. can I do it with packets instead?

actually, is there a way to make an instance of a firework entity without actually spawning it?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

I made this with it http://dev.bukkit.org/bukkit-plugins/firework-magic/
but it might still be awaiting approval

 

i am new with java can you write an example:
firework spawn with rightclick with stick
Thanks!

 

If you're new to java, then learn it.

 

I'm working on!
but can you write an example

 

Code:java

p.sendMessage("You should fully learn java first, not be working on it when you start with bukkit.");

 

Thanks!

 

Awesome!

Is there a reason that sometimes it spawns a firework, but no effect plays? :O
It does it about 2 times in this video:
(ignore the lag, I have the worst pc ever ;p, it also may still be uploading, just wait a bit)
Code for that:

Code:java

package me.sgavster.QuadularMC.listeners;
 
import me.sgavster.QuadularMC.util.FireworkEffectPlayer;
 
import org.bukkit.Color;
import org.bukkit.FireworkEffect;
import org.bukkit.FireworkEffect.Type;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.EntityDamageEvent;
 
public class ShiftFallListener implements Listener
{
 
    FireworkEffectPlayer f = new FireworkEffectPlayer();
 
    @EventHandler(priority = EventPriority.HIGH)
    public void onFall(EntityDamageEvent e)
    {
        if(e.getEntity() instanceof Player)
        {
            Player p = (Player) e.getEntity();
            if(p.isSneaking())
            {
                e.setDamage(0);
                try
                {
                    f.playFirework(p.getWorld(), p.getLocation(), FireworkEffect.builder().flicker(false).trail(false).with(Type.BALL).withColor(Color.ORANGE).withFade(Color.RED).build());
                }
                catch (Exception ex)
                {
                    ex.printStackTrace();
                }
            }
        }
    }
}

 

sgavster I have also experienced that sometimes it doesn't play an effect, but this doesn't seem to be an error it's probably a bug of the broadcastEntityEffect method :/

 

DarkBladee12 I actually Tweeted Codename_B and asked him, he said
It's annoying! D:

 

The minecraft client can only render so much fireworks at once.

 

codename_B I'm only spawning 1 at a time with my code though? o-o

 

Hello,
This player isnt working for me, any help?

Code:java

public class FTPlayer {
    private Method world_getHandle = null;
    private Method nms_world_broadcastEntityEffect = null;
    private Method firework_getHandle = null;
 
 
    public void playFirework(World world, Location loc, FireworkEffect fe) throws Exception {
        Firework fw = (Firework) world.spawn(loc, Firework.class);
        Object nms_world = null;
        Object nms_firework = null;
 
        if(world_getHandle == null){
            world_getHandle = getMethod(world.getClass(), "getHandle");
            nms_firework = firework_getHandle.invoke(fw, (Object[]) null);
        }
            if(nms_world_broadcastEntityEffect == null) {
                nms_world_broadcastEntityEffect = getMethod(nms_world.getClass(), "broadcastEntityEffect");
            }
        FireworkMeta data = (FireworkMeta) fw.getFireworkMeta();
        data.clearEffects();
        data.setPower(1);
        data.addEffect(fe);
        fw.setFireworkMeta(data);
 
        nms_world_broadcastEntityEffect.invoke(nms_world, new Object[] {nms_firework, (byte) 17});
        fw.remove();
    }
 
    private static Method getMethod(Class<?> cl, String method){
        for(Method m : cl.getMethods()) {
            if(m.getName().equals(method)){
                return m;
            }
        }
        return null;
    }
 
 
}
 

In my listener:

Code:java

@SuppressWarnings("deprecation")
    @EventHandler
    public void rightClickStick(PlayerInteractEvent e){
        Player player = e.getPlayer();
        if(e.getAction() == Action.RIGHT_CLICK_AIR || e.getAction() == Action.RIGHT_CLICK_BLOCK){
            if(player.getItemInHand().getType().equals(Material.STICK)){
              try {
                  fplayer.playFirework(player.getWorld(), player.getTargetBlock(null, 200).getLocation(),
                          FireworkEffect.builder().with(FireworkEffect.Type.BALL).withColor(Color.AQUA).build());
              }catch (Exception exc){
 
              }
            }
        }
    }

Ok nevermind I am stupid it works now hahaha

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

I can make so much nice with this thanks!!!!!!!

 

I would like to point out that as if this commit, you can do this just with firework.detonate().

 

Ultimate_n00b Ooh, that's good to know!

I tried it; I get this error:

PHP:

08.12 14:04:15 [Server] INFO at net.minecraft.server.v1_7_R1.ThreadServerApplication.run(SourceFile:617) [craftbukkit_dev_2930.jar:git-Bukkit-1.6.4-R2.0-9-g68d0e57-b2930jnks]
08.12 14:04:15 [Server] INFO at net.minecraft.server.v1_7_R1.MinecraftServer.run(MinecraftServer.java:447) [craftbukkit_dev_2930.jar:git-Bukkit-1.6.4-R2.0-9-g68d0e57-b2930jnks]
08.12 14:04:15 [Server] INFO at net.minecraft.server.v1_7_R1.MinecraftServer.t(MinecraftServer.java:535) [craftbukkit_dev_2930.jar:git-Bukkit-1.6.4-R2.0-9-g68d0e57-b2930jnks]
08.12 14:04:15 [Server] INFO at net.minecraft.server.v1_7_R1.DedicatedServer.u(DedicatedServer.java:250) [craftbukkit_dev_2930.jar:git-Bukkit-1.6.4-R2.0-9-g68d0e57-b2930jnks]
08.12 14:04:15 [Server] INFO at net.minecraft.server.v1_7_R1.MinecraftServer.u(MinecraftServer.java:577) [craftbukkit_dev_2930.jar:git-Bukkit-1.6.4-R2.0-9-g68d0e57-b2930jnks]
08.12 14:04:15 [Server] INFO at org.bukkit.craftbukkit.v1_7_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:345) [craftbukkit_dev_2930.jar:git-Bukkit-1.6.4-R2.0-9-g68d0e57-b2930jnks]
08.12 14:04:15 [Server] INFO at org.bukkit.craftbukkit.v1_7_R1.scheduler.CraftTask.run(CraftTask.java:53) ~[craftbukkit_dev_2930.jar:git-Bukkit-1.6.4-R2.0-9-g68d0e57-b2930jnks]
08.12 14:04:15 [Server] INFO at me.sgavster.ghostsquadron.runnable.AutoEnd.run(AutoEnd.java:62) ~[?:?]
08.12 14:04:15 [Server] INFO java.lang.NoSuchMethodError: org.bukkit.entity.Firework.detonate()V

~code:

PHP:

                        Firework firework = o.getWorld().spawn(o.getLocation(), Firework.class);
                        FireworkMeta data = (FireworkMeta) firework.getFireworkMeta();
                        data.addEffects(FireworkEffect.builder().flicker(false).trail(false).with(Type.BURST).withColor(Color.RED).withFade(Color.WHITE).build());
                        firework.setFireworkMeta(data);
                        firework.detonate();

I'm on build #2938. Not sure what I'm doing wrong
EDIT: Also tried on #2930

 

#2942 looks like it should have it, try that.

 

Ultimate_n00b Worked haha, thanks!

 

I created a quick example showing the new 1.7 method.



Code involves a modified version of Rprrr 's circle generator:

Code:java

final List<Location> blocks = circle(p.getLocation(), 30, 1, true, false, 25);
new BukkitRunnable() {
    int maxIterations = 2;
    int iterations = 0;
 
    @Override
    public void run() {
        iterations = 0;
        while (!blocks.isEmpty() && iterations++ < maxIterations) {
            final Firework fw = (Firework) p.getWorld().spawnEntity(blocks.get(0), EntityType.FIREWORK);
            FireworkMeta meta = fw.getFireworkMeta();
 
            meta.addEffect(FireworkEffect.builder().withColor(Color.BLUE).withColor(Color.WHITE).withFade(Color.WHITE).build());
 
            fw.setFireworkMeta(meta);
 
            fw.detonate();
            blocks.remove(0);
        }
        if (blocks.isEmpty()) {
            this.cancel();
        }
    }
}.runTaskTimer(this, 0, 1);

Modified method:

Code:

private List<Location> circle(Location loc, Integer r, Integer h, Boolean hollow, Boolean sphere, int plus_y) {
    List<Location> circleblocks = new ArrayList<Location>();
    int cx = loc.getBlockX();
    int cy = loc.getBlockY();
    int cz = loc.getBlockZ();
    int i = 0;
    for (int x = cx - r; x <= cx + r; x++)
        for (int z = cz - r; z <= cz + r; z++)
            for (int y = (sphere ? cy - r : cy); y < (sphere ? cy + r : cy + h); y++) {
                double dist = (cx - x) * (cx - x) + (cz - z) * (cz - z) + (sphere ? (cy - y) * (cy - y) : 0);
                if (dist < r * r && !(hollow && dist < (r - 1) * (r - 1))) {
                    if(i++ < 2) {
                        continue;
                    } else {
                        i = 0;
                    }
                    Location l = new Location(loc.getWorld(), x, y + plus_y, z);
                    circleblocks.add(l);
                }
            }
 
    return circleblocks;
}

Sadly as you could see in the video, Mojang's limit of 30 fireworks still exists. In the circle method, I had to make it skip 2 fireworks for every 3 to even get it to look nice.

 

Ultimate_n00b Ooh very nice.

 

Ultimate_n00b Pretty lights! Makes a nice intro!

 

This code works perfectly on my test server, however on my main server it usually doesn't spawn the effect. The server isn't really laggy, and I've never had problems with normal fireworks. I'm using this for a cannon plugin. Any suggestions?

 

The detonate is juste setFuse=0 (or something like that) you still have the sound of the rocket :/.

Else I have the same issue with the effect that does not display sometimes, for only one firework, that's odd but happen with BALL Type (not large) more often (why ?).

 

Yup i'm having the same problem. I'll be iterating through different firework effects - 1 every 2 seconds, and about half of them don't show.

 

bob7 Likaos This seems to be a bug of Bukkit/Minecraft :/