[Util] Edit ItemStack attributes, adding speed, damage or health bonuses.

Hmm, I get a NPE using https://gist.github.com/aadnk/6753244 and https://gist.github.com/aadnk/6754159

Code:

2013-10-21 05:33:17 [INFO] Maddis1337 issued server command: /krpg test
2013-10-21 05:33:17 [SEVERE] null
org.bukkit.command.CommandException: Unhandled exception executing command 'krpg' in plugin KRPG-Items v0.0.3
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46)
at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:192)
at org.bukkit.craftbukkit.v1_6_R3.CraftServer.dispatchCommand(CraftServer.java:523)
at net.minecraft.server.v1_6_R3.PlayerConnection.handleCommand(PlayerConnection.java:959)
at net.minecraft.server.v1_6_R3.PlayerConnection.chat(PlayerConnection.java:877)
at net.minecraft.server.v1_6_R3.PlayerConnection.a(PlayerConnection.java:834)
at net.minecraft.server.v1_6_R3.Packet3Chat.handle(SourceFile:49)
at net.minecraft.server.v1_6_R3.NetworkManager.b(NetworkManager.java:296)
at net.minecraft.server.v1_6_R3.PlayerConnection.e(PlayerConnection.java:116)
at net.minecraft.server.v1_6_R3.ServerConnection.b(SourceFile:37)
at net.minecraft.server.v1_6_R3.DedicatedServerConnection.b(SourceFile:30)
at net.minecraft.server.v1_6_R3.MinecraftServer.t(MinecraftServer.java:592)
at net.minecraft.server.v1_6_R3.DedicatedServer.t(DedicatedServer.java:227)
at net.minecraft.server.v1_6_R3.MinecraftServer.s(MinecraftServer.java:488)
at net.minecraft.server.v1_6_R3.MinecraftServer.run(MinecraftServer.java:421)
at net.minecraft.server.v1_6_R3.ThreadServerApplication.run(SourceFile:583)
Caused by: java.lang.NullPointerException
at net.minecraft.server.v1_6_R3.NBTTagCompound.clone(SourceFile:265)
at net.minecraft.server.v1_6_R3.NBTTagList.clone(SourceFile:90)
at net.minecraft.server.v1_6_R3.NBTTagCompound.clone(SourceFile:265)
at net.minecraft.server.v1_6_R3.ItemStack.cloneItemStack(ItemStack.java:265)
at org.bukkit.craftbukkit.v1_6_R3.inventory.CraftItemStack.asCraftCopy(CraftItemStack.java:67)
at org.bukkit.craftbukkit.v1_6_R3.inventory.CraftInventory.firstPartial(CraftInventory.java:254)
at org.bukkit.craftbukkit.v1_6_R3.inventory.CraftInventory.addItem(CraftInventory.java:281)
at de.kaleydra.krpg.KRPGCommand.onCommand(KRPGCommand.java:100)
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44)
... 15 more

from KRPGCommand:100

Code:java

 
item.addAttribute(AttributeType.GENERIC_MOVEMENT_SPEED, 5.0); // instanceof KRPGItem
final ItemStack item2 = item.getItem();
((Player)sender).getInventory().addItem(item2);
 

from KRPGItem:

Code:java

 
	//<AttributeType,Value>
	Map<String,Double> attributes = new HashMap<String,Double>();
 
       [...]
 
	public ItemStack getItem(){
		ItemStack item = new ItemStack(material);
		ItemMeta itemMeta = item.getItemMeta();
		itemMeta.setDisplayName(customName);
		itemMeta.setLore(getLore());
		item.setItemMeta(itemMeta);
 
		return applyAttributes(item);
	}
 
	public ItemStack applyAttributes(ItemStack item){
		if(this.attributes == null || this.attributes.isEmpty())
			return item;
 
		Attributes attributes = new Attributes(item);
		for(String type:this.attributes.keySet()){
			attributes.add(Attribute.newBuilder().type(new AttributeType(type)).amount(this.attributes.get(type)).build());
		}
		return attributes.getStack();
	}
 

 

Have you tried adding a name to these attributes, like in my example?

That might be what's causing the NPE. Somehow, a null name gets assigned to the NBT data.

If not, could you print the content of the NBT tag? If you're using the ProtocolLib version (or native version), then all that's required is to call the toString() method on the NbtList attributes, and print the result.

 

Jepp, that was it Works like charm!

EDIT: Is there a way to edit attributes of entities, too?

 

Good to hear.

Of course, it should probably have complained about the missing name in the first place (which I've now added). But the library was never intended to last very long, only until Bukkit releases a proper API ...

Not with this library, but you can do it with NMS.

 

I wonder if it has the effect if I give an item with attributes to an entity via the equipment... Anyone experience with that?

 

@Comphenix is it possible to get an update of this for 1.7.2? getting an error trying to use it.

Code:

us.iluthi.soulofw0lf.ultimatesurvival.utility.NbtFactory.getMethod(NbtFactory.java:715) ~[?:?]
02.12 12:38:02 [Server] INFO Caused by: java.lang.IllegalStateException: Unable to find method createTag ([byte, class java.lang.String]).

referring to

Code:java

    private static Method getMethod(int requireMod, int bannedMod, Class<?> clazz, String methodName, Class<?>... params) {
        for (Method method : clazz.getDeclaredMethods()) {
            // Limitation: Doesn't handle overloads
            if ((method.getModifiers() & requireMod) == requireMod &&
                    (method.getModifiers() & bannedMod) == 0 &&
                    (methodName == null || method.getName().equals(methodName)) &&
                    Arrays.equals(method.getParameterTypes(), params)) {
 
                method.setAccessible(true);
                return method;
            }
        }
        // Search in every superclass
        if (clazz.getSuperclass() != null)
            return getMethod(requireMod, bannedMod, clazz.getSuperclass(), methodName, params);
        throw new IllegalStateException(String.format(
                "Unable to find method %s (%s).", methodName, Arrays.asList(params)));
    }

 

This is because the NBT library in Minecraft no longer stores tag names in the NBT tags themselves, but as keys in NBTTagCompound. Thus, NBTBase.createTag has changed signature from createTag(byte tagId, String tagName) to createTag(byte tagId):

Code:java

protected static NBTBase createTag(byte paramByte) {
// etc.
}

To solve this, simply remove String.class here (in private NbtFactory()):

Code:java

NBT_CREATE_TAG = getMethod(Modifier.STATIC, 0, BASE_CLASS, "createTag", byte.class);

Then update the createNbtTag method:

Code:

private Object createNbtTag(NbtType type, Object value) {
    Object tag = invokeMethod(NBT_CREATE_TAG, null, (byte)type.id);
 
    if (value != null) {
        setFieldValue(getDataField(type, tag), tag, value);
    }
    return tag;
}

I'd love to do this myself, but I'm pretty preoccupied with updating ProtocolLib at the moment. I'll finish it later.

 

@Comphenix - Completely understand man. Proto-Lib is an awesome project and it's a good thing it has such a dedicated dev for it

Everyone else
ok so i tried updating it myself. Since comp is busy if anyone else wants to take a crack at it here's the nbt factory with his recommended changes

https://gist.github.com/soulofwolf/91c606f5e1276625c068

here's the Attribute class
https://gist.github.com/soulofwolf/7d9a210723ad3631098e

and here's what i wrote to build items with it

Code:java

public class Stats {
    public static ItemStack createItem(ItemStack iS, String stat, double value){
        if (stat.equalsIgnoreCase("health")){
            Attributes attributes = new Attributes(iS);
            attributes.add(Attributes.Attribute.newBuilder().name("Health")
                    .type(Attributes.AttributeType.GENERIC_MAX_HEALTH).amount(value).build());
        }
        if (stat.equalsIgnoreCase("speed")){
            Attributes attributes = new Attributes(iS);
 
            attributes.add(Attributes.Attribute.newBuilder().name("Speed")
                    .type(Attributes.AttributeType.GENERIC_MOVEMENT_SPEED).amount(value).build());
 
        }
        if (stat.equalsIgnoreCase("damage")){
            Attributes attributes = new Attributes(iS);
 
            attributes.add(Attributes.Attribute.newBuilder().name("Damage")
                    .type(Attributes.AttributeType.GENERIC_ATTACK_DAMAGE).amount(value).build());
 
        }
        if (stat.equalsIgnoreCase("knockback")){
            Attributes attributes = new Attributes(iS);
 
            attributes.add(Attributes.Attribute.newBuilder().name("KnockBack")
                    .type(Attributes.AttributeType.GENERIC_KNOCKBACK_RESISTANCE).amount(value).build());
 
        }
        return iS;
    }
}

still erroring out completely due to a null object from the save and load from the nbt factory and i have no clue what to do for it. So if any of you aren't busy and can take a look at it it would be appreciated.

 

Just bumping to see if this will be updated?

 

Have you tried using my NbtFactory on GitHub? I believe I added a link to it.

 

I must have missed that. Thanks!

 

Epic library!