[Urgent] Drag & Drop Shop Plugin!

Hey fellas, I'm in a bit need of help. I'm making a drag & drop shop plugin that gives players a certain amount based on my config.yml and it's working ok, but still extremely buggy and I've even set up debug messages.

Basically, it functions by when the menu opens a book item with instructions as its lore on how to use the automatic shop is set at the first slot of the inventory. When they close the shop, I'm trying to get it to remove the book from slot 1, make sure the inventory isn't empty, and then check EACH SLOT of the inventory and add to the "Cost" int which is how much the user will be paid, then go through a check to make sure that there aren't any broken items in the inventory and make sure the price of the items sold are all above $0 in the config.yml.

I'm currently using the ints "broke", and "soldnothing" as 0/1 ghetto booleans you could say lol. Basically, if the item isn't at full durability in a certain slot "broke" is set at 1 and gives back that broken item so they can't sell it, and once it goes to pay the user if broke = 1 it tells them some of the items they sold we're repaired fully so they have been returned to them.

I'm in need of help. Please Bukkit, why isn't this working?

Problem #1: Open the inventory & close it and I get the message "you can't sell those items"​

Expectation for #1: A message that says "You did not put in any items to sell!"​

​

Problem #2: If I put an item in that has a cost above $0 in the config.yml, it sends me a debug message saying "there was nothing in the inventory" and that I didn't put any items to sell.​

Expectation for #2: It should sell the item.​

Will somebody please check my code?

Code:java

package me.EliteLX.ExternoxShop;
 
import java.util.ArrayList;
import java.util.List;
 
import net.milkbowl.vault.economy.Economy;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.inventory.InventoryCloseEvent;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
import org.bukkit.plugin.RegisteredServiceProvider;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main
extends JavaPlugin
implements Listener
{
private ItemStack ist;
Economy vault = null;
boolean vaultLoaded = false;
String shopName = "";
 
String prefix = (ChatColor.AQUA + "[" + ChatColor.GOLD + "Externox 2.0" + ChatColor.AQUA + "] " + ChatColor.YELLOW);
 
 
public void onDisable()
{
getLogger().info("ExternoxShop Disabled!");
}
 
public void onEnable()
{
if (!setupEconomy())
{
getLogger().severe("Vault not found with loaded economy plugin, disabling!");
setEnabled(false);
return;
}
getLogger().info("Enabling...");
getServer().getPluginManager().registerEvents(this, this);
getLogger().info("Registered Events!");
getConfig().options().copyDefaults(true);
saveConfig();
this.shopName = ChatColor.translateAlternateColorCodes('&', getConfig().getString("name"));
getLogger().info("Enabled!");
}
 
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args)
{
if ((cmd.getName().equalsIgnoreCase("shop")) && (sender.hasPermission("guiseller.use"))) {
if ((sender instanceof Player))
{
Player p = (Player)sender;
createSellerInv(p);
}
else
{
sender.sendMessage(ChatColor.BLUE + "You must be in-game to use this plugin!");
}
}
if ((cmd.getName().equalsIgnoreCase("reloadshop")) && (sender.hasPermission("guiseller.admin")))
{
reloadConfig();
this.shopName = ChatColor.translateAlternateColorCodes('&', getConfig().getString("name"));
Player p = (Player) sender;
p.sendMessage(prefix + "ExternoxShop has been reloaded!");
}
return false;
}
 
private void createSellerInv(Player p)
{
Inventory inv = Bukkit.createInventory(p, 27, this.shopName);
this.ist = new ItemStack(Material.BOOK, 1);
ItemMeta meta = this.ist.getItemMeta();
meta.setDisplayName(ChatColor.RED + "Need Help?");
List<String> loreList = new ArrayList<String>();
loreList.add(" ");
loreList.add(ChatColor.LIGHT_PURPLE + "Drag items you want to sell into this menu!");
loreList.add(ChatColor.RED + "Warning: ALL items will be sold!");
meta.setLore(loreList);
this.ist.setItemMeta(meta);
this.ist.setAmount(0);
inv.addItem(new ItemStack[] { this.ist });
p.openInventory(inv);
}
 
 
 
@SuppressWarnings("deprecation")
@EventHandler
public void onGUIClose(InventoryCloseEvent event)
{
if (event.getInventory().getName().equalsIgnoreCase(this.shopName))
{
 
event.getInventory().removeItem(new ItemStack[] { this.ist });
Player p = (Player)event.getPlayer();
int sold = 0;
int broke = 0;
int soldnothing = 0;
 
for(ItemStack item : event.getInventory().getContents())
{
if(item != null){
p.sendMessage("there was nothing in the inventory");
soldnothing = 1;
}
}
 
for (int i = 0; i < 27; i++){
ItemStack is = event.getInventory().getItem(i);
if ((is != null) && (getConfig().getInt("prices." + is.getType().name()) != 0) && (is.getAmount() != 0)) {
if (is.getDurability() == is.getType().getMaxDurability()) {
sold += getConfig().getInt("prices." + is.getType().name()) * is.getAmount();
} else {
broke = 1;
p.sendMessage(is.getType().name() + " item is not at full durability");
p.getInventory().addItem(is);
p.updateInventory();
}
} else {
if(is != null){
if(getConfig().getInt("prices." + is.getType().name()) == 0){
p.sendMessage(is.getType().name() + " item has no price");
p.getInventory().addItem(is);
p.updateInventory();
}
}
}
 
 
}
 
 
if(soldnothing == 0){
if(broke == 0) {
if (sold != 0){
p.sendMessage(prefix + ChatColor.GOLD + "Thank you! Your items sold for " + ChatColor.GREEN + "$" + sold);
 
sold = 0;
broke = 0;
soldnothing = 0;
 
if (this.vault.hasAccount(p.getName()))
{
this.vault.depositPlayer(p.getName(), sold);
}
else
{
this.vault.createPlayerAccount(p.getName());
this.vault.depositPlayer(p.getName(), sold);
}
} else {
p.sendMessage(prefix + ChatColor.RED + "You can not sell those items!");
}
} else {
p.sendMessage(prefix + "You put in some items that weren't fully repaired, so they have been returned.");
}
} else {
p.sendMessage(prefix + "You did not put in any items to sell!");
}
 
 
}
}
 
 
public boolean setupEconomy()
{
if (!this.vaultLoaded)
{
this.vaultLoaded = true;
if (getServer().getPluginManager().getPlugin("Vault") != null)
{
RegisteredServiceProvider<Economy> rsp = getServer().getServicesManager().getRegistration(Economy.class);
if (rsp != null) {
this.vault = ((Economy)rsp.getProvider());
}
}
}
return this.vault != null;
}
}

 

I must say your code is very unreadable, because there are no spaces or tabs.

I see one weird thing in your code, from line 112 to 118

2. for(ItemStack item : event.getInventory().getContents())
3. {
4. if(item != null){
5. p.sendMessage("there was nothing in the inventory");
6. soldnothing = 1;
7. }
8. }

Are you trying to check if the inventory is empty?
Then it should be something like this:

Code:java

boolean isEmpty = true;
for (ItemStack item : event.getInventory().getContents()) {
    if (item != null) {
        isEmpty = false;
        break;// break out of this for-loop, we see that it's not empty
    }
}
if (isEmpty) {
    p.sendMessage("there was nothing in the inventory");
    soldnothing = 1;
} 

 

That has to do with the syntax box, it does not support tabs and so it removes all of the spacing. It isn't his fault

 

Can you possibly release this plugin to the public? I'd love to have this...