[UNSOLVED] Snow Ball Slowdown

Hi im trying to get a SnowBall Slowdown plugin.... Here's my code



@EventHandler
public void onProjectileHit(EntityDamageByEntityEvent e) {
if (!(e.getEntity() instanceof Snowball)) return;
Projectile p = (Projectile) e.getEntity();
Snowball s = (Snowball) p;
s.getWorld().createExplosion(s.getLocation(), 0);
for (Entity en : s.getNearbyEntities(3, 3, 3)) {
if (en instanceof Player) {
Player pl = (Player) en;
if (!(pl == ((Projectile) e.getEntity()).getShooter())) pl.addPotionEffect(new PotionEffect(PotionEffectType.SLOW, 400, 0));

}
}
}

}


.getShooter())) has a line through it, it says "getShooter() is depreciated" what do i do? please help!

what do i do

 

It always is. It's ok it should still work. If there are errors put in a stack trace so we can see.

 

I fixed thaT... I dont get console errors but it doesnt slow me or mobs down when i hit them with it...

 

Dont use space in your name, use something like - or _ instead

 

that doesnt matter.. i dont get console errors but when i hit mobs or myself nothing happens

 

try adding debug lines

 

Whats that? im new to this

 

basically messages to print out to see if stuff working
messages like, pl.getName() or just messages to see if a if statement actually did what it was supposed to do (in this case you can just send a message like "this statement worked"!

 

you h ave the amplifier set to 0 ofcourse its not going to work. try changing this:

Code:java

 
pl.addPotionEffect(new PotionEffect(PotionEffectType.SLOW, 400, 0));
 

to this:

Code:java

 
pl.addPotionEffect(new PotionEffect(PotionEffectType.SLOW, 400, 1));
 

 

Java starts counting at 0, so the effect you are describing is Slow II.

 

incorrect again, arrays do start counting at 0 yes. but the method being used is written by the bukkit team and has nothind to do with how java counts. you "may" be correct but your reasoning behind it is wrong.

 

It does start at 0 because the third value is an amplifier. So you sir, are wrong.

 

thecrystalflame you realize bukkit is an api for java? they are the same syntax-wise..

 

First of all, this will be called when a snowball hits an entity. If you want when a snowball hits the ground, use ProjectileHitEvent. Not sure which you're going far.

Second, EntityDamageByEntityEvent#getEntity() will return the entity that is damaged. If you want the damager, it's EntityDamageByEntityEvent#getDamager().

Third, it's deprecated because it was replaced by a new system. Use ProjectileSource.

Also, use code tags.

 

of course i reallise this, but a method from the api only starts at 0 if the programmer who wrote the method set it like so. the variable amplifier is an integer meaning its not set in stone if the program counts it from 0 or not.

 

Code:java

    @EventHandler
    public void onPlayerDamageByPlayer(EntityDamageByEntityEvent event) {
        Entity damager = event.getDamager();
        if (damager instanceof Snowball) {
            Entity entity = event.getEntity();
            if (entity instanceof LivingEntity) {
                LivingEntity damaged = (LivingEntity) entity;
                PotionEffect potionEffect = new PotionEffect(PotionEffectType.SLOW, 60, 1);
                potionEffect.apply(damaged);
            }
 
 
        }
    }

this code works

 

XxZHALO13Xx
Did you register the Listener using:
Bukkit.getPluginManager().registerEvents(Listener, Plugin) ?

 

yes of course, this has nothing to do with syntax though. i can make a method that starts counting at 1 very easily in java. its not limited to it. yes arrays start counting at 0, that does not mean to say that 3rd party methods are limited to starting any type of count from 0. considering amplifier is an int nand does not call from any type of array.

go on then, tell me why a value named amplifier HAS to start counting at 0. dont tell me this java starts with 0 logic because that has nothing to do with this. yes i was wrong in my previus post and amplifier does start at 0. but tell me what makes it impossible that it could of started at 1?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Everybody is expected to start at zero. And here is why.

 

that explains it very well thank you.
Expected is very different to Deffinate

 

If you had to guess what it was, your guess should've been that it started at zero.

 

How would i make it to where when the snowball hits the ground, it explodes, has particles, then disapears?

 

XxZHALO13Xx

Code:java

public void onHit(ProjectileHitEvent event) {
if (event.getEntity() instanceof Snowball) {
event.getEnttity().getWorld().createExplosion(event.getEntity().getLocation(), 4.0)
}
}

that is the explosion i dont know about the particles

 

Heres The Code i have... It doesnt work...
package me.xxzhalo13xx.GreandePlugin;

import org.bukkit.Bukkit;
import org.bukkit.entity.*;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.EntityDamageByEntityEvent;
import org.bukkit.event.entity.ProjectileHitEvent;
import org.bukkit.plugin.Plugin;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.potion.PotionEffect;
import org.bukkit.potion.PotionEffectType;

import javax.xml.bind.Marshaller;

public class Core extends JavaPlugin implements Listener {




public void onHit(ProjectileHitEvent event) {
if (event.getEntity() instanceof Snowball) {
event.getEntity().getWorld().createExplosion(event.getEntity().getLocation(), (float) 4.0);
}
}








@EventHandler
public void onPlayerDamageByPlayer(EntityDamageByEntityEvent event) {
Entity damager = event.getDamager();
if (damager instanceof Snowball) {
Entity entity = event.getEntity();
if (entity instanceof LivingEntity) {
LivingEntity damaged = (LivingEntity) entity;
PotionEffect potionEffect = new PotionEffect(PotionEffectType.SLOW, 5, 2);
potionEffect.apply(damaged);
}


}
}
}

 

XxZHALO13Xx you need to put the @eventhandler above the explosion code also

 

The Slowdown part still doesnt work though

 

XxZHALO13Xx I literally copie and pasted that part from my code and it works. Put the whole class file in the code option this time and tell me which lines have errors

 

Code:

package me.xxzhalo13xx.GreandePlugin;
 
import org.bukkit.ChatColor;
import org.bukkit.entity.Entity;
import org.bukkit.entity.LivingEntity;
import org.bukkit.entity.Snowball;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.EntityDamageByEntityEvent;
import org.bukkit.event.entity.ProjectileHitEvent;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.potion.PotionEffect;
import org.bukkit.potion.PotionEffectType;
 
public class Core extends JavaPlugin implements Listener {
 
 
public void onEnable(){
    getLogger().info("Plugin Enabled");
}
 
    @EventHandler
    public void onHit(ProjectileHitEvent event) {
        if (event.getEntity() instanceof Snowball) {
            event.getEntity().getWorld().createExplosion(event.getEntity().getLocation(), (float) 4.0);
        }
    }
 
 
 
 
 
 
 
 
    @EventHandler
    public void onPlayerDamageByPlayer(EntityDamageByEntityEvent event) {
        Entity damager = event.getDamager();
        if (damager instanceof Snowball) {
            Entity entity = event.getEntity();
            if (entity instanceof LivingEntity) {
                LivingEntity damaged = (LivingEntity) entity;
                PotionEffect potionEffect = new PotionEffect(PotionEffectType.SLOW, 5, 2);
                potionEffect.apply(damaged);
            }
 
 
        }
    }
}

Plugin.yml
name: Snow Ball Slowdown
author: XxZHALO13XX
version: 1.0
main: me.xxzhalo13xx.GreandePlugin.Core

there... onHit is gray and says its never used

onPlayerDamageByPlayer is also gray and says its never used...

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

XxZHALO13Xx So nice of your IDE to be able to tell the future so far that it even knows third-parties will never touch those 2 methods. And unused would hardly be an error, now, would it? To repeat the advice already offered:

Try adding debug lines.

 

i forgot to register the listener XD... it works now... i put all my modues in one project in intellij... Only one runs.. why?