Solved Trying to add a delay to spawn firework. Need Help Please!

Okay so i am trying to add a few second delay when a player moves because when the player moves it spawns constantly as seen here:


I want to add a 5 second delay before each spawn but keep getting this error
Error Log:

Show Spoiler Hide Spoiler

2014-02-13 11:52:58 AM [SEVERE] Could not pass event PlayerMoveEvent to ParticlePack v1.0
2014-02-13 11:52:58 AM org.bukkit.event.EventException
2014-02-13 11:52:58 AMat org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:320) ~[craftbukkit.jar:git-Bukkit-1.7.2-R0.2-36-g9f75167-b3005jnks]
2014-02-13 11:52:58 AMat org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[craftbukkit.jar:git-Bukkit-1.7.2-R0.2-36-g9f75167-b3005jnks]
2014-02-13 11:52:58 AMat org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:481) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-36-g9f75167-b3005jnks]
2014-02-13 11:52:58 AMat org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:466) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-36-g9f75167-b3005jnks]
2014-02-13 11:52:58 AMat net.minecraft.server.v1_7_R1.PlayerConnection.a(PlayerConnection.java:234) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-36-g9f75167-b3005jnks]
2014-02-13 11:52:58 AMat net.minecraft.server.v1_7_R1.PacketPlayInFlying.a(SourceFile:137) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-36-g9f75167-b3005jnks]
2014-02-13 11:52:58 AMat net.minecraft.server.v1_7_R1.PacketPlayInPosition.handle(SourceFile:63) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-36-g9f75167-b3005jnks]
2014-02-13 11:52:58 AMat net.minecraft.server.v1_7_R1.NetworkManager.a(NetworkManager.java:146) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-36-g9f75167-b3005jnks]
2014-02-13 11:52:58 AMat net.minecraft.server.v1_7_R1.ServerConnection.c(SourceFile:134) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-36-g9f75167-b3005jnks]
2014-02-13 11:52:58 AMat net.minecraft.server.v1_7_R1.MinecraftServer.u(MinecraftServer.java:655) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-36-g9f75167-b3005jnks]
2014-02-13 11:52:58 AMat net.minecraft.server.v1_7_R1.DedicatedServer.u(DedicatedServer.java:250) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-36-g9f75167-b3005jnks]
2014-02-13 11:52:58 AMat net.minecraft.server.v1_7_R1.MinecraftServer.t(MinecraftServer.java:545) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-36-g9f75167-b3005jnks]
2014-02-13 11:52:58 AMat net.minecraft.server.v1_7_R1.MinecraftServer.run(MinecraftServer.java:457) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-36-g9f75167-b3005jnks]
2014-02-13 11:52:58 AMat net.minecraft.server.v1_7_R1.ThreadServerApplication.run(SourceFile:617) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-36-g9f75167-b3005jnks]
2014-02-13 11:52:58 AM Caused by: java.lang.IllegalArgumentException: Plugin cannot be null
2014-02-13 11:52:58 AMat org.apache.commons.lang.Validate.notNull(Validate.java:203) ~[craftbukkit.jar:git-Bukkit-1.7.2-R0.2-36-g9f75167-b3005jnks]
2014-02-13 11:52:58 AMat org.bukkit.craftbukkit.v1_7_R1.scheduler.CraftScheduler.validate(CraftScheduler.java:391) ~[craftbukkit.jar:git-Bukkit-1.7.2-R0.2-36-g9f75167-b3005jnks]
2014-02-13 11:52:58 AMat org.bukkit.craftbukkit.v1_7_R1.scheduler.CraftScheduler.runTaskTimer(CraftScheduler.java:120) ~[craftbukkit.jar:git-Bukkit-1.7.2-R0.2-36-g9f75167-b3005jnks]
2014-02-13 11:52:58 AMat org.bukkit.craftbukkit.v1_7_R1.scheduler.CraftScheduler.scheduleSyncRepeatingTask(CraftScheduler.java:116) ~[craftbukkit.jar:git-Bukkit-1.7.2-R0.2-36-g9f75167-b3005jnks]
2014-02-13 11:52:58 AMat org.bukkit.craftbukkit.v1_7_R1.scheduler.CraftScheduler.scheduleSyncDelayedTask(CraftScheduler.java:100) ~[craftbukkit.jar:git-Bukkit-1.7.2-R0.2-36-g9f75167-b3005jnks]
2014-02-13 11:52:58 AMat me.McKiller5252.particlepack.allparticles.FireworkParticle.preformEffect(FireworkParticle.java:22) ~[?:?]
2014-02-13 11:52:58 AMat me.McKiller5252.particlepack.listener.ParticlePackListener.playerMove(ParticlePackListener.java:25) ~[?:?]
2014-02-13 11:52:58 AMat sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.7.0_45]
2014-02-13 11:52:58 AMat sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.7.0_45]
2014-02-13 11:52:58 AMat sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.7.0_45]
2014-02-13 11:52:58 AMat java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.7.0_45]
2014-02-13 11:52:58 AMat org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:318) ~[craftbukkit.jar:git-Bukkit-1.7.2-R0.2-36-g9f75167-b3005jnks]
2014-02-13 11:52:58 AM... 13 more

Here is the current code for PlayerMove:

Code:java

@EventHandler
public void playerMove(PlayerMoveEvent event)
{
Player player = event.getPlayer();
if (!blockChange(event))
return;
if (plugin.getPlayerParticle(player) != null)
{
Particle par = plugin.getPlayerParticle(player);
par.preformEffect(player);
}
}

and here is the firework:

Code:java

 public void preformEffect(final Player player)
{
Bukkit.getScheduler().scheduleSyncDelayedTask(plugin, new Runnable(){
@Override
public void run() {
Location loc = player.getLocation().subtract(0, 0.6F, 0);
RandomFireworks.getManager().launchRandomFirework(loc);
}
},100L);
}

RandomFirework:

Code:java

private static RandomFireworks fireWorks = new RandomFireworks();
 
public static RandomFireworks getManager(){
return fireWorks;
}
ArrayList<Color> colors = new ArrayList<Color>();
ArrayList<FireworkEffect.Type> types = new ArrayList<FireworkEffect.Type>();
 
 
public void addColors(){
colors.add(Color.WHITE);
colors.add(Color.PURPLE);
colors.add(Color.RED);
colors.add(Color.GREEN);
colors.add(Color.AQUA);
colors.add(Color.BLUE);
colors.add(Color.FUCHSIA);
colors.add(Color.GRAY);
colors.add(Color.LIME);
colors.add(Color.MAROON);
colors.add(Color.YELLOW);
colors.add(Color.SILVER);
colors.add(Color.TEAL);
colors.add(Color.ORANGE);
colors.add(Color.OLIVE);
colors.add(Color.NAVY);
colors.add(Color.BLACK);
}
public void addTypes(){
types.add(FireworkEffect.Type.BURST);
types.add(FireworkEffect.Type.BALL);
types.add(FireworkEffect.Type.BALL_LARGE);
types.add(FireworkEffect.Type.CREEPER);
types.add(FireworkEffect.Type.STAR);
}
public FireworkEffect.Type getRandomType(){
int size = types.size();
Random ran = new Random();
FireworkEffect.Type theType = types.get(ran.nextInt(size));
return theType;
}
public Color getRandomColor(){
int size = colors.size();
Random ran = new Random();
Color color = colors.get(ran.nextInt(size));return color;
}
 
public void launchRandomFirework(Location loc){
Firework fw = loc.getWorld().spawn(loc, Firework.class);
FireworkMeta fm = fw.getFireworkMeta();
fm.setPower(1);
fm.addEffects(FireworkEffect.builder().with(getRandomType()).withColor(getRandomColor()).build());
fw.setFireworkMeta(fm);
}
}

Is there are way to add something like that to my code?

 

McKiller5252
For me it seems like you forgot to call new FireworkParticle(this); in your onEnable() void (if you're using that constructor)

 

Accually i have FireWorkParticle in onEnable but i did it like this

Code:java

 
public void onEnable() {
loadParticles(); 
}

to new constructor

Code:java

private void loadParticles()
    {
        particles.add(new FireworkParticle());
 
    }

 

McKiller5252
Ok but you never defined the plugin variable in FireworkParticles since the error is basicly saying that plugin = null so you forgot to add the plugin instance to add to your constructor. Or if not please show me where you defined the plugin variable

 

Code:java

public class ParticlePackListener implements Listener {
 
    ParticlePack plugin = ParticlePack.Instance();
 
    @EventHandler
    public void playerMove(PlayerMoveEvent event)
    {
        Player player = event.getPlayer();
        if (!blockChange(event))
            return;
        if (plugin.getPlayerParticle(player) != null)
        {
            Particle par = plugin.getPlayerParticle(player);
            par.preformEffect(player);
        }
    }

This is in main class:

Code:java

 
private static ParticlePack instance;
 
public void onEnable(){
instance = this;
try
{
getLogger().info("ParticlePack Enabled! Enjoy the particles :D");
 
cfg = new PPConfig(this);
cfg.init();
 
ppgui = new ParticlePackGUI(this);
 
RandomFireworks.getManager().addColors();
RandomFireworks.getManager().addTypes();
 
registerEvents();
loadParticles();
 
} 
catch (IOException | InstantiationException | IllegalAccessException | InvalidConfigurationException e) 
{
            e.printStackTrace();
            getServer().getPluginManager().disablePlugin(this);
        }
 
this.getCommand("particlepack").setExecutor(new CommandHandler());
 
}
 
 
public static ParticlePack Instance(){
        return instance;
    }

 

I see. Not the most fanciest way to do it, but at least it works . Well, you're still getting exactly the same error? Cause it's definitely leading to a not defined plugin variable... Also I'm not sure if it would change anything, but try changing new Runnable() to new BukkitRunnable() .

 

It dose work with BukkitRunnable but when i move it keeps spawning a firework but i want it to have small breaks before spawing another 1 here is a example : 5 sec -----> a fireworks spawns -----> 5 sec ------> a firework spawns

 

McKiller5252
Then you'd have to change some things. The way I'd use is running a TaskTimer in your onEnable void with a 1 sec Interval and store the Playername in a HashMap with the cooldown time and decrease the colldown in the HashMap via the TaskTimer every second and when it hits 0 remove the Player from the Map. How to handle that in the MoveEvent should be clear.

 

mrCookieSlime
Could you give me a example of a TaskTime, I've seen them before but didn't get what they were for.

 

McKiller5252
just do Bukkit.getScheduler().runTaskTimer(plugin, new BukkitRunnable(), 0L, 20L); This will run every second. But I'm sorry I'm tired I'll be back tomorrow.

 

Okay np Good night

 

McKiller5252
Ok I'm awake now. Since you marked it as Solved, you coded the rest now?

 

No, I just marked it at solved cuz i got the runnable working because you helped me, I just need help on the task timer now