Trouble creating a GUI method.

Code:JAVA

 
 
public void inventoryAction(InventoryClickEvent clickEvent, Inventory clickedInventory, ItemStack clickedItem, Player whoClicked, Inventory inventoryToOpen) {
 
if (clickEvent == null) return;
 
if (clickedInventory == null) return;
 
if (clickedItem == null) return;
 
if (whoClicked == null) return;
 
if (inventoryToOpen == null) return;
 
if (clickEvent.getInventory() != clickedInventory) clickEvent.setCancelled(true); return;
 
if (clickEvent.getCurrentItem().getItemMeta().getDisplayName().equals(clickedItem.getItemMeta().getDisplayName())) {
 
whoClicked.openInventory(inventoryToOpen);
 
return;
 
}
 
}
 

I am trying to use the above code to quickly open an inventory depending on the clickedInventory, clickedItem, the event, and the inventory that is supposed to open. the last if statement is giving me an error, that it is "unreachable".


EDIT: Another issue I am having is Listening to the Click Event. I have the code at the bottom so that you can see. When I try to open up another inventory by using another method, It just closes the Inventory with no errors.

Code:JAVA

 
 
 
package ProjectX.Punish.Events;
 
 
 
import org.bukkit.Bukkit;
 
import org.bukkit.entity.Player;
 
import org.bukkit.event.EventHandler;
 
import org.bukkit.event.Listener;
 
import org.bukkit.event.inventory.InventoryClickEvent;
 
import org.bukkit.plugin.Plugin;
 
 
 
import ProjectX.Punish.Inventory.PunishGUI;
 
import ProjectX.Punish.Util.InventoryActions;
 
 
 
public class ClickEvent extends InventoryActions implements Listener {
 
 
 
public ClickEvent(Plugin plugin) {
 
Bukkit.getServer().getPluginManager().registerEvents(this, plugin);
 
}
 
 
@EventHandler
 
public void onInventoryClick(InventoryClickEvent ICE) {
 
Player clicker = (Player) ICE.getWhoClicked();
 
PunishGUI inv = new PunishGUI();
 
inventoryAction(ICE, inv.getMajorInv(), inv.getMajorItem(), clicker, inv.getMajorInv());
 
}
 
 
 
}
 
 
 
 
 
And the other class
 
 
 
 
package ProjectX.Punish.Util;
 
 
 
 
 
import org.bukkit.entity.Player;
 
import org.bukkit.event.inventory.InventoryClickEvent;
 
import org.bukkit.inventory.Inventory;
 
import org.bukkit.inventory.ItemStack;
 
 
 
import ProjectX.Punish.Core.Misc;
 
 
 
public class InventoryActions implements Misc {
 
 
 
 
public void inventoryAction(InventoryClickEvent clickEvent, Inventory clickedInventory, ItemStack clickedItem, Player whoClicked, Inventory inventoryToOpen) {
 
if (clickEvent == null) return;
 
if (clickedInventory == null) return;
 
if (clickedItem == null) return;
 
if (whoClicked == null) return;
 
if (inventoryToOpen == null) return;
 
if (clickEvent.getInventory().getName() != clickedInventory.getName()) { clickEvent.setCancelled(true); whoClicked.closeInventory(); return; }
 
if (clickEvent.getCurrentItem().getItemMeta().getDisplayName().equals(clickedItem.getItemMeta().getDisplayName())) { whoClicked.openInventory(inventoryToOpen); return; }
 
}
 
 
 
 
 
 
}
 
 

@Zombie_Striker & @JanTuck

 

@iCancer
That is because you forgot about encapsulation. Either remove the return or use

 

@Zombie_Striker So, if I just used a return, it would be fine to use only one line of code instead of using encapsulation??

 

Yes, if you just used return; you could.

Code:java

 
boolean trues = true;
if ( trues )
    return;
 

Normal if statements without encapsulation runs the next line but not any other.
Example

Code:java

 
boolean trues = true;
if ( trues )
    trues = false; // < This gets run if the if statement is true
    return; // < This always gets run
trues = true; // < This is unreachable
 

Code:java

 
bolean trues = true;
if ( trues ){
    trues = false; // < This gets run INSIDE of the if statement
    return; // < This gets run INSIDE of the if statement
}
trues = true; // < Now this can get reached.
 

 

Okay, thanks! Appreciate the help!