The Mesmer Plugin - NPC

Hello, I was wondering if you could help with my plugin.
I've got the basics but now I need to write some code which will spawn 2 clones which will attack your opponent while you turn invisible for a short time. This all should be triggered by left clicking.

I will make a paypal donation when the plugin is finished.

Code :

Mesmer.java

Code:java

package me.JonathanNLD.Mesmer;
 
import java.util.logging.Logger;
 
 
import org.bukkit.event.Listener;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Mesmer extends JavaPlugin {
    private static final Logger log = Logger.getLogger("Minecraft");
    public static Mesmer plugin;
 
    @Override
    public void onEnable(){
    getServer().getPluginManager().registerEvents((Listener) new MesmerListener(), this);
        log.info("The Mesmer plugin has been enabled!");
    }
 
    @Override
    public void onDisable(){
        log.info("The Mesmer plugin has been disabled!");
    }
 
}

MesmerListener.java

Code:java

package me.JonathanNLD.Mesmer;
 
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.player.PlayerInteractEvent;
 
public class MesmerListener implements Listener {
    @EventHandler
    public void onInteract(PlayerInteractEvent e){
        if(e.getAction() == Action.LEFT_CLICK_AIR || e.getAction() == Action.LEFT_CLICK_BLOCK){
        Player player = e.getPlayer();
        }
        }
    }
 

@Sessional
@xTrollxDudex

 

klofno1
Look at this https://github.com/CitizensDev/Citizens2/tree/master/src/main/java/net/citizensnpcs
I can't really help you with this one because I have absolutely no idea how this works lol...
Sessional, you know anything?

 

klofno1 NPCLib would work, but I don't think it's updated for 1.6.1/1.6.2 so you'd have to wait.

 

Is it possible to spawn 2 modified Zombies? I'd Like them to not burn at daylight

 

klofno1
On entitycombust event check if the entity is instanceof Zombie and if it is your zombie. Then, set its fire ticks to 0

 

timtower kreashenz xTrollxDudex Sessional

 

klofno1
Most of them are offline. And yes, how may I serve you?

 

Well my main goal is to spawn 2 NPCs or 2 modifies zombies with the same skin as the player has, automatically attacking the opponent and explode when killed. And no burning in the sun.

But first, spawn 2 not burning zombies and turn the spawner invisible for 2 seconds.

@xTrollxDudex

 

klofno1 xTrollxDudex
I don't know about setting skins of zombies - there is a way to modify what a player looks like through packet manipulation, but that is about as much as I know. Like I said you could send the packet for two false players through the server and really simulate them as a zombie entity, that may be easier.

For starters I'd just make it spawn zombies and set their target to someone, and try to interrupt the packet that displays the player (therefore making it invisible)

EDIT: hidePlayer(Player player)
Hides a player from this player

Player's apparently have a method that you can hide the player from another given player, you can use this to hide the player.

 

Sessional xTrollxDudex timtower

I added 2 zombies to the game if I right click but for some reason, the right click air (yes I changed it to right) only works if I hold an item.

And now I need to make those 2 zombies friendly otherwise they would attack me. Can anyone do that for me? I've got the code.

My code :

1

Code:java

package me.JonathanNLD.Mesmer;
 
import java.util.logging.Logger;
 
 
import org.bukkit.event.Listener;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Mesmer extends JavaPlugin {
    private static final Logger log = Logger.getLogger("Minecraft");
    public static Mesmer plugin;
 
    @Override
    public void onEnable(){
    getServer().getPluginManager().registerEvents((Listener) new MesmerListener(), this);
        log.info("The Mesmer plugin has been enabled!");
    }
 
    @Override
    public void onDisable(){
        log.info("The Mesmer plugin has been disabled!");
    }
 
}

Code:java

package me.JonathanNLD.Mesmer;
 
import org.bukkit.Location;
import org.bukkit.entity.Player;
import org.bukkit.entity.Zombie;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.potion.PotionEffect;
import org.bukkit.potion.PotionEffectType;
 
public class MesmerListener implements Listener {
 
    @EventHandler
    public void onInteract(PlayerInteractEvent e){
        if(e.getAction() == (Action.RIGHT_CLICK_AIR) || e.getAction() == (Action.RIGHT_CLICK_BLOCK)){
        Player player = e.getPlayer();
        player.addPotionEffect(new PotionEffect(PotionEffectType.INVISIBILITY, 40, 2));} }
        private void spawnZombie(Location spawnLocation) {
            spawnLocation.getWorld().spawn(spawnLocation, Zombie.class);
        } 
        @EventHandler
        public void onBlockRightClick(PlayerInteractEvent event) {
            if(event.getAction() == (Action.RIGHT_CLICK_BLOCK) || event.getAction() == (Action.RIGHT_CLICK_AIR)) {
                    }               
                    this.spawnZombie(event.getClickedBlock().getLocation().add(0, 1, 0));
                    this.spawnZombie(event.getClickedBlock().getLocation().add(2, 1, 0));
                }                     
    {
        }
 
        }
 

The friendly mob code :

Until now the problem is: The Zombie is a Zombie. And it will attack the player who spawned him. Because we don't like this, it's going to be changed in our spawnZombie method. Let's put the Zombie under our control, removing any default behaviors it had. It's like brain-washing (well.. bad example for a Zombie). But before we do that, we need a place to save all the zombie instances (so we can interact with them later). Add the following to our main class:

Code:java

private HashMap<Player,ControllableMob<Zombie>> zombieMap;
Add the following to our onEnable method to initialize the map:
 
    this.zombieMap = new HashMap<Player,ControllableMob<Zombie>>();
Now, let's change the spawnZombie method:
 
    private void spawnZombie(Player owner, Location spawnLocation) {
        Zombie zombie = spawnLocation.getWorld().spawn(spawnLocation, Zombie.class);
        ControllableMob<Zombie> controlledZombie = ControllableMobs.assign(zombie, true);
        this.zombieMap.put(owner, controlledZombie);
    }
As you can see, we will bind each zombie to its owner. Therefore, we have to change the spawnZombie-call in onBlockRightClick to:
 
    this.spawnZombie(event.getPlayer(), event.getClickedBlock().getLocation().add(0, 1, 0));

 

klofno1
Right clicking the air should work, I'm not quite sure. Do some printing to see if the action even fires on a right click of air with nothing - you aren't doing anything, wouldn't surprise me if the server isn't notified of a useless rightclick like that.
As for zombies, you have to over ride the update method or hook into an event (I'm not sure if one exists) and make sure any time it changes target the target CAN NOT BE the owner.

 

I've worked with spawning NPC players, but theCodeBro could help you, I've seen some of his awesome customized mobs.

 

klofno1
Well after 5 hours...

Code:java

private class NPCSpawner{
//arraylist of npcs
List<Utiliception> npcs = new ArrayList<Utiliception>();
//constructor to spawn npc
public NPCSpawner(Player p){
//location to spawn
Location l = p.getLocation()
//make an id for the npc
int id = 0
//his name
String s = p.getName();
//field for our world
WorldServer wS = ((CraftWorld) l.getWorld()).getHandle();
//create the npc entity
NPCthing t = new NPCthing(((CraftServer) Bukkit.getServer()).getServer(), wS, s, new PlayerInteractManager(wS));
//put the npc here
t.setPositionRotation(l.getX(), l.getY(), l.getZ(), l.getYaw(), l.getPitch());
//add the entity to the world
wS.addEntity(t);
//return the called npc
Utilityception u = NPCUtilities(t);
//the owner. 
u.setSpawner(p);
//add to arraylist
ncps.add(id, u)
return u;
//increase the id by 1
id++;
if(id == 3000){
is = 0
}
}
//the npc entity
private class NPCthing extends EntityPlayer{
//default constructor
public NPCthing(MinecraftServer se, World w, String s, PlayerInteractManager mng){
//arguments in constructor for EntityPlayer.class
super(se, w, s, mng);
}
}
//utility classes
private class NPCUtilities extends Utilityception{
//default constructor
public NPCUtilities(NPCthing thing){
super(thing);
}
//swing like a boss!
public void animateArmSwing() {
((WorldServer) getEntity().world).tracker.a(getEntity(), new Packet18ArmAnimation(getEntity(), 1));
}
//turn red like when damaged
public void actAsHurt() {
((WorldServer) getEntity().world).tracker.a(getEntity(), new Packet18ArmAnimation(getEntity(), 2));
}
//set item in hand
public void setItemInHand(Material m, short damage) {
((HumanEntity) getEntity().getBukkitEntity()).setItemInHand(new ItemStack(m, 1, damage));
//remove the npc
public void remove(id){
if(ncp.get(id) != null){
Utilityception ncp = ncps.get(0);
ncps.remove(id);
ncp.removeFromWorld();
}
}
private class Utilityception{
//entity declaration
Entity ent;
//owner
Player p;
//default constructor
public Utilityception(Entity ent){
this.ent = ent;
}
//get entity
public Entity getEnt(){
return ent;
}
//owner get/set
public setSpawner(Player p){
this.p = p;
}
public getSpawner(){
return p;
}
}
}

Ill get to the navigation in the morning. Or tomorrow I might be busy today. You can still use that method above except the zombie might be a bit too easy xD
The advantage of npcs are FULL control. Cons? Difficult and long to code in
Zombies-Unpredictable, but has hard coded methods for it. Sorta....

klofno1
All right, copy and paste word for word my "library" above under the listener body but inside the listener class

Code:java

public class mylistener implements Listener{
public void listenerlisten(stuff event){
//main body
}
//my code would go here
}

Then in your listener BODY put after the if check

Code:java

NPCSpawner 1 = new NPCSpawner(event.getPlayer());
NPCSpawner 2 = new NPCSpawner(event.getPlayer());
//spawns 2 npcs

How would you choose the target?

*on a side note, do some additional if statements because player interact event is fired many times, most not in combat.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

xTrollxDudex

Do I have to remover everything I have written about the zombie? And what is the body exactly?

It does not recognise ' NPCSpawner, NPCThing, Utilityception' and everything actually with NPC in fron of it

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

klofno1
The body (in your case) is public void onInteract(PlayerInteractEvent e){ and everything within that method.

Under it, you put the class I made up there(the code in the post starting with "well after 5 hours". Unless I'm missing something, if you put the my code under the body you should not have these errors.

And about removing the zombies-you can decide to use that method or mine. But if you use mine then yes, you have to remove it.

 

Read your Pm it is not working

xTrollxDudex kreashenz Sessional

Hi now I've got this but it is filled with error

Code:java

package me.JonathanNLD.Mesmer;
 
import net.minecraft.server.v1_5_R3.EntityPlayer;
import net.minecraft.server.v1_5_R3.MinecraftServer;
import net.minecraft.server.v1_5_R3.Packet18ArmAnimation;
import net.minecraft.server.v1_5_R3.PlayerInteractManager;
import net.minecraft.server.v1_5_R3.WorldServer;
 
import org.bukkit.Bukkit;
import org.bukkit.Location;
import org.bukkit.Material;
import org.bukkit.World;
import org.bukkit.craftbukkit.v1_5_R3.CraftServer;
import org.bukkit.craftbukkit.v1_5_R3.CraftWorld;
import org.bukkit.entity.Entity;
import org.bukkit.entity.HumanEntity;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.potion.PotionEffect;
import org.bukkit.potion.PotionEffectType;
 
public class MesmerListener implements Listener { 
public void listenerlisten(stuff event){
    @EventHandler
    public void onInteract(PlayerInteractEvent e){
        if(e.getAction() == (Action.RIGHT_CLICK_AIR) || e.getAction() == (Action.RIGHT_CLICK_BLOCK)){   
            NPCSpawner 1 = new NPCSpawner(event.getPlayer());
            NPCSpawner 2 = new NPCSpawner(event.getPlayer());
            Player player = e.getPlayer();
        player.addPotionEffect(new PotionEffect(PotionEffectType.INVISIBILITY, 40, 2));}
        }
 
    private class NPCSpawner{
        List<Utiliception> npcs = new ArrayList<Utiliception>();
        public NPCSpawner(Player p){
            Location l = p.getLocation()
                    int id = 0
                    String s = p.getName();
            WorldServer wS = ((CraftWorld) l.getWorld()).getHandle();
            NPCthing t = new NPCthing(((CraftServer) Bukkit.getServer()).getServer(), wS, s, new PlayerInteractManager(wS));
            t.setPositionRotation(l.getX(), l.getY(), l.getZ(), l.getYaw(), l.getPitch());
            wS.addEntity(t);
            Utilityception u = NPCUtilities(t);
            u.setSpawner(p);
            ncps.add(id, u)
            return u;
            id++;
            if(id == 3000){
            is = 0
            }
            }
        private class NPCthing extends EntityPlayer{
            public NPCthing(MinecraftServer se, World w, String s, PlayerInteractManager mng){
                super(se, w, s, mng);
            }
            }
        private class NPCUtilities extends Utilityception{
            public NPCUtilities(NPCthing thing){
                super(thing);
                }
            public void animateArmSwing() {
                ((WorldServer) getEntity().world).tracker.a(getEntity(), new Packet18ArmAnimation(getEntity(), 1));
                }
            public void actAsHurt() {
                ((WorldServer) getEntity().world).tracker.a(getEntity(), new Packet18ArmAnimation(getEntity(), 2));
                }
            public void setItemInHand(Material m, short damage) {
                ((HumanEntity) getEntity().getBukkitEntity()).setItemInHand(new ItemStack(m, 1, damage));
                public void remove(id){
                    if(ncp.get(id) != null){
                    Utilityception ncp = ncps.get(0);
                    ncps.remove(id);
                    ncp.removeFromWorld();
                    }
                    }
                    private class Utilityception{
                        Entity ent;
                        Player p;
                        public Utilityception(Entity ent){
                            this.ent = ent;
                            }
                        public Entity getEnt(){
                            return ent;
                            }
                        public setSpawner(Player p){
                            this.p = p;
                            }
                            public getSpawner(){
                            return p;
                            }
                            }
                            }
        }
 
        }
    }
 
 
            {
            }
 
}
 
 
 

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

klofno1 What are you trying to do.. You've got like.. 10+ methods in a method.

 

klofno1
If I were you I would avoid inner classes. Also, embedded methods don't work. Fix your braces, they don't match up where they need to be.

 

Sessional kreashenz
Thank you but now you have told me what is wrong but not how to fix it and what is right

 

klofno1 Sessional kreashenz
Sorry about the mess I was creating this from 12:00 pm to 5 on my ipod touch lol so tired.

 

klofno1
You don't have closing braces on your first method, because of this the WHOLE entire file is formatted wrong and will not compile. Go through and make sure that for every opening brace you have a closing one, and do try to get it in the right spot...

EDIT: I take that back - it's just formatted very poorly, missed a few here and there. Lemme look closer...

first things first: take out the inner classes - all those private classes inside the public one and move them to a separate file - it will make it easier to read and diagnose the problem. Repost all the files and even a few errors would be nice to figure out what is wrong.

 

I have decided to take a step back because NPCs are way too advanced for a beginner. I'll start with zombie clones and when I am more advanced I well edit the plugin to max functionality. What I am now trying to do is :

1. Make zombies friendly to the spawner
2. Stop zombies from burning in the sun
3. spawning/invisibilty delay (once every 10 seconds)
(4). let zombies attack other hostile creatures (for PvE battles)

Do you know how to do that? or one of them
Ill place the code in a sec!

Edit :

The source code
MAIN (Main.java)

Code:java

package me.JonathanNLD.GuildWars2;
 
import java.util.logging.Logger;
import org.bukkit.event.Listener;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin {
private static final Logger log = Logger.getLogger("Minecraft");
public static Main plugin;
 
public void onEnable(){
getServer().getPluginManager().registerEvents((Listener) new GuildWars2Listener(), this);
log.info("The Guild Wars 2 plugin has been enabled!");
}
 
public void onDisable(){
log.info("The Guild Wars 2 plugin has been disabled!");
}
}

LISTENER (GuildWars2Listener.java)

Code:java

package me.JonathanNLD.GuildWars2;
 
import org.bukkit.Location;
import org.bukkit.Material;
import org.bukkit.entity.Player;
import org.bukkit.entity.Zombie;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.potion.PotionEffect;
import org.bukkit.potion.PotionEffectType;
 
public class GuildWars2Listener implements Listener {
private void spawnZombie(Location spawnLocation) {
spawnLocation.getWorld().spawn(spawnLocation, Zombie.class);
}
 
@EventHandler
public void onInteract(PlayerInteractEvent e){
if(e.getPlayer().getItemInHand().getType()==Material.IRON_SWORD)
if(e.getAction() == (Action.RIGHT_CLICK_BLOCK)){
Player player = e.getPlayer();
this.spawnZombie(e.getClickedBlock().getLocation().add(0, 3, 0));
this.spawnZombie(e.getClickedBlock().getLocation().add(2, 3, 0));
player.sendMessage("You vanished and left behind a clone!");
player.addPotionEffect(new PotionEffect(PotionEffectType.INVISIBILITY, 40, 2));}
{
}
 
}
}

@xTrollxDudex

 

klofno1
That did waste some time...
1. you have to have a specified target somehow.

Code:java

Zombie zombie = (Zombie) player.getWorld.spawnEntity(player.getLocation(), EntityType.ZOMBIE);
Entity e = (Entity) zombie;
 
List<Entity> entities = e.getNearbyEntities(16, 16, 16);
entities.remove(player);
 
Navigation nav = ((EntityInsentient)((CraftEntity) e).getHandle()).getNavigation();
Entity target = entities.get(0);
Bukkit.getScheduler().scheduleSyncDelayedTask(plugin, new Runnable(){
 
@Override
public void run(){
 
if(target.isAlive() == true){
Location loc = target.getLocation();
nav.a(loc.getX(), loc.getY(), loc.getZ(), 0.3f);
}else if(target.isAlive() == false){
this.cancel();
}
}, 0L, 1L);

2. Add a listener for entitycombust event and set fireticks to 0 if it is a zombie/is the zombie in the code
3: I don't get this one
4. The code above allows this!

Sessional wait are lines 5-9 calculated when you call them or are they auto updated?

 

xTrollxDudex No you did not waste your time, I will be using it but in the future for my plugin without a doubt. First I need to learn the basic, then the more advanced stuff like you already know .

Btw, could you tell me + explanation where to add this code?

xTrollxDudex And explanation for 3 = I can turn myself invisible and spawn clones instantly, so I need some kind of delay which stops the Mesmer from casting that spell instantly. A 10 second delay.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

klofno1
You put the code where you want to spawn the zombie. This can be oncommand or the original player interact event(line 24 of the listener).

Code:java

Bukkit.getScheduler().scheduleSyncDelayedTask(plugin, new Runnable(){
 
@Override
public void run(){
//what you want delayed goes here
}
 
//delay in ticks. Each second is 20 ticks so 10 seconds is 20*10 or 200
}, 200L);

EDIT: don't forget to declare the plugin variable at the top of the listener for the delayed task to work

Code:java

Main plugin;
public GuildWars2Listener(Main plugin){
this.plugin = plugin;
}

 

xTrollxDudex I've got some errors!
No autofixes available, the ones which were available have already been used!

 

klofno1
Awesome! A screenshot
1. Rename it. Change from e to entity it won't interfere with e as in event
2. Import that. It's java.util.ArrayList
3. Import that. It's org.bukkit.v1_6_R1.craftbukkit.CraftEntity and org.bukkit.v1_6_R1.craftbukkit.CraftInsentient unless you still are building against 1_5_R3
4. missing brace. Add one more in between the line with 0L, 1L and the brace after this.cancel();
5. Remove the middle brace. There are 3 of them at the end

 

xTrollxDudex
1. Add extra }
2. remove }

if I touch one of those brackets the 'if.target is alive == etc freaks out.