Solved "The Magic Clock" - Player visibility working but wut?

Hey guys. I'm currently coding a lobby plugin for my friends minigame server, just a simple one just what every other minigame server is using and I'm having some trouble setting up "The Magic Clock" It works fine but the message it sents will be the same as how many players there's only. Here's aan example

Example: 1 player online = 1 message to the player if he uses the clock
2 players online = 2 messages to the player if he uses the clock
The message is sent to the person using the clock and he's the only person who's getting the message, so that's working fine

Please help me (sry I'm bad at explaining stuff)

Code

Code:

    ArrayList<String> players = new ArrayList<String>();
   
    @EventHandler
    public void OnJoin(PlayerJoinEvent event) {
        Player player = event.getPlayer();
        players.add(player.getName());
    } 
   
   
    @EventHandler
    public void onPlayerClickEvent(PlayerInteractEvent event){
    Player sender = event.getPlayer();
    if(event.getAction().equals(Action.RIGHT_CLICK_BLOCK) || event.getAction().equals(Action.RIGHT_CLICK_AIR)){
    if(event.getPlayer().getItemInHand().getType().equals(Material.WATCH)){
    if(!this.players.contains(event.getPlayer().getName())){
    for(Player p : this.getServer().getOnlinePlayers()){
    event.getPlayer().hidePlayer(p);
    sender.sendMessage(ChatColor.YELLOW + "You have toggled player visibility!");
    }
    event.getPlayer().playSound(event.getPlayer().getLocation(), Sound.BURP, 6F, 1F);
    this.players.add(event.getPlayer().getName());
    }else{
    for(Player p : this.getServer().getOnlinePlayers()){
    event.getPlayer().showPlayer(p);
    sender.sendMessage(ChatColor.YELLOW + "Players are now visible again!");
    }
    event.getPlayer().playSound(event.getPlayer().getLocation(), Sound.BURP, 6F, 1F);
    this.players.remove(event.getPlayer().getName());
    }
    }
    }
    }

 

Krotass
This is what I did for my 'magic clock'. I had the some error as you but I somehow fixed it.

Code:java

@EventHandler
    public void onPlayerClockUseEvent(PlayerInteractEvent event){
        Player player = event.getPlayer();
        ItemStack clock = new ItemStack(Material.WATCH, 1);
        ItemMeta clockMeta = (ItemMeta) clock.getItemMeta();
        clockMeta.setDisplayName(ChatColor.GOLD + "Visibility");
        clock.setItemMeta(clockMeta);
        if(player.getItemInHand().equals(clock)){
            for(Player targetPlayers : Bukkit.getOnlinePlayers()){
                if(player.canSee(targetPlayers)){
                    player.hidePlayer(targetPlayers);
                    player.sendMessage(ChatColor.GOLD + "Player visibility has been toggled to: ON");
                }else if(!player.canSee(targetPlayers)){
                    player.showPlayer(targetPlayers);
                    player.sendMessage(ChatColor.GOLD + "Player visibility has been toggled to: OFF");
                }
            }
        }
    }

 

SourceForums How did you even make this code work?

 

Krotass
What do you mean? If everything's all fixed, remember to mark the thread as solved.

 

Try indenting your hidePlayer under for(Player p: ...).

 

SourceForums It's not fixed. I can't make your code work

 

just put the sendmessage out of the loop on your original code.
there's no wonder you send multiple messages- you are sending them inside a loop...

 

You are doing following

• Iteratete through all online players
• For every online player hide them AND send the message that he toggled it

What you want to do is

• Iterate through all online players
• hide them
• OUTSIDE the for-loop send him the message that he toggled it

 

L33m4n123 PluginMaker Thanks for helping me

 

Also, Krotass to fix a lot of bugs, under the "public void onPlayerClockUseEvent" you would want to say,

Code:java

Action a = event.getAction();
 
if(a == Action.PHYSICAL || event.getItem() == null || event.getItem().getType() == Material.AIR) return;

That will basically make sure if the person is going on a pressure plate and is holding a clock it just returns nothing & if the item is == null or == air it returns .