Solved String is returning as null

Before I being, no, it's not an NPE, just "null".

Okay, so. I'm creating a zone plugin, and when I enter a zone, it's supposed to send a message saying you have entered zone.getName().

Here's where that happens ^

Code:java

 
public class PlayerMoveListener implements Listener{
 
@EventHandler
public void onMove(PlayerMoveEvent event){
Player player = event.getPlayer();
Location to = event.getTo();
Location from = event.getFrom();
List<Zone> zones = null;
 
try{
zones = sZones.getZones();
}catch(SQLException ex){
ex.printStackTrace();
}
for(Zone zone: zones){
if(zone.contains(to) && zone.contains(from))return;
 
if(zone.contains(from) && !zone.contains(to)){ //Player exits a zone
player.sendMessage(ChatColor.BLUE + "[sZones] " + ChatColor.RED + zone.getExitMessage());
}
 
if(zone.contains(to) && !zone.contains(from)){ //Player enters a zone
ZonePlayer zp = null;
try{
zp = sZones.getZonePlayer(player.getName(), zone.getName());
}catch(SQLException ex){
ex.printStackTrace();
}
if(zp.getRank().equalsIgnoreCase("banned")){
event.setCancelled(true);
player.sendMessage(ChatColor.BLUE + "[sZones] " + ChatColor.RED + "You are not allowed in " + zone.getName());
}else{
player.sendMessage(ChatColor.BLUE + "[sZones] " + ChatColor.RED + zone.getEnterMessage()); //Right here, but in game is says [sZones] null
}
}
}
 
}
}

here is sZones.getZones()

Code:java

 
public static List<Zone> getZones() throws SQLException{
Statement stm = null;
String query = "SELECT * FROM " + TABLE_ZONES + " WHERE 1";
List<Zone> zones = new ArrayList<Zone>();
try{
stm = ConnectionManager.getConnection().createStatement();
ResultSet rs = stm.executeQuery(query);
while(rs.next()){ //Wow this method is gonna be huge :F
//TODO: Shorten this
int id = rs.getInt("id");
String name = rs.getString("name");
int x1 = rs.getInt("x1");
int z1 = rs.getInt("z1");
int x2 = rs.getInt("x2");
int z2 = rs.getInt("z2");
String world = rs.getString("world");
boolean freeBuild = rs.getBoolean("freeBuild");
/*
* Might have to do a workaround for the booleans
*/
boolean pvp = rs.getBoolean("pvp");
boolean hostile = rs.getBoolean("hostile");
boolean whiteList = rs.getBoolean("whiteList");
 
Zone zone = new Zone();
zone.setId(id);
zone.setName(name);
zone.setX1(x1);
zone.setZ1(z1);
zone.setX2(x2);
zone.setZ2(z2);
zone.setWorld(world);
zone.setFreeBuild(freeBuild);
zone.setPvp(pvp);
zone.setHostile(hostile);
zone.setWhitelisted(whiteList); //Yes I know this is very long :p
 
zones.add(zone);
}
}catch(SQLException ex){
ex.printStackTrace();
}finally{
if(stm != null) stm.close();
}
 
 
return zones;
}

Now, when I do print(sZones.getZone(name).getEnterMessage()); in onEnable()
it says "You have entered blah", but when I move into the zone, it just says null.

 

You don't provide the stack trace, not

This code makes me cringe to be quite honest, PlayerMoveEvent is called very frequently and the fact that you're making MySQL connections every time that happens to fill the zones list is insane.

Forget the null string your design needs some major rethinking if you want it to be stable and not a major drain on performance. The Zones list, why does it need to be refreshed from config whenever a player 'moves'? AFAIK, PME is called whenever the players location changes, and the location consists of World, x,y,z, pitch, and yaw- meaning even spinning in circles will call this event?

 

There is no stack trace, everything runs smoothly, it just says "null" instead of the message.

What do you mean why does the zones list need to be refreshed when a player moves?

This is my first time using regular SQL statements instead of the built in database classes in bukkit's api, so I'm a little confused on how to go about doing this.

 

You load your zones from the MySQL database on PlayerMoveEvent, why not load them into memory on enable and then update as needed...

 

^ I thought about that last night, and I did it.

I also found out why it was returning null, very obvious and stupid mistake -_-.

in getZones() i forgot these two things

Code:java

 
zone.setEnterMessage(rs.getString("enterMessage"));
zone.setExitMessage(rs.getString("exitMessage"));
 

Thanks for the help

 

Please mark as resolved