Solved Store players inventory as an item stack in config

Hey,
How can I store a players inventory with the enchantments and the item state in the config?
I tried to do it by my self but I didn't come that far...

My code:

Code:java

    public static ItemStack[] getWholeInventory(Player player) {
        player.getInventory().getContents();
        player.getInventory().getHelmet();
        player.getInventory().getChestplate();
        player.getInventory().getLeggings();
        player.getInventory().getBoots();
        return null;
      }

Thank you,

 

ItemStack is ConfigurationSerializable, that takes care of most of the work. Simply save each item in the inventory with the key of the number it's in and the value of ItemStack.serialize(). Then save the armor with just "helmet, chestplate, leggings, boots". When it's time to load them up, use config.getItemStack().

 

This thread details serializing and deserializing an entire inventory to a config file as a list.

http://forums.bukkit.org/threads/config-list-not-saving-itemstacks-saving-them-as-nulls-why.218825/

 

metalhedd
Hmm... I get it a bit but I don't see the part that he saves an inventory into the config.

metalhedd
Alright I got this now for storing the items in the config. I didn't test it but I want to have a second look to it.

Code:

Code:java

    public static ItemStack[] storeWholeInventoryInConfig(Player player, String name) {
 
        List<ItemStack> inventoryContents = new ArrayList<ItemStack>();
        List<ItemStack> armourContents = new ArrayList<ItemStack>();
 
        for (ItemStack inventory : player.getInventory().getContents())
            if ((inventory != null) && (inventory.getType() != Material.AIR)) inventoryContents.add(inventory);
        plugin.getConfig().set("Inventory." + name + ".InventoryContents", inventoryContents);
 
        for (ItemStack armour : player.getInventory().getArmorContents())
            if ((armour != null) && (armour.getType() != Material.AIR)) armourContents.add(armour);
        plugin.getConfig().set("Inventory." + name + ".ArmourContents", armourContents);
 
        plugin.saveConfig();
        return null;
      }

metalhedd
Alright I did that and I got an error in the console that says that there is an error at the line:

Code:java

plugin.getConfig().set("Inventory." + name + ".InventoryContents", inventoryContents);
 

Error:

Code:

SEVERE: null
org.bukkit.command.CommandException: Unhandled exception executing command 'test
' in plugin Teams v1.0
        at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46)
        at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:19
2)
        at org.bukkit.craftbukkit.v1_7_R1.CraftServer.dispatchCommand(CraftServe
r.java:543)
        at net.minecraft.server.v1_7_R1.PlayerConnection.handleCommand(PlayerCon
nection.java:923)
        at net.minecraft.server.v1_7_R1.PlayerConnection.a(PlayerConnection.java
:803)
        at net.minecraft.server.v1_7_R1.PacketPlayInChat.a(PacketPlayInChat.java
:28)
        at net.minecraft.server.v1_7_R1.PacketPlayInChat.handle(PacketPlayInChat
.java:47)
        at net.minecraft.server.v1_7_R1.NetworkManager.a(NetworkManager.java:146
)
        at net.minecraft.server.v1_7_R1.ServerConnection.c(SourceFile:134)
        at net.minecraft.server.v1_7_R1.MinecraftServer.u(MinecraftServer.java:6
45)
        at net.minecraft.server.v1_7_R1.DedicatedServer.u(DedicatedServer.java:2
43)
        at net.minecraft.server.v1_7_R1.MinecraftServer.t(MinecraftServer.java:5
35)
        at net.minecraft.server.v1_7_R1.MinecraftServer.run(MinecraftServer.java
:447)
        at net.minecraft.server.v1_7_R1.ThreadServerApplication.run(SourceFile:6
17)
Caused by: java.lang.NullPointerException
        at teams.main.Inventory.storeWholeInventoryInConfig(Inventory.java:53)
        at teams.commands.CopyThis.onCommand(CopyThis.java:23)
        at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44)
        ... 13 more

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

looks to me like 'name' is null.

 

metalhedd
I gave it the name "test"

 

maybe 'plugin' ? those are the only 2 variables on that line which could possibly be null, so you'd have to figure out which one it is, add some logging at the top your method to be sure.

 

metalhedd
The plugin. is necessary because this is in an other class file. But what I think I have to do is something with config list to store the itemstack in...?

 

No, everything you have there is fine, if that error message is accurate and that is really line 53 that you've pasted, then 'plugin' or 'name' is null. those are the only 2 possibilities that I see. I know that its necessary to have a reference to your plugin, I'm just saying that you probably haven't set it yet, and it's still null.

 

metalhedd
Hmm I send the whole code of my main class and my Inventory class

Inventory:

Code:java

package teams.main;
 
import java.util.ArrayList;
import java.util.List;
 
import org.bukkit.Color;
import org.bukkit.Material;
import org.bukkit.entity.Player;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
import org.bukkit.inventory.meta.LeatherArmorMeta;
 
public class Inventory {
static main plugin;
 
public Inventory(main instance){
plugin = instance;
}
 
 
public ItemStack dyeLeatherArmour(Material material, int r, int g, int b){
ItemStack armour = new ItemStack(material);
LeatherArmorMeta lam = (LeatherArmorMeta) armour.getItemMeta();
 
lam.setColor(Color.fromBGR(r,g,b));
armour.setItemMeta(lam);
 
return armour;
}
 
public ItemStack setNameLore(ItemStack material, String name, List<String> lore){
if (((material == null) || material.getType() == Material.AIR)
|| (name == null && lore == null))
return null;
 
ItemMeta im = material.getItemMeta();
if(name != null)
im.setDisplayName(name);
if(lore != null)
im.setLore(lore);
 
material.setItemMeta(im);
return material;
}
 
public static ItemStack[] storeWholeInventoryInConfig(Player player, String name) {
 
List<ItemStack> inventoryContents = new ArrayList<ItemStack>();
List<ItemStack> armourContents = new ArrayList<ItemStack>();
 
for (ItemStack inventory : player.getInventory().getContents())
if ((inventory != null) && (inventory.getType() != Material.AIR)) inventoryContents.add(inventory);
plugin.getConfig().set("Inventory." + name + ".InventoryContents", inventoryContents);
 
for (ItemStack armour : player.getInventory().getArmorContents())
if ((armour != null) && (armour.getType() != Material.AIR)) armourContents.add(armour);
plugin.getConfig().set("Inventory." + name + ".ArmourContents", armourContents);
 
player.sendMessage("You have added your inventory to the config");
plugin.saveConfig();
return null;
}
 
}
 

Main:

Code:java

package teams.main;
 
import java.util.logging.Logger;
 
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.Listener;
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
 
import teams.commands.CopyThis;
import teams.commands.assignall;
import teams.commands.check;
import teams.commands.leave;
import teams.commands.removeall;
import teams.commands.spawnset_blueTeam;
import teams.commands.spawnset_lobby;
import teams.commands.spawnset_redTeam;
 
public class main extends JavaPlugin implements Listener{
public final Logger logger = Logger.getLogger("minecraft");
public static main plugin;
 
 
public void onEnable() {
 
PluginDescriptionFile pdfFile = this.getDescription();
this.logger.info(pdfFile.getName() + " Version " + pdfFile.getVersion() + " Has Been Enabled");
PluginManager pm = this.getServer().getPluginManager();
getServer().getPluginManager().registerEvents(this, this);
getConfig().options().copyDefaults(true);
Team.clearTeams();
saveConfig();
 
// Register Events
 
// Register Commands:
getCommand("test").setExecutor(new CopyThis (this));
getCommand("assignall").setExecutor(new assignall (this));
getCommand("check").setExecutor(new check (this));
getCommand("leave").setExecutor(new leave (this));
getCommand("removeall").setExecutor(new removeall (this));
getCommand("setspawnblue").setExecutor(new spawnset_blueTeam (this));
getCommand("setspawnred").setExecutor(new spawnset_redTeam (this));
getCommand("setlobby").setExecutor(new spawnset_lobby (this));
 
// Config register
CopyThis.plugin = this;
assignall.plugin = this;
check.plugin = this;
leave.plugin = this;
removeall.plugin = this;
Teleport.plugin = this;
Inventory.plugin = this;
spawnset_blueTeam.plugin = this;
spawnset_redTeam.plugin = this;
spawnset_lobby.plugin = this;
 
}
 
public void onDisable() {
 
PluginDescriptionFile pdfFile = this.getDescription();
this.logger.info(pdfFile.getName() + " Has Been Disabled");
Team.clearTeams();
saveConfig();
 
}
 
public boolean onCommand(CommandSender sender, Command command, String commandLabel, String[] args) {
Player player = (Player)sender;
if(commandLabel.equalsIgnoreCase("savelocation")){
Teleport.storeLocationInConfig(player.getLocation(), "test", "x", "y", "z", "yaw", "pitch");
}
if(commandLabel.equalsIgnoreCase("gotolocation")){
Teleport.teleportToLocation(player, player.getWorld(), "test", "x", "y", "z", "yaw", "pitch");
}
 
return false;
}
 
}
 

Edit:
Don't mind the 2 commands in the main class it was for testing something.

 

A whole paste of the code would be great in further determining your issue. Perhaps your think you're setting it correctly and you aren't... We could identify the issue.

 

Drkmaster83
I just did a sec before you posted.

 

well, 'plugin' looks ok, but we never see the code which calls storeWholeInventoryInConfig, the problem is probably passing null in as 'name' there.

 

metalhedd
Alright I'm gonna remove the "name" and I'll say if it worked or not.

metalhedd
I got the same error as before so it seems like there is no problem with the 'name'?

Code:

Code:java

    public static ItemStack[] storeWholeInventoryInConfig(Player player) {
 
        List<ItemStack> inventoryContents = new ArrayList<ItemStack>();
        List<ItemStack> armourContents = new ArrayList<ItemStack>();
 
        for (ItemStack inventory : player.getInventory().getContents())
            if ((inventory != null) && (inventory.getType() != Material.AIR)) inventoryContents.add(inventory);
        plugin.getConfig().set("Inventory." + ".InventoryContents", inventoryContents);
 
        for (ItemStack armour : player.getInventory().getArmorContents())
            if ((armour != null) && (armour.getType() != Material.AIR)) armourContents.add(armour);
        plugin.getConfig().set("Inventory." + ".ArmourContents", armourContents);
 
        player.sendMessage("You have added your inventory to the config");
        plugin.saveConfig();
        return null;
      }

The problem is probably something stupid ._.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

paste the full stack trace and which line number it matches up with above

 

metalhedd

Line 53 is line 8 in the last post I sent.

Code:

SEVERE: null
org.bukkit.command.CommandException: Unhandled exception executing command 'test
' in plugin Teams v1.0
        at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46)
        at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:19
2)
        at org.bukkit.craftbukkit.v1_7_R1.CraftServer.dispatchCommand(CraftServe
r.java:543)
        at net.minecraft.server.v1_7_R1.PlayerConnection.handleCommand(PlayerCon
nection.java:923)
        at net.minecraft.server.v1_7_R1.PlayerConnection.a(PlayerConnection.java
:803)
        at net.minecraft.server.v1_7_R1.PacketPlayInChat.a(PacketPlayInChat.java
:28)
        at net.minecraft.server.v1_7_R1.PacketPlayInChat.handle(PacketPlayInChat
.java:47)
        at net.minecraft.server.v1_7_R1.NetworkManager.a(NetworkManager.java:146
)
        at net.minecraft.server.v1_7_R1.ServerConnection.c(SourceFile:134)
        at net.minecraft.server.v1_7_R1.MinecraftServer.u(MinecraftServer.java:6
45)
        at net.minecraft.server.v1_7_R1.DedicatedServer.u(DedicatedServer.java:2
43)
        at net.minecraft.server.v1_7_R1.MinecraftServer.t(MinecraftServer.java:5
35)
        at net.minecraft.server.v1_7_R1.MinecraftServer.run(MinecraftServer.java
:447)
        at net.minecraft.server.v1_7_R1.ThreadServerApplication.run(SourceFile:6
17)
Caused by: java.lang.NullPointerException
        at teams.main.Inventory.storeWholeInventoryInConfig(Inventory.java:53)
        at teams.commands.CopyThis.onCommand(CopyThis.java:23)
        at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44)
        ... 13 more
 
 
>

 

Hmm... well it REALLY looks like it's 'plugin' that's null then.. but I can't see why... The way you're setting it is really wierd and probably not 'good' but it looks like it's set. try adding:

Bukkit.getLogger().info("Plugin is: " + plugin);

at the very top of that method and see what it prints out

 

metalhedd
Plugin is: null

So... how to fix this?

 

I'm not sure why it's not set to be honest, something somewhere else in your code could be un-setting it, I dunno. The only way to really 'fix' it is to rewrite a bunch of code. The part where you set each classes 'plugin' property to 'this' is particularly troubling... You should be instantiating those classes, saving a reference to the instance, and calling the methods on that.

 

metalhedd
And if I add this method to my main class and look what happens?

 

It'd probably solve your immediate problem, but you've still gotta learn how to work with classes, and instances of classes, properly. Your code seems to demonstrate that you don't really understand how all of that works yet, so you'd be better off taking this opportunity to sort it out now before you get too far into your plugin and have to rewrite even more.

 

metalhedd Hmm but it is still weird because in my teleport class the plugin.getConfig etc does still work. And I've put the code in my main class and it still gives the error at the line:

Code:java

getConfig().set("Inventory." + name + ".InventoryContents", inventoryContents);

 

now it's gotta be 'name', use the logger

 

metalhedd
Nvm haha I forgot to remove plugin at another line... Stupid me... But yea this works
Now the next thing is to get the itemstack out of the config. ;o

metalhedd I have a question if I get the itemstack back out of the config does it know where the items belong in my inventory and places armour things at the armour places etc?

Sorry because of lagg I posted it twice :/ I thought it wasn't loading :3

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

metalhedd how can I get the items back out of the config and getting it back in the inventory of the player where the items belongs to be?

 

It's all in the original thread I linked to. I posted code to retrieve the list as well.

 

metalhedd
Alright I got it working now. Only there is one problem, it doesn't place the items on the exact place where they need to be when I saved my inventory to the config. Like the armour isn't on the armour places etc.

 

metalhedd
How can I do it like the items will be placed where they stood when I saved my inventory?

Code:

Code:java

    @SuppressWarnings("unchecked")
    public static ItemStack[] getWholeInventoryOutConfig(Player player, String name, Boolean clear) {
 
        List<ItemStack> InventoryContents = (List<ItemStack>) plugin.getConfig().getList("Inventory." + name + ".InventoryContents");
        List<ItemStack> ArmourContents = (List<ItemStack>) plugin.getConfig().getList("Inventory." + name + ".ArmourContents");
 
        if(plugin.getConfig().get("Inventory." + name) == null) {
            player.sendMessage("Unknown name: '" + name + "'");
            return null;
        }
 
        if(clear == true) {
            player.getInventory().clear();
            player.getInventory().setArmorContents(null);
        }
 
        for (ItemStack inventory : InventoryContents) {
        player.getInventory().addItem(inventory);
        }
 
        for (ItemStack armour : ArmourContents) {
        player.getInventory().addItem(armour);
        }
 
        return null;
    }

 

the positions aren't saved because empty slots are simply removed, you will have to store the empty slots, maybe as Material.AIR stacks. in order to retain the positions.

 

metalhedd
Any clue how to do that?