[Solved]Plugin unable to load, error with String + listener in main?

I have started working on config files lately, with my latest being the player being damaged when breaking a block.

Here is my code (the whole class) and here is the commit (the bits i added for the damage and config) of my plugin.
Fixed the missing ";" on line 57

When i break a glass block, it doesn't matter what the number is in the config (in either option), it breaks as usual, but doesn't damage the player.

When i break a thin glass (glass pane), the player is always damaged, and a full stack is dropped, not just the one.

What have i done wrong (this time, lol)?

Thanks

 

Some things I saw.

1. Don't use spaces in config keys
2. Why are you using a for loop?
3. You missed a few {'s and your indentation was wrong, I've fixed it (see below)
4. Why are you using two listeners if they do the same thing? (Except one for glass and one for thin_glass)
5. This line confuses me "if (plugin.GlassDrops.contains(event.getPlayer().getName()));"
   As far as I see this won't do anything.

Well.. Hope this helps

Code:java

  @EventHandler(priority = EventPriority.NORMAL)
  public void onBlockBreak(BlockBreakEvent event) {
    Block block = event.getBlock();
    Player player = event.getPlayer();
 
    if (block.getType() == Material.GLASS) {
      if (plugin.GlassDrops.contains(event.getPlayer().getName())) {
        for (int counter = 1; counter < 100; counter++) {
          damageChance = 1 + random.nextInt(100);
          if (damageChance <= plugin.getConfig().getInt("Glass Damage.Damage Chance")) {
            beforeBreakHealth = player.getHealth();
            playerDamage = plugin.getConfig().getInt("Glass Damage.Damage Amount");
            player.setHealth(beforeBreakHealth - playerDamage);
          }  
          block.setType(Material.AIR);
          block.getWorld().dropItemNaturally(block.getLocation(), new ItemStack(Material.GLASS, 1));
        }
      }
    }
  }
 
  @EventHandler(priority = EventPriority.NORMAL)
  public void BlockBreak(BlockBreakEvent event) {
    Block block = event.getBlock();
    Player player = event.getPlayer();
 
      if (block.getType() == Material.THIN_GLASS) {          
        for (int counter = 1; counter < 100; counter++) {
          damageChance = 1 + random.nextInt(100);
          if (damageChance <= plugin.getConfig().getInt("Glass Damage.Damage Chance")) {
            beforeBreakHealth = player.getHealth();
            playerDamage = plugin.getConfig().getInt("Glass Damage.Damage Amount");
            player.setHealth(beforeBreakHealth - playerDamage);
          }
          if (plugin.GlassDrops.contains(event.getPlayer().getName()));
          block.setType(Material.AIR);
          block.getWorld().dropItemNaturally(block.getLocation(), new ItemStack(Material.THIN_GLASS, 1));
        }
      }
    }
  }

 

dadaemon

I was told by some not to use - or _ and use spaces?!

I am still learning java, so sometimes i might put the wrong thing in

Whoops, thanks for that

It is so they can drop two separate types of glass...

That is used because i have a command toggle for the glass to be either dropped, or broken.

Thanks for your reply, will try it and get back to you.

 

you never call player.damage(int)

 

should do the same thing...
but player.damage is easier

 

Hey guys, sorry for the late reply, i re-coded most of it, but when I try to load it, I get an error (Posted Below).
Main: http://pastebin.com/d5x21kWw
Listener: http://pastebin.com/u86aQP0M
Commands: http://pastebin.com/PFBw4nz8
Error: http://pastebin.com/hKirYRCi

I have been looking it to it for a while and connot seem to figure it out! (It's probably something simple too )What have i done wrong, and how can i be fixed?
Thanks

 

You initialize your listeners before anything is loaded. Maybe that's why it's giving the error.

I usually initialize my listeners on te onEnable method after configs etc. are loaded.

Also, does your config contains the "Worlds.world4" string? Because the error says it's getting a null from that line.

Code:

Caused by: java.lang.NullPointerException
at me.ben.GlassDrops.GlassDropListener.<init>(GlassDropListener.java:26)
at me.ben.GlassDrops.GlassDrops.<init>(GlassDrops.java:18)

 

Yes, my listener are near the bottom of my onEnable so they are loaded last.

As for the config containing "Worlds.world4", it does contain it (In the main with cfg.addDefault)

 

Nope... Your listeners are initialized when the plugin initializes.

Code:

public GlassDropListener glassListener = new GlassDropListener(this);
public GlassDropsCommands commands = new GlassDropsCommands(this);

What I do is the following

Code:

public GlassDropListener glassListener;
public GlassDropsCommands commands;

and place this in the onEnable after the config is set

Code:

glassListener = new GlassDropListener(this);
commands = new GlassDropsCommands(this);

Edit: Also it is probably better to make the config available from your plugin class by using

Code:

config = this.getConfig();

and then reference that object instead of calling getConfig every time.

Edit2: Why do you save the config at the start in the onEnable?

 

Changed it, get this error

Code:

22:26:58 [SEVERE] Error occurred while enabling GlassDrops v1.4 (Is it up to dat
e?): null
java.lang.NullPointerException
        at me.ben.GlassDrops.GlassDropListener.<init>(GlassDropListener.java:25)

        at me.ben.GlassDrops.GlassDrops.onEnable(GlassDrops.java:43)
        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:230)
        at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader
.java:1057)
        at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManage
r.java:380)
        at org.bukkit.craftbukkit.CraftServer.loadPlugin(CraftServer.java:199)
        at org.bukkit.craftbukkit.CraftServer.enablePlugins(CraftServer.java:182
)
        at net.minecraft.server.MinecraftServer.t(MinecraftServer.java:357)
        at net.minecraft.server.MinecraftServer.a(MinecraftServer.java:344)
        at net.minecraft.server.MinecraftServer.init(MinecraftServer.java:175)
        at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:408)
        at net.minecraft.server.ThreadServerApplication.run(SourceFile:465)

Here is the main if you want;

Code:java

 
package me.ben.GlassDrops;
 
import java.util.ArrayList;
import java.util.logging.Logger;
 
import org.bukkit.Bukkit;
import org.bukkit.configuration.file.FileConfiguration;
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
 
public class GlassDrops extends JavaPlugin {
 
    Logger log = Logger.getLogger("Minecraft");
 
    public ArrayList<String> droptoggle = new ArrayList<String>();
 
    public GlassDropsCommands commands;
    public GlassDropListener listener;
 
 
    public void onEnable() {
 
        saveConfig();
        FileConfiguration cfg = getConfig();
        cfg.options().header("Glass Drops Config File");
        cfg.addDefault("Message.Message", "You are not allowed to drop glass in the world!");
        cfg.addDefault("Message.Color", "RED");
        cfg.addDefault("Worlds.world", "world");
        cfg.addDefault("Worlds.nether", "world_nether");
        cfg.addDefault("Worlds.world3", "world_the_end");
        cfg.addDefault("Worlds.world4", "world4");
        cfg.addDefault("Worlds.world5", "world5");
        cfg.addDefault("Glass-Damage.Damage-Chance", Integer.valueOf(1));
        cfg.addDefault("Glass-Damage.Damage-Amount", Integer.valueOf(1));
        cfg.addDefault("Glass-Drops.Drop-Chance", Integer.valueOf(100));
        cfg.addDefault("Blocks-Dropped.Glass", Boolean.valueOf(true));
        cfg.addDefault("Blocks-Dropped.Glass-Panes", Boolean.valueOf(true));
        cfg.options().copyDefaults(true);
        saveConfig();
 
        commands = new GlassDropsCommands(this);
        listener = new GlassDropListener(this);
        getCommand("gd").setExecutor(commands);
        getCommand("ngd").setExecutor(commands);
        PluginManager pm = Bukkit.getServer().getPluginManager();
        pm.registerEvents(this.commands, this);
        pm.registerEvents(this.listener, this);
        PluginDescriptionFile pdf = this.getDescription();
        log.info(pdf.getName() + " has been enabled with version " + pdf.getVersion());
    }
 
    public void onDisable() {
        PluginDescriptionFile pdf = this.getDescription();
        log.info(pdf.getName() + " has been disabled");
    }
}
 

and the error on line 25 in the listener;

Code:java

 
String world1 = plugin.getConfig().getString("Worlds.world");
 

 

Try the following for your listener:

Code:java

    private GlassDrops plugin;
    Random chance = new Random();
 
    String world1;
    String nether;
    String world3;
    String world4;
    String world5;
    String message;
    String colour;
    int damChance;
    int damAmount;
    int dropChance;
    boolean glass;
    boolean glassPanes;
 
    public GlassDropListener(GlassDrops instance) {
        plugin = instance;
 
        FileConfiguration config = plugin.getConfig();
        if(config == null) {
            System.out.print("Why is config null?");
            return;
        }
 
        world1 = config.getString("Worlds.world");
        nether = config.getString("Worlds.nether");
        world3 = config.getString("Worlds.world3");
        world4 = config.getString("Worlds.world4");
        world5 = config.getString("Worlds.world5");
        message = config.getString("Message.Message");
        colour = config.getString("Message.Colour");
        damChance = config.getInt("Glass-Damage.Damage-Chance");
        damAmount = config.getInt("Glass-Damage.Damage-Amount");
        dropChance = config.getInt("Glass-Drops.Drop-Chance");
        glass = config.getBoolean("Blocks-Dropped.Glass");
        glassPanes = config.getBoolean("Blocks-Dropped.Glass-Panes");        
    }

What does it do then?

 

dadaemon
It worked! Thanks, is it the way assigned the config Strings/int/booleans?

 

It's probably because when your initializing the listener it goes through all your global objects first. And after that it will use the constructor.

But because your referencing "plugin" while the constructor hasn't been run yet. "plugin" will be null.

Hope you understand what I try to say

Edit: The whole "config = plugin.getConfig()" is therefor not needed. But it will clean up your code a little bit Just initialize the objects inside the constructor if your referencing objects that aren't set.

 

Ahk, thanks for that.

But... (So sorry!)(Don't need to respond if you don't want to)

A) Even when the config is set to false, it still drops
B) I am always being damaged, even if damage chance= 1
C) When a block is broken, it spits out just over 1.5 blocks worth of it.

The code for when it is broken

Code:java

 
    @EventHandler(priority = EventPriority.HIGH)
    public void onBlockBreak(final BlockBreakEvent event) {
 
        Block block = event.getBlock();
        Player player = event.getPlayer();
        String playerName = event.getPlayer().getName();
        World world = event.getPlayer().getWorld();
 
        if ((world.getName().equals(world1)) || world.getName().equals(nether) || world.getName().equals(world3) || world.getName().equals(world4) || world.getName().equals(world5)) {
            if (block.getType() == Material.GLASS) {
                if (glass = true) {
                    for (int counter = 1; counter < 100; counter++) {
                        int damage = 1 + chance.nextInt(100);
                        if (damage <= damChance) {
                            player.damage(damAmount);
                        }
                        if (plugin.droptoggle.contains(playerName)) {
                            block.setType(Material.AIR);
                            block.getWorld().dropItemNaturally(block.getLocation(), new ItemStack(Material.GLASS, 1));
                        }
                    }
                }else if(glass = false){
                    return;
                }
            }
 
        }
    }
 

 

Don't reply. Don't reply! NOOOO! I've replied!

I've changed the code a little bit. I added some comment too.

Code:java

@EventHandler // You don't have to add the priority, just let Bukkit handle it
public void onBlockBreak(final BlockBreakEvent event) {
    Block block = event.getBlock();
    Player player = event.getPlayer();
    String playerName = player.getName(); // You got the player, so get the name from the player object
    World world = player.getWorld(); // You got the player, so get the world from the player object
 
    //Debug code to check if objects are loaded from config
    System.out.print("world1: " + world1);
    System.out.print("nether: " + nether);
    System.out.print("world3: " + world3);
    System.out.print("world4: " + world4);
    System.out.print("world5: " + world5);
    System.out.print("glass: " + glass);
 
    String worldName = world.getName(); // Added so the following if statement is more readable 
 
    if (worldName.equals(world1) || worldName.equals(nether) || worldName.equals(world3) || worldName.equals(world4) || worldName.equals(world5)) {
        if (block.getType() == Material.GLASS) {
            if (glass == true) { // !!!!!!! Use ==
                int damage = 1 + chance.nextInt(100);
                if (damage <= damChance) {
                    player.damage(damAmount);
                }
                if (plugin.droptoggle.contains(playerName)) {
                    block.setType(Material.AIR);
                    block.getWorld().dropItemNaturally(block.getLocation(), new ItemStack(Material.GLASS, 1));
                    event.setCancelled(true); // Cancel the event because you've done it yourself (removing of block etc.)
                }
            }else{ // No need for a new if because it is always the opposite of the first if
                return;
            }
        }
    }
}

I've added some debug code to check what the objects are holding. You can remove that part if it's working ok. This is the way I always debug when I need to check if an object is holding a value.

Also, I've removed the for loop because I think you don't need that. (With the for loop it will do everything 100 times!)

The biggest mistake you made was using one = in a if statement. But that happens to the best of us

 

You sir, are amazing! You will find a tag in my plugin page and Dev page for you help

 

Whoohoo! That's why I do this stuff!

I'm glad I could help.