[solved] Client crashing from NPE, plugin causing it?

I looked and tried diff things, I really can't find it..

Code:java

 
package me.zeus.SaveDaVillagers;
 
import java.util.HashMap;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.entity.Arrow;
import org.bukkit.entity.Entity;
import org.bukkit.entity.HumanEntity;
import org.bukkit.entity.Player;
import org.bukkit.entity.Villager;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.EntityDamageByEntityEvent;
 
public class villagerListener implements Listener {
 
    public final HashMap<String, Integer> violationLevel = new HashMap<String, Integer>();
 
    @EventHandler
    public void onVillagerHit(final EntityDamageByEntityEvent e) {
        final Entity victim = e.getEntity();
        final Entity hitter = e.getDamager();
 
        if (hitter instanceof Player) {
            if (victim instanceof Villager) {
                if (hitter instanceof Player) {
 
 
                    e.setCancelled(true);
 
                    if (violationLevel.get(((HumanEntity) hitter).getName()) == null) {
                        violationLevel.put(((HumanEntity) hitter).getName(), 0);
 
                        ((Player) hitter)
                        .kickPlayer("You are not allowed to kill villagers! (hit) Next time, your violation level raises!");
 
                        System.out.print(violationLevel);
 
                    } else {
                        violationLevel.put(((HumanEntity) hitter).getName(),
                                violationLevel.get(((HumanEntity) hitter)
                                        .getName()) + 1);
 
                        ((Player) hitter)
                        .kickPlayer("You are not allowed to kill villagers! (hit) "
                                + "Violation Level: "
                                + violationLevel.get(((HumanEntity) hitter)
                                        .getName()));
 
                        System.out.print(violationLevel);
 
                    }
 
                    Bukkit.broadcastMessage(ChatColor.GREEN + "[SDV] "
                            + ChatColor.RED + "Player: " + ChatColor.AQUA
                            + ((HumanEntity) hitter).getName() + ChatColor.RED
                            + " has attemped to " + ChatColor.YELLOW + "hit"
                            + ChatColor.RED + " a villager! \n" + ChatColor.GREEN
                            + "[SDV] " + ChatColor.DARK_RED + "Violation Level: "
                            + ChatColor.GOLD
                            + violationLevel.get(((HumanEntity) hitter).getName()));
 
                }
            }
        }
    }
 
    @EventHandler
    public void onVillagerShot(final EntityDamageByEntityEvent event) {
        if (event.getEntity() instanceof Villager
                && event.getDamager() instanceof Arrow) {
            if (((Arrow) event.getDamager()).getShooter() instanceof Player) {
                final HumanEntity shooter = (HumanEntity) ((Arrow) event
                        .getDamager()).getShooter();
                event.setCancelled(true);
 
                if (violationLevel.get(shooter.getName()) == null) {
                    violationLevel.put(shooter.getName(), 0);
 
                    ((Player) shooter)
                            .kickPlayer("You are not allowed to kill villagers! (bow) Next time, your violation level raises!");
                    System.out.print(violationLevel);
 
                } else {
                    violationLevel.put(shooter.getName(),
                            violationLevel.get(shooter.getName()) + 1);
 
                    System.out.print(violationLevel);
 
                    ((Player) shooter)
                            .kickPlayer("You are not allowed to kill villagers! (bow) Violation Level: "
                                    + violationLevel.get(shooter.getName()));
 
                }
 
                Bukkit.broadcastMessage(ChatColor.GREEN + "[SDV] "
                        + ChatColor.RED + "Player: " + ChatColor.AQUA
                        + shooter.getName() + ChatColor.RED
                        + " has attemped to " + ChatColor.YELLOW + "shoot"
                        + ChatColor.RED + " a villager! \n" + ChatColor.GREEN
                        + "[SDV] " + ChatColor.DARK_RED + "Violation Level: "
                        + ChatColor.GOLD
                        + violationLevel.get(shooter.getName()));
 
            }
        }
    }
}
 

 

you have hitter instanceofplayer twice. remove the 1st one, not that that will cause the crash i just dont see the point in having it twice

 

Still crashing when I hit a villager, then hit them again after I join the server again (because it kicks you for hitting them)

 

wait, something that crashes the client?

Im totally interested.

 

Ok, take my code and register it it onEnable() then hit a villager to start the violation level, and hit them again to crash the client LOL.

If I can find out what causes it, I can fix it and maybe make an evil plugin

It'd be nice to see what is wrong here... 0_o I seriously can not find it D;​

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

It'd be nice to have a stacktrace, so someone can find it..

 

There is no stacktrace in the console... And the client literally says "Caused by: NullPointerException" but no line numbers.

PHP:

---- Minecraft Crash Report ----
// Oops.
Time: 9/2/12 8:17 PM
Description: Unexpected error
java.lang.NullPointerException
at dv.a(Unknown Source)
at aga.a(Unknown Source)
at ahn.if(Unknown Source)
at dv.byte(Unknown Source)
at dm.else(Unknown Source)
at net.minecraft.client.Minecraft.eR(Unknown Source)
at net.minecraft.client.Minecraft.eT(Unknown Source)
at net.minecraft.client.Minecraft.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)
Relevant Details:
- Minecraft Version: 1.3.1
- Operating System: Windows 7 (amd64) version 6.1
- Java Version: 1.7.0, Oracle Corporation
- Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
- Memory: 478673368 bytes (456 MB) / 535363584 bytes (510 MB) up to 954466304 bytes (910 MB)
- JVM Flags: 2 total; -Xms512m -Xmx1024m
- LWJGL: 2.4.2
- OpenGL: AMD Radeon HD 6310 Graphics             GL version 4.1.10527 Compatibility Profile Context, ATI Technologies Inc.
- Is Modded: Probably not
- Type: Client
- Texture Pack: Sphax PureBDCraft  32x MC13.zip
- Profiler Position: N/A (disabled)


EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

This is completely off topic, but,

the server i play on, if you do /give [player] 1000000 10000000 it crashes their client and then throws an NPE (the server owner makes his own plugins, didnt check if(material == null) )

 

You do check if hitter is an instance of a player twice

EDIT: Also when there already in the hashmap you add them again

EDIT2: tried it. Its a client issue of being kicked many times...

 

Why would it kick many times? It should only kick once?

 

Both on villager hit and on villager shot are being called, causing the client to be kicked twice.

 

So it is possible to crash the client? I have so got to make a plugin called BetterKicks that crashes the client instead of just kicking

 

Yeah, just call kick twice.

 

ZeusAllMighty11 escortkeel MrBluebear3

I just hit the villager and it kicked me saying you violation level will increase. went back on and then it kicked me with violation level 1 then it just kept kicking over and over with a higher violation level

 

I fixed my problem, with the violation. If you have 2 eventhandlers, and same event... nt good