Signs not being written to

So I'm trying to have this plugin write to signs that have been created using a cuboid.
Basically the program gets the selection, creates a List<Block> of the blocks within the cuboid. Then a for loop goes through and sets all the selected blocks to a sign in which it then writes a test statement on them. For some reason the signs are being generated fine, however they are not getting any message written to them.

Code:java

List<Block> signs = Main.blocksFromTwoPoints(selection.getPoint1(),
                                    selection.getPoint2());
                            sender.sendMessage(ChatColor.YELLOW + "Selection found");
                            Block block;
 
                            for(int i = 0; i< signs.size();i++){
                                block = signs.get(i);
 
 
                                block.setType(Material.SIGN_POST);
                                Sign sign = (Sign) block.getState();
                                for(int a = 0; a<4; a++){
                                    sign.setLine(a, "sign");
                                    }
 
 
                            }

blocksFromTwoPoints Method:

Code:java

public static List<Block> blocksFromTwoPoints(Location loc1, Location loc2) {
        List<Block> blocks = new ArrayList<Block>();
 
        int topBlockX = (loc1.getBlockX() < loc2.getBlockX() ? loc2.getBlockX()
                : loc1.getBlockX());
        int bottomBlockX = (loc1.getBlockX() > loc2.getBlockX() ? loc2
                .getBlockX() : loc1.getBlockX());
 
        int topBlockY = (loc1.getBlockY() < loc2.getBlockY() ? loc2.getBlockY()
                : loc1.getBlockY());
        int bottomBlockY = (loc1.getBlockY() > loc2.getBlockY() ? loc2
                .getBlockY() : loc1.getBlockY());
 
        int topBlockZ = (loc1.getBlockZ() < loc2.getBlockZ() ? loc2.getBlockZ()
                : loc1.getBlockZ());
        int bottomBlockZ = (loc1.getBlockZ() > loc2.getBlockZ() ? loc2
                .getBlockZ() : loc1.getBlockZ());
 
        for (int x = bottomBlockX; x <= topBlockX; x++) {
            for (int z = bottomBlockZ; z <= topBlockZ; z++) {
                for (int y = bottomBlockY; y <= topBlockY; y++) {
                    Block block = loc1.getWorld().getBlockAt(x, y, z);
 
                    blocks.add(block);
                }
            }
        }
 
        return blocks;
    }

 

Code:java

sign.update();

 

hmm, doesn't seem to work.

Placed correctly?

Code:java

for(int i = 0; i< signs.size();i++){
                                block = signs.get(i);
 
 
                                block.setType(Material.SIGN_POST);
                                Sign sign = (Sign) block.getState();
 
 
                                    sign.setLine(1, "sign");
                                    sign.update();
 
 
 
                            }

 

Gopaintman
Maybe you have to do

Code:java

sign.update(true);

 

The_Doctor_123 Yep that did the trick! Thank you