Settings Manager not working right

My settings manager is not working properly as when i insert something it adds it to all 3 file, could some one help please .​

​

SettingsManager:​

Code:java

private SettingsManager() { }
 
    static SettingsManager instance = new SettingsManager();
 
    public static SettingsManager getInstance() {
        return instance;
    }
 
    Plugin p;
    FileConfiguration config;
    File cfile;
 
    FileConfiguration gangs;
    File gfile;
 
    FileConfiguration players;
    File pfile;
 
    public void setup(Plugin p) {
        config = p.getConfig();
        config.options().copyDefaults(true);
        cfile = new File(p.getDataFolder(), "config.yml");
 
        gangs = p.getConfig();
        gangs.options().copyDefaults(true);
        gfile = new File(p.getDataFolder(), "gangs.yml");
 
        players = p.getConfig();
        players.options().copyDefaults(true);
        pfile = new File(p.getDataFolder(), "players.yml");
        saveConfig();
    }
 
    public FileConfiguration getConfig() {
        return config;
    }
    public FileConfiguration getGangs() {
        return gangs;
    }
    public FileConfiguration getPlayers() { return players; }
 
    public void saveConfig() {
        try {
            config.save(cfile);
            gangs.save(gfile);
            players.save(pfile);
        } catch (IOException e) {
            Bukkit.getServer().getLogger().severe(ChatColor.RED + "Couldn't save config.yml");
            Bukkit.getServer().getLogger().severe(ChatColor.RED + "Couldn't save gangs.yml");
            Bukkit.getServer().getLogger().severe(ChatColor.RED + "Couldn't save players.yml");
        }
    }

And here is how i am inserting it:

Code:java

SettingsManager.getInstance().getGangs().createSection(gangName);
            SettingsManager.getInstance().getGangs().set(gangName + ".owner", p.getName());
            SettingsManager.getInstance().saveConfig();

Thanks in advance,
- JD

 

JD_Guy17 Look at your setup-Method. JavaPlugin.getConfig() will always return the same FileConfiguration, so your three variables point to the same object.

 

AtomSponge When I try to change it doesn't work. Shouldn't this work?

Code:java

public FileConfiguration getGangs() {
        return gangs;
    }

 

JD_Guy17 I ment those three lines:

Code:java

config = p.getConfig();
gangs = p.getConfig();
players = p.getConfig();

Take a look at this.

 

AtomSponge Still having issues with it :/.
I have no idea whats wrong

PHP:

private SettingsManager() { }
 
    static SettingsManager instance = new SettingsManager();
 
    public static SettingsManager getInstance() {
        return instance;
    }
 
    Plugin p;
    FileConfiguration config;
    File cfile;
 
    FileConfiguration players;
    File pfile;
 
    FileConfiguration gangs;
    File gfile;
 
    public void setup(Plugin p) {
        config = p.getConfig();
        config.options().copyDefaults(true);
        cfile = new File(p.getDataFolder(), "config.yml");
 
        players = YamlConfiguration.loadConfiguration(pfile);
        pfile = new File(p.getDataFolder(), "player.yml");
 
        gangs = YamlConfiguration.loadConfiguration(gfile);
        gfile = new File(p.getDataFolder(), "gangs.yml");
 
        saveConfig();
    }
 
    public FileConfiguration getConfig() {
        return config;
    }
 
    public FileConfiguration getPlayers() {
        return players;
    }
 
    public FileConfiguration getGangs() {
        return players;
    }
 
    public void saveConfig() {
        try {
            config.save(cfile);
            players.save(pfile);
            gangs.save(gfile);
        }
        catch (IOException e) {
            Bukkit.getServer().getLogger().severe(ChatColor.RED + "Could not save config.yml!");
        }
    }
 
    public void reloadConfig() {
        config = YamlConfiguration.loadConfiguration(cfile);
        players = YamlConfiguration.loadConfiguration(pfile);
        gangs = YamlConfiguration.loadConfiguration(gfile);
    }
 
    public PluginDescriptionFile getDesc() {
        return p.getDescription();
    }
}

 

JD_Guy17 Try putting

Code:java

pfile = new File(p.getDataFolder(), "player.yml");

before

Code:java

players = YamlConfiguration.loadConfiguration(pfile);

The same goes for "gangs".

 

AtomSponge Thanks

 

JD_Guy17 No problem