Solved Scoreboard not showing?

I just tried this:

onJoin Class (open) onJoin Class (close)

Code:Java

 
public class PlayerJoin implements Listener {
 
    private Main plugin;
 
    public PlayerJoin(Main plugin) {
        this.plugin = plugin;
        Bukkit.getPluginManager().registerEvents(this, plugin);
    }
 
    @EventHandler
    public void onJoin(PlayerJoinEvent e) {
        Player p = e.getPlayer();
        if (p.getWorld().getName().equals("world")) {
            ScoreboardUtil scoreboard = new ScoreboardUtil();
            scoreboard.setScoreboard(p);
            new BukkitRunnable() {
                @Override
                public void run() {
                    scoreboard.updateScoreboard(p);
                }
            }.runTaskTimer(plugin, 20*1, 20*1);
        }
    }
}
 

And the scoreboard doesn't show when i join in the world "world". :7

Main Class (open) Main Class (close)

Code:Java

 
public class Main extends JavaPlugin {
 
    public Economy econ = null;
 
    public void onEnable() {
        if (setupEconomy()) {
            new PlayerJoin(this);
            Bukkit.getConsoleSender().sendMessage(Color.here("&aSuccessfully enabled Scoreboard."));
        } else {
            Bukkit.getConsoleSender().sendMessage(Color.here("&cEconomy plugin missing!"));
        }
    }
 
    private boolean setupEconomy() {
        RegisteredServiceProvider<Economy> economyProvider = getServer().getServicesManager().getRegistration(net.milkbowl.vault.economy.Economy.class);
        if (economyProvider != null) {
            econ = economyProvider.getProvider();
        }
 
        return (econ != null);
    }
}
 

ScoreboardUtil Class (open) ScoreboardUtil Class (close)

Code:Java

 
public class ScoreboardUtil {
 
    private Main plugin;
 
    public void setScoreboard(Player p) {
        Scoreboard board = Bukkit.getScoreboardManager().getNewScoreboard();
        Objective obj = board.registerNewObjective("test", "dummy");
        obj.setDisplaySlot(DisplaySlot.SIDEBAR);
        obj.setDisplayName(Color.here("&b&lTest"));
        Team money = board.registerNewTeam("money");
        money.addEntry(Color.here("&a"));
        money.setPrefix(Color.here("&cMoney: "+plugin.econ.getBalance(p)));
        obj.getScore(Color.here("&a")).setScore(10);;
        p.setScoreboard(board);
    }
 
    public void updateScoreboard(Player p) {
        Scoreboard board = p.getScoreboard();
        board.getTeam("money").setPrefix(Color.here("&cMoney: "+plugin.econ.getBalance(p)));
    }
}
 

What am i doing wrong? Did i forget something?

 

@timtower You mean if it comes with any errors when i load the plugin? If so then no and when i do /plugins in-game it shows the plugin as green.

 

@timtower Oh, the message "Successfully enabled Scoreboard." is the one getting send in the console when i load the plugin. So it should register correctly.

 

Try to use Scoreboard with packets...

 

@timtower Not when i try this, it worked when not using teams but then it jumped around. :7

 

@timtower This is what i did before:

PlayerJoin Class (open) PlayerJoin Class (close)

Code:Java

 
public class PlayerJoin implements Listener {
 
    private Main plugin;
 
    public PlayerJoin(Main plugin) {
        this.plugin = plugin;
        Bukkit.getPluginManager().registerEvents(this, plugin);
    }
 
    @EventHandler
    public void onJoin(PlayerJoinEvent e) {
        Player p = e.getPlayer();
        if (p.getWorld().getName().equals("world")) {
            new BukkitRunnable() {
                @Override
                public void run() {
                    ScoreboardManager manager = Bukkit.getScoreboardManager();
                    Scoreboard board = manager.getNewScoreboard();
                    Objective obj = board.registerNewObjective("test", "dummy");
                    obj.setDisplayName(Color.here("&b&lTest"));
                    obj.setDisplaySlot(DisplaySlot.SIDEBAR);
                    DecimalFormat df = new DecimalFormat("#.##");
                    String balance = df.format(plugin.econ.getBalance(p));
                    Score score = obj.getScore(Color.here("&cMoney: &a"+balance));
                    score.setScore(7);
                    p.setScoreboard(board);
                }
            }.runTaskTimer(plugin, 20*1, 20*1);
        }
    }
}
 

This shows the scoreboard but it also does this weird thing where it blinks. :7
EDIT: The reason why it

 

@timtower When do i make the new scoreboard then? And if it's possible how would i check if they have a scoreboard?
Maybe something like this?:

Maybe? (open) Maybe? (close)

Code:Java

 
if (player.hasScoreboard) {
    scoreboard.create(board);
} else {
    scoreboard.update(board);
}
 

This is just an example of what i think i might need to do, i don't think those methods exists.

 

@timtower What about that? Do you mean that i should check if it is null or something?
If yes then like this?:

Like this? (open) Like this? (close)

Code:Java

 
if (board != null) {
    p.updateScoreboard(board); //I don't even know if i should do anything here if this is correct.
} else {
    p.setScoreboard(board);
}
 

 

@timtower
1. Okay, i just thought it would be nice if it didn't take as much space.
2. So i should do this?:

Code:Java

 
public class PlayerJoin implements Listener {
 
    private Main plugin;
 
    public PlayerJoin(Main plugin) {
        this.plugin = plugin;
        Bukkit.getPluginManager().registerEvents(this, plugin);
    }
 
    @EventHandler
    public void onJoin(PlayerJoinEvent e) {
        Player p = e.getPlayer();
        if (p.getWorld().getName().equals("world")) {
        //Create scoreboard here
            new BukkitRunnable() {
                @Override
                public void run() {
                    //Get and modify scoreboard here
                }
            }.runTaskTimer(plugin, 20*1, 20*1);
        }
    }
}
 

Or is that wrong? Anyway, i'll try that now, thanks.

 

@timtower Oh, i see. Thanks. I'll try that now.
EDIT: Did i do it correctly? If so i'll go ahead and try it:

Code:Java

 
public class PlayerJoin implements Listener {
 
    private Main plugin;
 
    public PlayerJoin(Main plugin) {
        this.plugin = plugin;
        Bukkit.getPluginManager().registerEvents(this, plugin);
    }
 
    @EventHandler
    public void onJoin(PlayerJoinEvent e) {
        Player p = e.getPlayer();
        if (p.getWorld().getName().equals("world")) {
            new BukkitRunnable() {
                @Override
                public void run() {
                    if (p.getScoreboard() == null) {
                        Scoreboard board = Bukkit.getScoreboardManager().getNewScoreboard();
                        Objective obj = board.registerNewObjective("test", "dummy");
                        obj.setDisplayName(Color.here("&b&lTest"));
                        obj.setDisplaySlot(DisplaySlot.SIDEBAR);
                        DecimalFormat df = new DecimalFormat("#.##");
                        String balance = df.format(plugin.econ.getBalance(p));
                        Score money = obj.getScore(Color.here("&cMoney: &a"+balance));
                        money.setScore(7);
                        p.setScoreboard(board);
                    } else {
                        Scoreboard board = p.getScoreboard();
                        Objective obj = board.registerNewObjective("test", "dummy");
                        DecimalFormat df = new DecimalFormat("#.##");
                        String balance = df.format(plugin.econ.getBalance(p));
                        Score money = obj.getScore(Color.here("&cMoney: &a"+balance));
                        money.setScore(7);
                        p.setScoreboard(board);
 
                    }
                }
            }.runTaskTimer(plugin, 0, 20*1);
        }
    }
}
 

 

@timtower I wasn't able to try before now, that's why. Anyway, i'll go ahead and try it now. EDIT: It doesn't work, still not showing when join the server. I'll try putting some messages to see if it goes through correctly, i'll get back here after that. EDIT2: Just tried putting some messages like this:

Didn't work (open) Didn't work (close)

Code:Java

 
public class PlayerJoin implements Listener {
 
    private Main plugin;
 
    public PlayerJoin(Main plugin) {
        this.plugin = plugin;
        Bukkit.getPluginManager().registerEvents(this, plugin);
    }
 
    @EventHandler
    public void onJoin(PlayerJoinEvent e) {
        Player p = e.getPlayer();
        if (p.getWorld().getName().equals("world")) {
            new BukkitRunnable() {
                @Override
                public void run() {
                    p.sendMessage(Color.here("before if getScoreboard null"));
                    if (p.getScoreboard() == null) {
                        p.sendMessage(Color.here("if scoreboard is null"));
                        Scoreboard board = Bukkit.getScoreboardManager().getNewScoreboard();
                        Objective obj = board.registerNewObjective("test", "dummy");
                        obj.setDisplayName(Color.here("&b&lTest"));
                        obj.setDisplaySlot(DisplaySlot.SIDEBAR);
                        DecimalFormat df = new DecimalFormat("#.##");
                        String balance = df.format(plugin.econ.getBalance(p));
                        Score money = obj.getScore(Color.here("&cMoney: &a"+balance));
                        money.setScore(7);
                        p.setScoreboard(board);
                    } else {
                        p.sendMessage(Color.here("else if scoreboard is not null"));
                        Scoreboard board = p.getScoreboard();
                        Objective obj = board.registerNewObjective("test", "dummy");
                        DecimalFormat df = new DecimalFormat("#.##");
                        String balance = df.format(plugin.econ.getBalance(p));
                        Score money = obj.getScore(Color.here("&cMoney: &a"+balance));
                        money.setScore(7);
                        p.setScoreboard(board);
 
                    }
                }
            }.runTaskTimer(plugin, 0, 20*1);
        }
    }
}
 

Result on join:
I get these messages every second:
"before if getScoreboard null"
"else if scoreboard is not null"
But no scoreboard shows up. :7
EDIT3: Nvm, this worked for showing it:

Code:Java

 
public class PlayerJoin implements Listener {
 
    private Main plugin;
 
    public PlayerJoin(Main plugin) {
        this.plugin = plugin;
        Bukkit.getPluginManager().registerEvents(this, plugin);
    }
 
    @EventHandler
    public void onJoin(PlayerJoinEvent e) {
        Player p = e.getPlayer();
        if (p.getWorld().getName().equals("world")) {
            new BukkitRunnable() {
                @Override
                public void run() {
                    if (p.getScoreboard().getObjective("test") == null) {
                        Scoreboard board = Bukkit.getScoreboardManager().getNewScoreboard();
                        Objective obj = board.registerNewObjective("test", "dummy");
                        obj.setDisplayName(Color.here("&b&lTest"));
                        obj.setDisplaySlot(DisplaySlot.SIDEBAR);
                        DecimalFormat df = new DecimalFormat("#.##");
                        String balance = df.format(plugin.econ.getBalance(p));
                        Score money = obj.getScore(Color.here("&cMoney: &a"+balance));
                        money.setScore(7);
                        p.setScoreboard(board);
                    } else {
                        Scoreboard board = p.getScoreboard();
                        Objective obj = board.getObjective("test");
                        DecimalFormat df = new DecimalFormat("#.##");
                        String balance = df.format(plugin.econ.getBalance(p));
                        Score money = obj.getScore(Color.here("&cMoney: &a"+balance));
                        money.setScore(7);
                        p.setScoreboard(board);
 
                    }
                }
            }.runTaskTimer(plugin, 0, 20*10);
        }
    }
}
 
 

But now that it shows it creates a new score everytime my money amount changes. :7 My guess is it does this because the balance is not the same and therefore makes a new score. :/ But how would i change that? Do i need to remove the score and then make a new one? If i need to remove the score then how would i do that? I don't see any "objective.removeScore" or anything like that. :7

 

bump.

Why does it do this and what should i do to fix it? :7

 

@timtower Would that mean i should save the score(money in this case) in a HashMap and then get the HashMap so i can remove the old balance first? If so then how would i remove it after doing that?

 

@timtower From what i've read on other threads setting it to 0 won't work because it can go in negatives as well. :7
EDIT: I think i've found a way, haven't tested it yet tho. Making a HashMap with the old balance(the current one on scoreboard) and then use "board.resetScores("&cMoney: &a"+HashMapBalance);" and then i'll set the new one.
EDIT2: Seems the "board.resetScores("&cMoney: &a"+oldbal);" does not remove the old balance from the scoreboard for some reason. :/
EDIT3: Nvm, just realized that i forgot to translateAlternateColorCodes on the resetScores, my bad. Anyway, it works now. Thanks for all the help. Changed to Solved now.