save method just save the last thing of an hashmap..

Hi!

I've done a saving method, but just the last thing wich i putted into the hashmap is saved -.-

Code:

public void save(){
if(! new File(getDataFolder(), "bd.dat").exists()){
try {
new File(getDataFolder(), "bd.dat").createNewFile();
} catch (IOException e) {
e.printStackTrace();
}
}
for(Location l : data.keySet()){
Data bd = data.get(l);
String ut = String.valueOf(bd.useTime());
String t  = String.valueOf(bd.getTime());
String up = String.valueOf(bd.getPermissionUsage());
String p  = String.valueOf(bd.getPermission());
String a  = String.valueOf(bd.isActive());
 
try {
BufferedWriter out = new BufferedWriter(new FileWriter(new File(getDataFolder(), "bd.dat")));
out.write(
new StringBuilder()
.append(l.getWorld().getName()).append(",").append(l.getX()).append(",").append(l.getY()).append(",").append(l.getZ())
.append(";")
.append(ut).append(",").append(t).append(",").append(up).append(",").append(p).append(",").append(a).toString());
out.newLine();
out.close();
}catch(Exception e){
e.printStackTrace();
}
}
}

Why ?

 

you keep overwriting your own file. Create the BufferedWriter outside of the for-loop

 

Doesn't works too There is just one thing saved :/

 

Change the filewriter constructor to

Code:

new FileWriter(new File(getDataFolder(), "bd.dat"), true)

I'm working from memory but I'm fairly sure that FileWriter can also take a boolean argument which is whether to append to the file, rather than overwriting. If you don't include it, it defaults to overwriting.

 

Doesn't woks too !

 

I just looked it up and it should work. http://docs.oracle.com/javase/1.4.2/docs/api/java/io/FileWriter.html, look at the second constructor.
I've used that before, anyway. It works fine.

 

Code:java

public void save()
{
    File data = new File(getDataFolder(), "bd.dat");
    if(!data.exists())
    {
        try 
        {
            data.mkdirs();
            new data.createNewFile();
        } 
        catch (IOException e) 
        {
            e.printStackTrace();
            return;
        }
    }
 
    BufferedWriter out = null;
    try
    {
        out = new BufferedWriter(new FileWriter(data));
 
        for(Location l : data.keySet())
        {
            Data bd = data.get(l);
            String ut = String.valueOf(bd.useTime());
            String t  = String.valueOf(bd.getTime());
            String up = String.valueOf(bd.getPermissionUsage());
            String p  = String.valueOf(bd.getPermission());
            String a  = String.valueOf(bd.isActive());
 
            out.write(
                new StringBuilder()
                .append(l.getWorld().getName()).append(",").append(l.getX()).append(",").append(l.getY()).append(",").append(l.getZ())
                .append(";")
                .append(ut).append(",").append(t).append(",").append(up).append(",").append(p).append(",").append(a).toString()
            );
            out.newLine();
        }
    }
    catch(IOException ex)
    {
        //log.info("Failed to write data to file");
        ex.printStackTrace();
    }
    finally
    {
        if(out != null)
        {
            try
            {
                out.close();
            }
            catch(IOException ex){}
        }
    }
}

Should work fine