Solved Save/Load ArrayList onDisable and onEnable?

I am trying to implement
the SLAPI (saving/loading API) by tomsik68 http://wiki.bukkit.org/Plugin_Tutorial#Saving.2FLoading_a_HashMap

which i found here first http://forums.bukkit.org/threads/go...s-ondisable-and-onenable.215814/#post-2149574 @mmonkey thanks

it's possible to use this method for saving/loading HashMaps, ArrayLists, Blocks, Players... and all Objects you know
so any help with arraylists i thank you

 

If you know it works for hashmaps, why wouldn't it work for arraylists?

 

Store in YML?

 

Because i haven't got it to save or load
Here is my onDisable and onEnable

Code:java

 
private ArrayList<Player> cooldown = new ArrayList<Player>();
  public void onEnable() {
        if(!getDataFolder().exists()) {
            getDataFolder().mkdir();
            }
        try{
            cooldown = SaveLoad.load("plugins\\RankKits\\cooldowns.bin");
        }
        catch(Exception e){
        e.printStackTrace();
        }
        getLogger().info("RankKits Enabled!");
        if (!setupEconomy()) {
            getLogger().severe(ChatColor.RED + "Disabled due to no Vault dependency found!");
            getServer().getPluginManager().disablePlugin(this);
            return;
        }
    }
 
    public void onDisable() {
        try{
        SaveLoad.save(cooldown, "plugins\\RankKits\\cooldowns.bin");
        }
        catch(Exception e){
        e.printStackTrace();
        }
 
        }

the SaveLoad class

Code:java

package me.Arrxzon.rankkits;
 
import java.io.FileInputStream;
import java.io.FileOutputStream;
import java.io.ObjectInputStream;
import java.io.ObjectOutputStream;
 
public class SaveLoad {
//@author Tomsik68<[email][email protected][/email]>
        public static <T extends Object> void save(T obj,String path) throws Exception
        {
            ObjectOutputStream oos = new ObjectOutputStream(new FileOutputStream(path));
            oos.writeObject(obj);
            oos.flush();
            oos.close();
        }
        public static <T extends Object> T load(String path) throws Exception
        {
            ObjectInputStream ois = new ObjectInputStream(new FileInputStream(path));
            @SuppressWarnings("unchecked")
            T result = (T)ois.readObject();
            ois.close();
            return result;
        }
    }

 

Arrxzon

Players are not serializable, you cannot save players! You can however use player.getName(). And you will have to change the ArrayList to:

ArrayList<String>

 

Ok arraylists are changed but were would i have to use player.getName()
Here is the cooldown

Code:java

    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
 
        final Player p = (Player) sender;
        //command args
                    if (cooldown.contains(p)) {
                        p.sendMessage(ChatColor.RED + "This kit is on cooldown!");
                        return false;
                    }
                        //do stuff
                        cooldown.add(p);
                        Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(this, new Runnable() {
                        public void run() {
                            cooldown.remove(p);
                        p.sendMessage(ChatColor.AQUA + "you can now use kit" + ChatColor.GREEN + " Private" + ChatColor.AQUA + " again!");
                        }
                    }, 1200);
                    return true;
                    }

 

Arrxzon
On line 5:

Code:java

if (cooldown.contains(p.getName())) {

On line 10:

Code:java

cooldown.add(p.getName());

On line 13:

Code:java

cooldown.remove(p.getName());

So anytime you access the ArrayLists, instead of using a Player (p), just change to a player's name: p.getName().

 

mmonkey
thanks but it don't remember after a server reload/restart unfortunately any ideas ?

 

Arrxzon
Delete your plugin's folder (not to be confused with "plugins" folder) and restart server.

 

mmonkey
no difference
except a FileNotFoundException before it creates a new one

 

Arrxzon

There is nothing to save because you are you add the player to the cooldown list, then after the cooldown period you delete them from the cooldown list, so when you save with your onDisable(), the list is empty. It is saving and loading, but it is saving and loading an empty list.

Why do you need to save your cooldown list?

 

mmonkey
This is a kits plugin
I don't believe the list should be empty as i join test server, execute the kit command, adding me to the cooldown then i reload the server within the cooldown period but i am then able to get a kit again after the reload/restart even do the cooldown should still be active

I need to save the cooldown list so after server restarts any active cooldowns will remain active

 

Arrxzon
Can I see the full code of the class containing the onCommand method?

 

mmonkey
There is not much more than above except help menu, permissions, vault economy integration and
instead of //do stuff above there is the kits and it's repeated multiple times so theres about 10 kits each with it's own cooldown and it's own array list, does that work ?

 

Arrxzon
Can you post, or send me a pm of the code where you have the kits and cooldowns. I need to see how you implement the lists.

 

mmonkey
damn i really hate how pastebin warps text but here you go
and thanks
http://pastebin.com/*****

edit:just found out there is a button to disable text wrapping xD

 

Arrxzon

It's because every time you call SaveLoad.save() you are overriding the file. Instead of naming the file "hashmap.bin" you can call it "cooldown1.bin" , "cooldown2.bin", "cooldown2.bin" etc...

 

ah nice, another thing do, now after a reload the player will not get removed after the cooldown time

 

Arrxzon

Right, so after SaveLoad.load, check if players are in the cool down, if so, run the same method you call in your onCommand.

 

Arrxzon
Sorry, I know this post is quite old now, but I was having the same problem, could you provide me the method you use to create the directory you use. I am really stuck on that!