PvP Plugin Help! REALLY CONFUSED!

Hello, I need help with a pvp plugin im making. I want to make it so the people on the same team cant hurt each other. I made 2 ArrayLists, one called blueteam and other called redteam, so I tried to make it so when someone types /team join <blue|red> they join the team and get added to it and I have a EntityDamageByEntityEvent and heres my code for it, which I don't think is correct at all.

Code:java

    ArrayList<String> redteam = new ArrayList<String>();
    ArrayList<String> blueteam = new ArrayList<String>();
 
    public void onEnable() {
        Bukkit.getServer().getPluginManager().registerEvents(this, this);
    }
 
    @EventHandler
    public void onEntityDamageByEntity(EntityDamageByEntityEvent event) {
        if (event.getEntity() instanceof Player) {
            if (blueteam.contains(event.getEntityType().PLAYER.getName())) {
                if (blueteam.contains(event.getDamager().getType().PLAYER.getName())) {
                    event.setCancelled(true);
                }
            }
            if (redteam.contains(event.getEntityType().PLAYER.getName())) {
                if (redteam.contains(event.getDamager().getType().PLAYER.getName())) {
                    event.setCancelled(true);
                }
            }
        }
    }

also I need help with a falldamage plugin where if a player has permission they can type
/falldmg <on|off> and if they have it on they get hurt and off they don't get hurt, so heres my code for that it uses a arraylist also to see if a player has falldmg on or off, so heres the code for that.

Code:java

    ArrayList<String> falldmg = new ArrayList<String>();
 
    public void onEnable() {
        Bukkit.getServer().getPluginManager().registerEvents(this, this);
    }
 
    @SuppressWarnings("deprecation")
    @EventHandler
    public void onEntityDamage(EntityDamageEvent event) {
        if (!(event instanceof EntityDamageByEntityEvent)) {
            if (event.getCause() == DamageCause.FALL) {
                if (event.getEntity() instanceof Player) {
                    event.getEntityType();
                    if (falldmg.contains(EntityType.PLAYER.getName())) {
                        event.setCancelled(true);
                    }
                }
            }
        }
    }
 
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
        Player p = (Player) sender;
 
        if (label.equalsIgnoreCase("falldmg")) {
            if (args[0].equalsIgnoreCase("on")) {
                if (falldmg.contains(p.getName())) {
                    falldmg.remove(p.getName());
                    p.sendMessage(ChatColor.DARK_RED + "[KitPvP By:Chibbey]" + ChatColor.GREEN + "You turned fall damage on, you will now get hurt!");
                    return true;
                }
                if (!falldmg.contains(p.getName())) {
                    p.sendMessage(ChatColor.DARK_RED + "[KitPvP By:Chibbey]" + ChatColor.RED + "You already have fall damage on!");
                    return true;
                }
            }
            if (args[0].equalsIgnoreCase("off")) {
                if (!falldmg.contains(p.getName())) {
                    falldmg.add(p.getName());
                    p.sendMessage(ChatColor.DARK_RED + "[KitPvP By:Chibbey]" + ChatColor.GREEN + "Fall damage is now off, you will not be hurt!");
                    return true;
                }
                if (falldmg.contains(p.getName())) {
                    p.sendMessage(ChatColor.DARK_RED + "[KitPvP By:Chibbey]" + ChatColor.RED + "You already have fall damage off!");
                    return true;

the thing that is not working is it stills lets them have falldmg, only if they had a getPlayer() in a entitydamage and entitydamagebyentity events it would be sooooo much easier. Please help me

 

You can sepereate them in teams via the scoreboard for example and disable friendly fire.

and about the getPlayer()

Code:java

@EventHandler
public void fallDamage (EntityDamageEvent e) {
if (e.getEntity() instanceof Player) {
Player p =(Player) e.getEntity();
// rest of your code
}
}

 

Chibbey
This is for your first code. I just noticed 2 aesthetic things:
If it's PVP you might want to also check if the damager was a player so use:

Code:

if((event.getEntity() instanceof Player) && event.getDamager() instanceof Player) {
// code
}

Second: instead of typing event.getEntity() .... all the time, assign variables for both the damager and the entity.

And maybe this isn't most efficient but I use HashMaps for this kind of stuff. Maybe try a HashMap<String, String>

 

AoH_Ruthless
Ok but how do I check if the player and the damager are in the same arraylist and cancle the event from them hurting eachother

 

check if arraylist contains player && arraylist contains damager if yes cancel

 

L33m4n123
how do I do that, because EntityDamageByEntityEvent cant get a player its get a entity and it wont let you get the entitys. so how do I save the players name, cause I would have to do something like this,

event.getEntity().getType() or event.getEntityType() but then event.getEntity().getType().PLAYER.getName(); but that doesn't work so I need help and the damager would have to be event.getDamager().getType().PLAYER.getName();

PLEASE HELP!

 

Ever heard of Casting? If not I would recommend you looking more into java before playing with the Bukkit API

Cannot promise you that this bit of code works. However it should give you a push into the right direction

Code:java

@EventHandler
public void onPlayerDamage(EntityDamageByEntityEvent e) {
    Player damager;
    Player damagee;
    if (e.getDamager() instanceof Player && e.getEntity() instanceof Player) {
        damager = (Player) e.getDamager();
        damagee = (Player) e.getEntity();
        // Rest of your code
    }
}