Problems with saving player location

Code:

public class wildWestBukkit extends JavaPlugin implements Listener{
    public wildWestBukkit plugin;
    public Map<String, Location> points = new HashMap<String, Location>();
    int ty;
    int tx;
    int tz;
    @Override
    public void onEnable() {
        Bukkit.getPluginManager().registerEvents(this,this);
 
    }
         
    public boolean oncommand(CommandSender sender, Command cmd, String commandLabel, String[] args){
        Player player = (Player) sender;
        if (commandLabel.equalsIgnoreCase("setbandit")){
            Player target = Bukkit.getPlayerExact(sender.getName());
            int hx = target.getLocation().getBlockX();
            int hy = target.getLocation().getBlockY();
            int hz = target.getLocation().getBlockZ();
            float pitch = target.getLocation().getPitch();
            float yaw = target.getLocation().getYaw();
       
            if (sender.hasPermission("bandit.setpoint"))
            {
            player.sendMessage(ChatColor.RED + "You have successfully set a point for bandits!");
            Location point = new Location(target.getWorld(), hx, hy, hz, pitch, yaw);
            points.put(null, point);
     
        }
     
        }
        return false;
 
    }
    @EventHandler
    public void onSignClick(PlayerInteractEvent p) {
        Material t = p.getClickedBlock().getType();
          if(t == null){
              p.setCancelled(true);
            }else if ((t == Material.WALL_SIGN || t == Material.SIGN
                || t == Material.SIGN_POST)
                && p.getAction() == Action.RIGHT_CLICK_BLOCK) {
            Sign sign = (Sign) p.getClickedBlock().getState();
            if (sign.getLine(0).contains("[Bandit]")) {
                Player player = p.getPlayer();
                player.teleport((Location) points);
            }
        }
           
      }
 
@Override
    public void onDisable() {
    }
}
                

Working on having /setbandit set the point and when you click sign it will bring you to that point. Created hashmap but the command doesn't seem to be responding?

 

Capitalize the 'c' in 'onCommand' (and while you're at it, capitalize your class name ).

 

Haha, just did both and the command works but it isn't teleporting when I right click a sign now?

 

Nerdfuryz What happens if(t != null) and is not one of the other Materials you checked for?

 

?

 

Nerdfuryz does getType() even return null?

 

Probably not, I was going to modify it later because I was getting null pointer exception

 

You can try adding some debugging messages to see where you are getting in your code and work from there. Nerdfuryz

 

I got it fixed guys no worries

Code:java

import org.bukkit.Material;
import org.bukkit.block.Sign;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Location;
import org.bukkit.World;
import org.bukkit.plugin.java.JavaPlugin;
 
public class WildWestBukkit extends JavaPlugin implements Listener{
    @Override
    public void onEnable() {
        Bukkit.getPluginManager().registerEvents(this,this);
 
    }
 
    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args){
        Player p = (Player) sender;
        if (commandLabel.equalsIgnoreCase("setbandit")){
            getConfig().set("bandit.world", p.getLocation().getWorld().getName());
            getConfig().set("bandit.x", p.getLocation().getX());
            getConfig().set("bandit.y", p.getLocation().getY());
            getConfig().set("bandit.z", p.getLocation().getZ());
            saveConfig();
            p.sendMessage(ChatColor.GREEN + "bandit set!");
            return true;
 
 
 
 
 
        }
        return false;
 
    }
    @EventHandler
    public void onSignClick(PlayerInteractEvent p) {
        Material t = p.getClickedBlock().getType();
            if ((t == Material.WALL_SIGN || t == Material.SIGN
                || t == Material.SIGN_POST)
                && p.getAction() == Action.RIGHT_CLICK_BLOCK) {
            Sign sign = (Sign) p.getClickedBlock().getState();
            if (sign.getLine(0).contains("[Bandit]")) {
                Player p2 = (Player) p.getPlayer();
                World w = Bukkit.getServer().getWorld(getConfig().getString("bandit.world"));
                double x = getConfig().getDouble("bandit.x");
                double y = getConfig().getDouble("bandit.y");
                double z = getConfig().getDouble("bandit.z");
                p2.teleport(new Location(w, x, y, z));
                p2.sendMessage(ChatColor.GREEN + "Teleport bandit");
            }
        }
 
      }
 
    @Override
    public void onDisable() {
        saveConfig();
    }
}
 

 

Nerdfuryz Good and I just realized my thinking was completely off when I said

 

By the way, I wouldn't recommend having your onCommand method return false if the command isn't /setbandit, because returning false automatically messages the command sender the value of the "usage" node in the plugin.yml, if you have the command listed there. It might confuse players who are running different commands.