Problems with default config file

I can't seem to save values to the default config file and I'm not really sure what I'm doing wrong. My main file contains a bunch of stuff that doesn't have to do with configuration, so here's various parts of my code:

Show Spoiler Hide Spoiler

Code:java

public class OcoKits extends JavaPlugin implements Listener{
 
public static HashMap<String, String> kits = new HashMap<String, String>();
 
    public void onEnable()
    {
   getConfig().createSection("kits");
   this.getConfig().options().copyDefaults(true);
   saveDefaultConfig();
getServer().getPluginManager().registerEvents(this, this);
for (String key : getConfig().getConfigurationSection("kits").getKeys(false))
{
   kits.put(key, getConfig().getString("kits." + key));
}
   saveConfig();
    }
 
    public void onDisable()
    {
   for (Entry<String, String> entry : kits.entrySet())
   {
      getConfig().set(entry.getKey(), entry.getValue());
   }
    }
 
    public void setKit(String name, Kit kit)
    {
kits.put(name, Kit.toString(kit));
    }
 
public boolean hasKit(String name, Kit kit)
{
if (kits.get(name) != null)
{
if (Kit.getKitFromString(kits.get(name)).equals(kit))
{
return true;
}else
{
return false;
}
}else
{
return false;
}
}
 
 
@EventHandler
    public void onPlayerInWater(PlayerMoveEvent e) 
{
Player p = e.getPlayer();
if (p.getGameMode() != GameMode.CREATIVE)
{
if (hasKit(p.getName(), Kit.POSEIDON))
{
Material m = p.getLocation().getBlock().getType();
if (m == Material.STATIONARY_WATER || m == Material.WATER && m != null)
{
isInWater = true;
p.setAllowFlight(true);
p.setFlying(true);
p.addPotionEffect(new PotionEffect(PotionEffectType.NIGHT_VISION, 86400 * 20, 1));
p.addPotionEffect(new PotionEffect(PotionEffectType.INCREASE_DAMAGE, 86400 * 20, 1));
}else
{
isInWater = false;
p.setAllowFlight(false);
p.setFlying(false);
p.removePotionEffect(PotionEffectType.FAST_DIGGING);
p.removePotionEffect(PotionEffectType.NIGHT_VISION);
p.removePotionEffect(PotionEffectType.INCREASE_DAMAGE);
}
}
               }

Part of onCommand:

Show Spoiler Hide Spoiler

Code:java

if (commandLabel.equalsIgnoreCase("givekit") && args.length == 2)
{
setKit(args[0], Kit.getKitFromString(args[1]));
p.sendMessage(green+"Given "+args[0]+" "+args[1]);
StringBuilder poop = new StringBuilder();
poop.append(Integer.toString(kits.size()) + " : ");
for (String stringy: kits.values())
{
poop.append(stringy + ", ");
}
p.sendMessage(poop.toString());
   reloadConfig();
}

And yeah, I have "givekit" in my plugin.yml. It sends the player "Given ocomobock POSEIDON" when I run /givekit ocomobock POSEIDON. This is my config.yml in my project folder, which I wasn't actually sure if you were supposed to put anything in it or not:

Code:yaml

kits:
 

The hasKit method works fine. If I run '/givekit ocomobock POSEIDON' it adds my name to the HashMap and everything and then I have the poseidon's abilities, but I'm just having trouble saving the HashMap to the yml. It creates the default config folder (\plugins\OcoKits\config.yml), and it says
kits: {}
but like I said, it never adds the values to the config file. Any help would be appreciated.
I'm probably just being stupid, like with most of my threads here.

 

ocomobock You aren't going to want to save a HashMap to a config file. Use an ArrayList.

Code:

ArrayList<String> kitName = getConfig().getStringList("kits");
list.add("blah");
getConfig().set("kits", list);
saveConfig();

 

Code:

ArrayList<String> kitName = getConfig().getStringList("kits");

That basically creates an ArrayList from the config file, right? Before I load from the config file I should probably be able to write to it.

 

ocomobock Why should you be able to write to a nonexistent config file? If you want to write to it, do:

Code:

getConfig().set("kits", list);

 

I'm saying 'ArrayList<String> kitName = getConfig().getStringList("kits");' wouldn't do anything because it's getting values from the config file, which I haven't actually written to yet. So I'm pretty sure 'getConfig().set("kits", list);' would return nothing.

I'm probably confused, I just started dealing with yml files <_<

 

ocomobock Well then you need to write the config file.

 

Which is essentially what this thread is about.

Bump. Anyone know why it isn't writing to the config file when onDisable is called?

I guess I needed to wait 1 more hour to bump, but I need to go now.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

A few things.
getConfig will always return a valid FileConfigurtion object. getConfig will only read from disk the first time it is called. getConfig only returns a different FileConfiguration after reloadConfig has been called otherwise it will return the same object. FileConfiguration's set method does not modify the contents on disk. Set can take any ConfigurationSerializable type, java primitives, and certain collections including hashmap<String, String>

 

I'm sorry, but do you know what I should actually do to fix it? I kind of just started with config stuff so I'm still confused <_<

EDIT: I changed these two methods:

Code:java

public void onEnable()
{
getConfig().createSection("kits");
this.getConfig().options().copyDefaults(true);
saveDefaultConfig();
getServer().getPluginManager().registerEvents(this, this);
for (String key : getConfig().getConfigurationSection("kits").getKeys(false))
{
kits.put(key, getConfig().getString("kits." + key));
}
}
 
public void onDisable()
{
for (Entry<String, String> entry : kits.entrySet())
{
getConfig().set(entry.getKey(), entry.getValue());
}
saveConfig();
}

And that works, but it's writing it outside of the kits section.

Like I said, my config.yml in my project folder looks like this:

Code:

kits:
 

Should I even have a config.yml there? And this is my new config.yml in my actual server folder:

ocomobuck: THOR
ocomobock: POSEIDON
ocomoback: POSEIDON

After running /givekit ocomoback POSEIDON, /givekit ocomobock POSEIDON, /givekit ocomobuck THOR

 

ocomobock
As I said, the set method does not modify the file on disk, it is purely a memory operation. You can set anything you want in memory and it will stay in memory until saveConfig is called to write it to disk.

Additionally, saveDefaultConfig works independently. The method copies the config.yml in your jar into the datafolder only if the datafolder does not have a config.yml already. The method is by design idempotent.

 

Sagacious_Zed
I got it to work, thanks.

Most of the commands from my plugin that were working before aren't working now, but I'll try to fix that.